Remove MODULE_PARM from arch/i386
PATCH 1/1 Remove MODULE_PARM from arch/i386
Name: Remove MODULE_PARM from i386 arch
Status: Compiled on 2.6-bk
Depends: Module/MODULE_PARM-defconfig.patch.gz
This patch removes MODULE_PARM for everything under arch/i386. Currently only APM.
arch/i386/kernel/apm.c +9 -9
@@ -2393,27 +2393,27 @@ module_exit(apm_exit);MODULE_AUTHOR ("Stephen Rothwell" );MODULE_DESCRIPTION ("Advanced Power Management" );MODULE_LICENSE ("GPL" ); -MODULE_PARM (debug,"i" ); +module_param (debug, bool,0644 );MODULE_PARM_DESC (debug,"Enable debug mode" ); -MODULE_PARM (power_off,"i" ); +module_param (power_off, bool,0444 );MODULE_PARM_DESC (power_off,"Enable power off" ); -MODULE_PARM (bounce_interval,"i" ); +module_param (bounce_interval, int,0444 );MODULE_PARM_DESC (bounce_interval,"Set the number of ticks to ignore suspend bounces" ); -MODULE_PARM (allow_ints,"i" ); +module_param (allow_ints, bool,0444 );MODULE_PARM_DESC (allow_ints,"Allow interrupts during BIOS calls" ); -MODULE_PARM (broken_psr,"i" ); +module_param (broken_psr, bool,0444 );MODULE_PARM_DESC (broken_psr,"BIOS has a broken GetPowerStatus call" ); -MODULE_PARM (realmode_power_off,"i" ); +module_param (realmode_power_off, bool,0444 );MODULE_PARM_DESC (realmode_power_off,"Switch to real mode before powering off" ); -MODULE_PARM (idle_threshold,"i" ); +module_param (idle_threshold, int,0444 );MODULE_PARM_DESC (idle_threshold,"System idle percentage above which to make APM BIOS idle calls" ); -MODULE_PARM (idle_period,"i" ); +module_param (idle_period, int,0444 );MODULE_PARM_DESC (idle_period,"Period (in sec/100) over which to caculate the idle percentage" ); -MODULE_PARM (smp,"i" ); +module_param (smp, bool,0444 );MODULE_PARM_DESC (smp,"Set this to enable APM use on an SMP platform. Use with caution on older systems" );MODULE_ALIAS_MISCDEV (APM_MINOR_DEV );
Signature · 1 line
Anyone who quotes me in their signature is an idiot -- Rusty Russell
Quoted 12 lines · Rusty Russell
Name: Remove
MODULE_PARMfrom i386 arch
Status: Compiled on 2.6-bk
Depends: Module/MODULE_PARM-defconfig.patch.gzSigned-off-by Rusty Russell <[email protected]>This patch removes
MODULE_PARMfor everything underarch/i386. Currently only APM.diff -urpN --exclude TAGS -X
/home/rusty/devel/kernel/kernel-patches/current-dontdiff--minimal.3678-linux-2.6-bk/arch/i386/kernel/apm.c.3678-linux-2.6-bk.updated/arch/i386/kernel/apm.c
arch/i386/kernel/apm.c 2004-10-20 17:56:12.000000000 +1000 module_exit(apm_exit); · line 2398
Quoted 8 lines
arch/i386/kernel/apm.c 2004-10-20 17:56:12.000000000 +1000 renamed from arch/i386/kernel/apm.c 2004-10-19 14:33:50.000000000 +1000 +2
-2@@ -2393,27 +2393,27 @@ module_exit(apm_exit); MODULE_AUTHOR("Stephen Rothwell"); MODULE_DESCRIPTION("Advanced Power Management"); MODULE_LICENSE("GPL"); -MODULE_PARM(debug, "i"); +module_param(debug, bool, 0644); MODULE_PARM_DESC(debug, "Enable debug mode"); -MODULE_PARM(power_off, "i"); +module_param(power_off, bool, 0444);
^^^^^
I am wondering if we need to waste kernel resources by creating sysfs attributes for parameters that can not be changed at runtime (by user or kernel)...
Signature · 1 line
Dmitry