Skip to contentSkip to conversation

Should osst call cdev_alloc()

DISCUSSION Willem Riede 2 participants 3 messages Oct 23, 2004

lore
Share & tools
lore
#0 lore raw

Currently, sg.c and st.c contain calls to cdev_alloc() and friends:

[wriede@serve kernel]$ find linux-2.6.9 -name '*.c' | xargs grep cdev_alloc
linux-2.6.9/drivers/s390/char/tape_class.c: tcd->char_device =
cdev_alloc();

linux-2.6.9/drivers/scsi/sg.c:  cdev = cdev_alloc();
linux-2.6.9/drivers/scsi/sg.c:          printk(KERN_WARNING "cdev_alloc
failed\n");
linux-2.6.9/drivers/scsi/st.c:                  cdev = cdev_alloc();
linux-2.6.9/fs/char_dev.c:      cdev = cdev_alloc();

linux-2.6.9/fs/char_dev.c:struct cdev *cdev_alloc(void) linux-2.6.9/fs/char_dev.c:EXPORT_SYMBOL(cdev_alloc);

My question is: should osst do the same? It seems to work just fine without.

Please cc me on answers, as I'm currently not subscribed to linux-kernel.

Thanks, Willem Riede,
osst maintainer

#1 lore raw
Quoted 11 lines · Willem Riede

Currently, sg.c and st.c contain calls to cdev_alloc() and friends:

[wriede@serve kernel]$ find linux-2.6.9 -name '*.c' | xargs grep cdev_alloc
linux-2.6.9/drivers/s390/char/tape_class.c: tcd->char_device =
cdev_alloc();

linux-2.6.9/drivers/scsi/sg.c:  cdev = cdev_alloc();
linux-2.6.9/drivers/scsi/sg.c:          printk(KERN_WARNING "cdev_alloc
failed\n");
linux-2.6.9/drivers/scsi/st.c:                  cdev = cdev_alloc();
linux-2.6.9/fs/char_dev.c:      cdev = cdev_alloc();
Quoted 6 lines

linux-2.6.9/fs/char_dev.c:struct cdev *cdev_alloc(void) linux-2.6.9/fs/char_dev.c:EXPORT_SYMBOL(cdev_alloc);

My question is: should osst do the same? It seems to work just fine without.

The reason why st.c calls cdev_alloc() directly is that this allows it to use the large minor numbers (some people want to use more than 32 tapes). This also used to give presence in sysfs but that is not the case any more. The devices can be shown in sysfs using device classes (st.c uses the class_simple_* functions).

Osst does call cdev_alloc() indirectly through register_chrdev(). This is the link between the "old style" character device allocation and the current method. As long as register_chrdev() exists, you don't have any pressing need to change osst unless you want to support more than 256 minors.

Signature · 1 line
Kai
#2 lore raw
Quoted 13 lines · Kai Makisara
Quoted 3 lines · Willem Riede

Currently, sg.c and st.c contain calls to cdev_alloc() and friends:

My question is: should osst do the same? It seems to work just fine

without.

Quoted 1 line

The reason why st.c calls cdev_alloc() directly is that this allows it to use the large minor numbers (some people want to use more than 32 tapes). This also used to give presence in sysfs but that is not the case any more. The devices can be shown in sysfs using device classes (st.c uses the class_simple_* functions).

Quoted 5 lines

Osst does call cdev_alloc() indirectly through register_chrdev(). This is the link between the "old style" character device allocation and the current method. As long as register_chrdev() exists, you don't have any pressing need to change osst unless you want to support more than 256 minors.

Thanks. Given that the Onstream devices were targeted at the low end market, I see no need to support many drives of this type, so I'll leave it as it is.

Willem Riede.