Skip to contentSkip to conversation

X.25 : Stop /proc/net/x25/route infinitely reading

PATCH New Andrew Hendry 1 participant 1 message Oct 25, 2004 X.25 stack

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 X.25 : Stop /proc/net/x25/route infinitely reading

The problem:
route add --x25 0/0 eth0
cat /proc/net/x25/route
reads the single routing entry forever.

This patch makes x25_get_route_idx behave the same as x25_get_socket_idx which works correctly.

Andrew.

diff -up linux-2.6.8.1/net/x25/x25_proc.c.orig linux-2.6.8.1/net/x25/x25_proc.c
--- linux-2.6.8.1/net/x25/x25_proc.c.orig 2004-10-25
09:27:58.600069976 +1000
+++ linux-2.6.8.1/net/x25/x25_proc.c 2004-10-25 09:29:30.079163040
+1000
@@ -32,10 +32,11 @@ static __inline__ struct x25_route *x25_

        list_for_each(route_entry, &x25_route_list) {
                rt = list_entry(route_entry, struct x25_route, node);
-               if (--pos)
-                       break;
+               if (!pos--)
+                       goto found;
        }
-
+       rt = NULL;
+found:
        return rt;

}