bugfixes for hns3 PMD
cover bugfixes for hns3 PMD
This patchset contains 6 bugfixes for hns3 PMD.
Huisong Li (5):
net/hns3: fix inconsistent enabled RSS behavior net/hns3: remove unnecessary RSS switch net/hns3: fix the time waiting for PF reset completion net/hns3: fix RSS TC mode entry
net/hns3: fix VF RSS TC mode entry
Jie Hai (1):
net/hns3: remove duplicate macro definition
drivers/net/hns3/hns3_cmd.h | 1 - drivers/net/hns3/hns3_ethdev.c | 2 - drivers/net/hns3/hns3_ethdev.h | 1 - drivers/net/hns3/hns3_ethdev_vf.c | 9 ++-- drivers/net/hns3/hns3_flow.c | 6 ++- drivers/net/hns3/hns3_rss.c | 69 +++++++++++++++++++++++-------- 6 files changed, 62 insertions(+), 26 deletions(-)
Signature · 1 line
2.33.0
PATCH 1/6 net/hns3: remove duplicate macro definition
From: Jie Hai <[email protected]>
This patch fixes duplicate macro definition of HNS3_RSS_CFG_TBL_SIZE.
--- drivers/net/hns3/hns3_cmd.h | 1 - 1 file changed, 1 deletion(-)
drivers/net/hns3/hns3_cmd.h +0 -1
@@ -603,7 +603,6 @@ struct hns3_cfg_gro_status_cmd {#define HNS3_RSS_HASH_KEY_OFFSET_B 4 -#define HNS3_RSS_CFG_TBL_SIZE 16#define HNS3_RSS_HASH_KEY_NUM 16/* Configure the algorithm mode and Hash Key, opcode:0x0D01 */ struct hns3_rss_generic_config_cmd {
Signature · 1 line
2.33.0
Re: [PATCH 1/6] net/hns3: remove duplicate macro definition
Quoted 8 lines · Min Hu (Connor)
From: Jie Hai <[email protected]>
This patch fixes duplicate macro definition of
HNS3_RSS_CFG_TBL_SIZE.Fixes 737f30e1c3ab ("net/hns3: support command interface with firmware")Signed-off-by Jie Hai <[email protected]>
Except from 2/6, 3/6, 4/6
Series applied to dpdk-next-net/main, thanks.
For 2/6, 3/6 can be good to wait for more comment on RSS configuration.
For 4/6 can you please send a new version.
Ferruh Yigit
Acked-by Min Hu (Connor)Re: [PATCH 1/6] net/hns3: remove duplicate macro definition
Quoted 5 lines · Ferruh Yigit
Quoted 4 lines · Min Hu (Connor)
From: Jie Hai <[email protected]>
This patch fixes duplicate macro definition of
HNS3_RSS_CFG_TBL_SIZE.
Quoted 8 lines
Quoted 4 lines
Fixes 737f30e1c3ab ("net/hns3: support command interface with firmware")Signed-off-by Jie Hai <[email protected]>Except from 2/6, 3/6, 4/6
Series applied to dpdk-next-net/main, thanks.
Hi Connor,
I am adding your explicit ack in the next-net for merged patches, please let me if you have an objection.
Quoted 5 lines
For 2/6, 3/6 can be good to wait for more comment on RSS configuration.
For 4/6 can you please send a new version.
PATCH 2/6 net/hns3: fix inconsistent enabled RSS behavior
In reply to Min Hu (Connor)From: Huisong Li <[email protected]>
RSS will not be enabled if the RTE_ETH_MQ_RX_RSS_FLAG isn't be set in dev_configure phase. However, if this flag isn't set, RSS can be enabled through the ethdev ops and rte_flow API. This behavior is contrary to each other.
--- drivers/net/hns3/hns3_flow.c | 5 +++++ drivers/net/hns3/hns3_rss.c | 12 ++++++++++++ 2 files changed, 17 insertions(+)
drivers/net/hns3/hns3_flow.c +5 -0
@@ -1371,6 +1371,7 @@ hns3_parse_rss_filter(struct rte_eth_dev *dev,const struct rte_flow_action *actions, struct rte_flow_error *error) { + enum rte_eth_rx_mq_mode mq_mode = dev->data->dev_conf.rxmode.mq_mode;struct hns3_adapter *hns = dev->data->dev_private;struct hns3_hw *hw = &hns->hw;struct hns3_rss_conf *rss_conf = &hw->rss_info;
@@ -1426,6 +1427,10 @@ hns3_parse_rss_filter(struct rte_eth_dev *dev,RTE_FLOW_ERROR_TYPE_ACTION_CONF , &rss->types, "input RSS types are not supported"); +if (!((uint32_t )mq_mode &RTE_ETH_MQ_RX_RSS_FLAG )) +return rte_flow_error_set (error,ENOTSUP , +RTE_FLOW_ERROR_TYPE_ACTION_CONF , + act,"multi-queue RSS isn't enabled" ); act_index++;
drivers/net/hns3/hns3_rss.c +12 -0
@@ -399,6 +399,7 @@ int hns3_dev_rss_hash_update(struct rte_eth_dev *dev, struct rte_eth_rss_conf *rss_conf) { + enum rte_eth_rx_mq_mode mq_mode = dev->data->dev_conf.rxmode.mq_mode;struct hns3_adapter *hns = dev->data->dev_private;struct hns3_hw *hw = &hns->hw;struct hns3_rss_tuple_cfg *tuple = &hw->rss_info.rss_tuple_sets;
@@ -408,6 +409,11 @@ hns3_dev_rss_hash_update(struct rte_eth_dev *dev,uint8_t *key = rss_conf->rss_key;int ret; +if (!((uint32_t )mq_mode &RTE_ETH_MQ_RX_RSS_FLAG )) { +hns3_err (hw,"multi-queue RSS isn't enabled." ); +return -EOPNOTSUPP ; + } +if (hw->rss_dis_flag)return -EINVAL ;
@@ -498,6 +504,7 @@ hns3_dev_rss_reta_update(struct rte_eth_dev *dev, struct rte_eth_rss_reta_entry64 *reta_conf, uint16_t reta_size) { +enum rte_eth_rx_mq_mode mq_mode = dev->data->dev_conf.rxmode.mq_mode;struct hns3_adapter *hns = dev->data->dev_private;struct hns3_hw *hw = &hns->hw;struct hns3_rss_conf *rss_cfg = &hw->rss_info;
@@ -506,6 +513,11 @@ hns3_dev_rss_reta_update(struct rte_eth_dev *dev,uint16_t i;int ret; +if (!((uint32_t )mq_mode &RTE_ETH_MQ_RX_RSS_FLAG )) { +hns3_err (hw,"multi-queue RSS isn't enabled." ); +return -EOPNOTSUPP ; + } +if (reta_size != hw->rss_ind_tbl_size) {hns3_err (hw,"The size of hash lookup table configured (%u)" "doesn't match the number hardware can supported"
Signature · 1 line
2.33.0
Re: [PATCH 2/6] net/hns3: fix inconsistent enabled RSS behavior
Quoted 11 lines · Min Hu (Connor)
From: Huisong Li <[email protected]>
RSS will not be enabled if the
RTE_ETH_MQ_RX_RSS_FLAGisn't be set indev_configurephase. However, if this flag isn't set, RSS can be enabled through the ethdev ops andrte_flowAPI. This behavior is contrary to each other.Fixes c37ca66f2b27 ("net/hns3: support RSS")Signed-off-by Huisong Li <[email protected]>
Hi Huisong, Connor,
Let's get a little more feedback for this patch, cc'ed more people.
To enable RSS, multi queue mode should be set to 'RTE_ETH_MQ_RX_RSS_FLAG'.
But I wonder if it is required to configure RSS via flow API, and if other PMDs check this configuration for flow API?
Re: [PATCH 2/6] net/hns3: fix inconsistent enabled RSS behavior
Quoted 14 lines · Ferruh Yigit
Quoted 11 lines · Min Hu (Connor)
From: Huisong Li <[email protected]>
RSS will not be enabled if the
RTE_ETH_MQ_RX_RSS_FLAGisn't be set indev_configurephase. However, if this flag isn't set, RSS can be enabled through the ethdev ops andrte_flowAPI. This behavior is contrary to each other.Fixes c37ca66f2b27 ("net/hns3: support RSS")Signed-off-by Huisong Li <[email protected]>
Quoted 8 lines
Hi Huisong, Connor,
Let's get a little more feedback for this patch, cc'ed more people.
To enable RSS, multi queue mode should be set to '
RTE_ETH_MQ_RX_RSS_FLAG'.But I wonder if it is required to configure RSS via flow API,
I do not know the original purpose of adding the RSS configuration in flow API.
However, as far as I know, the hash algorithm can be configured via this API,
but not via ethdev ops API.
Quoted 1 line
and if other PMDs check this configuration for flow API?
Some PMDs already have similar check in RSS releated ops or rte_flow API.
For example, hinic, axbge, bnxt, cnxk, otx2, and ena.
Quoted 1 line
.
RE: [PATCH 2/6] net/hns3: fix inconsistent enabled RSS behavior
Hi Lihuisong,
Quoted 27 lines
-----Original Message-----
From: lihuisong (C) <[email protected]>
Sent: Wednesday, March 2, 2022 4:10 AM
Subject: Re: [PATCH 2/6] net/hns3: fix inconsistent enabled RSS behaviorQuoted 20 lines · Ferruh Yigit
Quoted 8 lines · Min Hu (Connor)
From: Huisong Li <[email protected]>
RSS will not be enabled if the
RTE_ETH_MQ_RX_RSS_FLAGisn't be set indev_configurephase. However, if this flag isn't set, RSS can be enabled through the ethdev ops andrte_flowAPI. This behavior is contrary to each
other.Quoted 4 lines
Fixes c37ca66f2b27 ("net/hns3: support RSS")Signed-off-by Huisong Li <[email protected]>Hi Huisong, Connor,
Let's get a little more feedback for this patch, cc'ed more people.
Quoted 8 lines
Quoted 4 lines
To enable RSS, multi queue mode should be set to
'RTE_ETH_MQ_RX_RSS_FLAG'.But I wonder if it is required to configure RSS via flow API,
I do not know the original purpose of adding the RSS configuration in flow API.
The purpose is simple, this allow to create RSS per rule and not a global one. For example create RSS that sends TCP to some queues while othe RSS will send UDP traffic to different queues.
Quoted 12 lines
However, as far as I know, the hash algorithm can be configured via this API,
but not via ethdev ops API.
Quoted 1 line
and if other PMDs check this configuration for flow API?
Some PMDs already have similar check in RSS releated ops or
rte_flowAPI.For example, hinic, axbge, bnxt, cnxk, otx2, and ena.
Quoted 1 line
.
From my view point those are two different settings. The RTE_ETH_MQ_RX_RSS_FLAG is global per port while rte_flow is per rule.
I think, that if a PMD needs this flag, in order to enable it also for rte_flow then it should be documented in the release note of the PMD.
It is a valid use case that the default traffic will not have RSS and only rules created by rte_flow will have the RSS, for matching traffc.
Best,
Ori
Re: [PATCH 2/6] net/hns3: fix inconsistent enabled RSS behavior
02/03/2022 15:07, Ori Kam:
Quoted 25 lines
From: lihuisong (C) <[email protected]>
Quoted 24 lines · Ferruh Yigit
Quoted 23 lines · Min Hu (Connor)
Quoted 8 lines
From: Huisong Li <[email protected]>
RSS will not be enabled if the
RTE_ETH_MQ_RX_RSS_FLAGisn't be set indev_configurephase. However, if this flag isn't set, RSS can be enabled through the ethdev ops andrte_flowAPI. This behavior is contrary to each
other.Quoted 4 lines
Fixes c37ca66f2b27 ("net/hns3: support RSS")Signed-off-by Huisong Li <[email protected]>Hi Huisong, Connor,
Let's get a little more feedback for this patch, cc'ed more people.
To enable RSS, multi queue mode should be set to
'RTE_ETH_MQ_RX_RSS_FLAG'.
Quoted 19 lines
Quoted 5 lines
Quoted 1 line
But I wonder if it is required to configure RSS via flow API,
I do not know the original purpose of adding the RSS configuration in flow API.
The purpose is simple, this allow to create RSS per rule and not a global one. For example create RSS that sends TCP to some queues while othe RSS will send UDP traffic to different queues.
Quoted 10 lines
However, as far as I know, the hash algorithm can be configured via this API,
but not via ethdev ops API.
Quoted 1 line
and if other PMDs check this configuration for flow API?
Some PMDs already have similar check in RSS releated ops or
rte_flowAPI.For example, hinic, axbge, bnxt, cnxk, otx2, and ena.
I suggest removing these checks.
Quoted 8 lines
From my view point those are two different settings. The
RTE_ETH_MQ_RX_RSS_FLAGis global per port whilerte_flowis per rule.I think, that if a PMD needs this flag, in order to enable it also for
rte_flowthen it should be documented in the release note of the PMD.
It is a valid use case that the default traffic will not have RSS and only rules created byrte_flowwill have the RSS, for matching traffc.
I think RTE_ETH_MQ_RX_RSS_FLAG should not be required by any PMD for rte_flow RSS rules.
Re: [PATCH 2/6] net/hns3: fix inconsistent enabled RSS behavior
Quoted 52 lines · On Wed, 02 Mar 2022 15:46:37 +0100 Thomas Monjalon <[email protected]> wrote:
02/03/2022 15:07, Ori Kam:
Quoted 25 lines
From: lihuisong (C) <[email protected]>
Quoted 24 lines · Ferruh Yigit
Quoted 23 lines · Min Hu (Connor)
Quoted 8 lines
From: Huisong Li <[email protected]>
RSS will not be enabled if the
RTE_ETH_MQ_RX_RSS_FLAGisn't be set indev_configurephase. However, if this flag isn't set, RSS can be enabled through the ethdev ops andrte_flowAPI. This behavior is contrary to each
other.Quoted 4 lines
Fixes c37ca66f2b27 ("net/hns3: support RSS")Signed-off-by Huisong Li <[email protected]>Hi Huisong, Connor,
Let's get a little more feedback for this patch, cc'ed more people.
To enable RSS, multi queue mode should be set to
'RTE_ETH_MQ_RX_RSS_FLAG'.Quoted 19 lines
Quoted 5 lines
Quoted 1 line
But I wonder if it is required to configure RSS via flow API,
I do not know the original purpose of adding the RSS configuration in flow API.
The purpose is simple, this allow to create RSS per rule and not a global one. For example create RSS that sends TCP to some queues while othe RSS will send UDP traffic to different queues.
Quoted 10 lines
However, as far as I know, the hash algorithm can be configured via this API,
but not via ethdev ops API.
Quoted 1 line
and if other PMDs check this configuration for flow API?
Some PMDs already have similar check in RSS releated ops or
rte_flowAPI.For example, hinic, axbge, bnxt, cnxk, otx2, and ena.
I suggest removing these checks.
Quoted 4 lines
From my view point those are two different settings. The
RTE_ETH_MQ_RX_RSS_FLAGis global per port whilerte_flowis per rule.
Quoted 9 lines
Quoted 4 lines
I think, that if a PMD needs this flag, in order to enable it also for
rte_flowthen it should be documented in the release note of the PMD.
It is a valid use case that the default traffic will not have RSS and only rules created byrte_flowwill have the RSS, for matching traffc.I think
RTE_ETH_MQ_RX_RSS_FLAGshould not be required by any PMD forrte_flowRSS rules.
Agreed.
The ideal state around RSS would be:
- global settings affect the default started queues when device is started. if RSS is enabled and 4 queues are started, then RSS would happen for received packets across those 4 queues.
- when adding new flow related rx:
- new queues could be started - BUT not part of original RSS
- new rte_flow rule can do RSS against the new flow:
example:
start queues 4,5,6,7
rte_flow match TCP port 80 and process on queues 4,5,6,7 with RSS
This is a mess today, most devices work differently and there is no reference software implementation. In an ideal state, there would be a reference software implementation that implements all of rte_flow, and all new hardware support would have to work the same as the reference implementation. And there would be a full CI test suite around rte_flow.
Re: [PATCH 2/6] net/hns3: fix inconsistent enabled RSS behavior
Thanks, Stephen.
Quoted 59 lines · Stephen Hemminger
Quoted 48 lines · On Wed, 02 Mar 2022 15:46:37 +0100 Thomas Monjalon <[email protected]> wrote:
02/03/2022 15:07, Ori Kam:
Quoted 24 lines
From: lihuisong (C) <[email protected]>
Quoted 23 lines · Ferruh Yigit
Quoted 22 lines · Min Hu (Connor)
Quoted 8 lines
From: Huisong Li <[email protected]>
RSS will not be enabled if the
RTE_ETH_MQ_RX_RSS_FLAGisn't be set indev_configurephase. However, if this flag isn't set, RSS can be enabled through the ethdev ops andrte_flowAPI. This behavior is contrary to each
other.Quoted 4 lines
Fixes c37ca66f2b27 ("net/hns3: support RSS")Signed-off-by Huisong Li <[email protected]>Hi Huisong, Connor,
Let's get a little more feedback for this patch, cc'ed more people.
To enable RSS, multi queue mode should be set to
'RTE_ETH_MQ_RX_RSS_FLAG'.Quoted 17 lines
Quoted 4 lines
Quoted 1 line
But I wonder if it is required to configure RSS via flow API,
I do not know the original purpose of adding the RSS configuration in flow API.
The purpose is simple, this allow to create RSS per rule and not a global one. For example create RSS that sends TCP to some queues while othe RSS will send UDP traffic to different queues.
Quoted 9 lines
However, as far as I know, the hash algorithm can be configured via this API,
but not via ethdev ops API.
Quoted 1 line
and if other PMDs check this configuration for flow API?
Some PMDs already have similar check in RSS releated ops or
rte_flowAPI.For example, hinic, axbge, bnxt, cnxk, otx2, and ena.
I suggest removing these checks.
Quoted 4 lines
From my view point those are two different settings.
TheRTE_ETH_MQ_RX_RSS_FLAGis global per port whilerte_flowis per rule.Quoted 8 lines
Quoted 4 lines
I think, that if a PMD needs this flag, in order to enable it also for
rte_flowthen it should be documented in the release note of the PMD.
It is a valid use case that the default traffic will not have RSS and only rules created byrte_flowwill have the RSS, for matching traffc.I think
RTE_ETH_MQ_RX_RSS_FLAGshould not be required by any PMD forrte_flowRSS rules.
Quoted 8 lines
Agreed.
The ideal state around RSS would be:
- global settings affect the default started queues when device is started. if RSS is enabled and 4 queues are started, then RSS would happen for received packets across those 4 queues.
- when adding new flow related rx:
- new queues could be started - BUT not part of original RSS
How should I understand this? If do this, we have to increase queue numbers.
Quoted 4 lines
- new
rte_flowrule can do RSS against the new flow:
example:
start queues 4,5,6,7
rte_flowmatch TCP port 80 and process on queues 4,5,6,7 with RSS
I think you have the same view as Ori. But some original RSS hash configuration has been overwritten by a new rule, such as redirection table.
Quoted 6 lines
This is a mess today, most devices work differently and there is no reference software implementation. In an ideal state, there would be a reference software implementation that implements all of
rte_flow, and all new hardware support would have to work the same as the reference implementation. And there would be a full CI test suite aroundrte_flow. .
Re: [PATCH 2/6] net/hns3: fix inconsistent enabled RSS behavior
In reply to Stephen HemmingerHi, all,
Quoted 27 lines · Stephen Hemminger
Quoted 23 lines · On Wed, 02 Mar 2022 15:46:37 +0100 Thomas Monjalon <[email protected]> wrote:
02/03/2022 15:07, Ori Kam:
Quoted 22 lines
From: lihuisong (C) <[email protected]>
Quoted 21 lines · Ferruh Yigit
Quoted 20 lines · Min Hu (Connor)
Quoted 8 lines
From: Huisong Li <[email protected]>
RSS will not be enabled if the
RTE_ETH_MQ_RX_RSS_FLAGisn't be set indev_configurephase. However, if this flag isn't set, RSS can be enabled through the ethdev ops andrte_flowAPI. This behavior is contrary to each
other.Quoted 4 lines
Fixes c37ca66f2b27 ("net/hns3: support RSS")Signed-off-by Huisong Li <[email protected]>Hi Huisong, Connor,
Let's get a little more feedback for this patch, cc'ed more people.
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 4 lines
To enable RSS, multi queue mode should be set to
'RTE_ETH_MQ_RX_RSS_FLAG'.But I wonder if it is required to configure RSS via flow API,
I do not know the original purpose of adding the RSS configuration in flow API.
In OVS-DPDK, there is a use case to add mark+rss action via flow API. See [1]:
[1]: https://github.com/openvswitch/ovs/blob/master/lib/netdev-offload-dpdk.c#L1677
Quoted 45 lines
Quoted 22 lines
Quoted 15 lines
Quoted 1 line
The purpose is simple, this allow to create RSS per rule and not a global one. For example create RSS that sends TCP to some queues while othe RSS will send UDP traffic to different queues.
Quoted 10 lines
However, as far as I know, the hash algorithm can be configured via this API,
but not via ethdev ops API.
Quoted 1 line
and if other PMDs check this configuration for flow API?
Some PMDs already have similar check in RSS releated ops or
rte_flowAPI.For example, hinic, axbge, bnxt, cnxk, otx2, and ena.
I suggest removing these checks.
Quoted 4 lines
From my view point those are two different settings. The
RTE_ETH_MQ_RX_RSS_FLAGis global per port whilerte_flowis per rule.Quoted 9 lines
Quoted 4 lines
I think, that if a PMD needs this flag, in order to enable it also for
rte_flowthen it should be documented in the release note of the PMD.
It is a valid use case that the default traffic will not have RSS and only rules created byrte_flowwill have the RSS, for matching traffc.I think
RTE_ETH_MQ_RX_RSS_FLAGshould not be required by any PMD forrte_flowRSS rules.Agreed.
The ideal state around RSS would be:
- global settings affect the default started queues when device is started. if RSS is enabled and 4 queues are started, then RSS would happen for received packets across those 4 queues.
- when adding new flow related rx:
- new queues could be started - BUT not part of original RSS
- newrte_flowrule can do RSS against the new flow:
example:
start queues 4,5,6,7
rte_flowmatch TCP port 80 and process on queues 4,5,6,7 with RSS
Quoted 4 lines
This is a mess today, most devices work differently and there is no reference software implementation. In an ideal state, there would be a reference software implementation that implements all of
rte_flow, and all new hardware support would have to work the same as the reference implementation. And there would be a full CI test suite aroundrte_flow.
When adding a new flow with RSS action, does the RSS hash type have to be set or it could inherit the global setting? I see there are some different behaviors when we use RSS actions without hash types. In my test, the E810 and Broadcom NetXtreme-E work well but there are some problems in MLX5. There is a patch in [2]. Anyone could give some suggestions?
[2]: https://patchwork.ozlabs.org/project/openvswitch/patch/[email protected]/
Signature · 1 line
Thanks, Harold.
Re: [PATCH 2/6] net/hns3: fix inconsistent enabled RSS behavior
In reply to Ori KamHi, Ori,
Quoted 31 lines · Ori Kam
Hi Lihuisong,
Quoted 29 lines
-----Original Message-----
From: lihuisong (C) <[email protected]>
Sent: Wednesday, March 2, 2022 4:10 AM
Subject: Re: [PATCH 2/6] net/hns3: fix inconsistent enabled RSS behaviorQuoted 22 lines · Ferruh Yigit
Quoted 8 lines · Min Hu (Connor)
From: Huisong Li <[email protected]>
RSS will not be enabled if the
RTE_ETH_MQ_RX_RSS_FLAGisn't be set indev_configurephase. However, if this flag isn't set, RSS can be enabled through the ethdev ops andrte_flowAPI. This behavior is contrary to each
other.Quoted 4 lines
Fixes c37ca66f2b27 ("net/hns3: support RSS")Signed-off-by Huisong Li <[email protected]>Hi Huisong, Connor,
Let's get a little more feedback for this patch, cc'ed more people.
To enable RSS, multi queue mode should be set to
'RTE_ETH_MQ_RX_RSS_FLAG'.
Quoted 7 lines
Quoted 4 lines
Quoted 1 line
But I wonder if it is required to configure RSS via flow API,
I do not know the original purpose of adding the RSS configuration in flow API.
The purpose is simple, this allow to create RSS per rule and not a global one. For example create RSS that sends TCP to some queues while othe RSS will send UDP traffic to different queues.
I'm a little confused now. The "per rule" also seems to be a global configuration.
Example:
- start PMD with 0,1,2,3
- create TCP packets to 2,3 queues. At this moment, only 2,3 queues can be received for other types of packets. Because this rule is implemented by modifying the entry of the redirection table which is global for this device.
Quoted 23 lines
Quoted 4 lines
However, as far as I know, the hash algorithm can be configured via this API,
Quoted 8 lines
but not via ethdev ops API.
Quoted 1 line
and if other PMDs check this configuration for flow API?
Some PMDs already have similar check in RSS releated ops or
rte_flowAPI.For example, hinic, axbge, bnxt, cnxk, otx2, and ena.
Quoted 1 line
.
From my view point those are two different settings.
TheRTE_ETH_MQ_RX_RSS_FLAGis global per port whilerte_flowis per rule.I think, that if a PMD needs this flag, in order to enable it also for
rte_flowthen it should be documented in the release note of the PMD.
It is a valid use case that the default traffic will not have RSS and only rules created byrte_flowwill have the RSS, for matching traffc.Best,
Ori
Re: [PATCH 2/6] net/hns3: fix inconsistent enabled RSS behavior
Quoted 38 lines · lihuisong (C)
Hi, Ori,
Quoted 35 lines · Ori Kam
Hi Lihuisong,
Quoted 33 lines
-----Original Message-----
From: lihuisong (C) <[email protected]>
Sent: Wednesday, March 2, 2022 4:10 AM
Subject: Re: [PATCH 2/6] net/hns3: fix inconsistent enabled RSS behaviorQuoted 16 lines · Ferruh Yigit
Quoted 8 lines · Min Hu (Connor)
From: Huisong Li <[email protected]>
RSS will not be enabled if the
RTE_ETH_MQ_RX_RSS_FLAGisn't be set indev_configurephase. However, if this flag isn't set, RSS can be enabled through the ethdev ops andrte_flowAPI. This behavior is contrary to each
other.Quoted 4 lines
Fixes c37ca66f2b27 ("net/hns3: support RSS")Signed-off-by Huisong Li <[email protected]>Hi Huisong, Connor,
Quoted 7 lines
Let's get a little more feedback for this patch, cc'ed more people.
To enable RSS, multi queue mode should be set to
'RTE_ETH_MQ_RX_RSS_FLAG'.But I wonder if it is required to configure RSS via flow API,
I do not know the original purpose of adding the RSS configuration in flow API.
Quoted 8 lines
Quoted 3 lines
The purpose is simple, this allow to create RSS per rule and not a global one. For example create RSS that sends TCP to some queues while othe RSS will send UDP traffic to different queues.
I'm a little confused now. The "per rule" also seems to be a global configuration.
Example:
- start PMD with 0,1,2,3
- create TCP packets to 2,3 queues. At this moment, only 2,3 queues can be received for other types of packets. Because this rule is implemented by modifying the entry of the redirection table which is global for this device.
Hi, Ori and Stephen.
Can you help me clear up the confusion above? If some NICs behave like this, what should we do about it?
Quoted 23 lines
Quoted 23 lines
Quoted 4 lines
However, as far as I know, the hash algorithm can be configured via this API,
Quoted 8 lines
but not via ethdev ops API.
Quoted 1 line
and if other PMDs check this configuration for flow API?
Some PMDs already have similar check in RSS releated ops or
rte_flowAPI.For example, hinic, axbge, bnxt, cnxk, otx2, and ena.
Quoted 1 line
.
From my view point those are two different settings. The
RTE_ETH_MQ_RX_RSS_FLAGis global per port whilerte_flowis per rule.I think, that if a PMD needs this flag, in order to enable it also for
rte_flowthen it should be documented in the release note of the PMD.
It is a valid use case that the default traffic will not have RSS and only rules created byrte_flowwill have the RSS, for matching traffc.Best,
Ori
RE: [PATCH 2/6] net/hns3: fix inconsistent enabled RSS behavior
Hi Lihusiong,
Quoted 60 lines
-----Original Message-----
From: lihuisong (C) <[email protected]>
Sent: Wednesday, March 9, 2022 10:03 AM
Subject: Re: [PATCH 2/6] net/hns3: fix inconsistent enabled RSS behaviorQuoted 45 lines · lihuisong (C)
Hi, Ori,
Quoted 34 lines · Ori Kam
Hi Lihuisong,
Quoted 32 lines
-----Original Message-----
From: lihuisong (C) <[email protected]>
Sent: Wednesday, March 2, 2022 4:10 AM
Subject: Re: [PATCH 2/6] net/hns3: fix inconsistent enabled RSS behaviorQuoted 24 lines · Ferruh Yigit
Quoted 9 lines · Min Hu (Connor)
From: Huisong Li <[email protected]>
RSS will not be enabled if the
RTE_ETH_MQ_RX_RSS_FLAGisn't be set indev_configurephase. However, if this flag isn't set, RSS can be enabled
through the ethdev ops andrte_flowAPI. This behavior is contrary to each
other.Quoted 4 lines
Fixes c37ca66f2b27 ("net/hns3: support RSS")Signed-off-by Huisong Li <[email protected]>Hi Huisong, Connor,
Let's get a little more feedback for this patch, cc'ed more people.
To enable RSS, multi queue mode should be set to
'RTE_ETH_MQ_RX_RSS_FLAG'.But I wonder if it is required to configure RSS via flow API,
Quoted 8 lines
Quoted 3 lines
I do not know the original purpose of adding the RSS configuration in flow API.
The purpose is simple, this allow to create RSS per rule and not a global one.
For example create RSS that sends TCP to some queues while othe RSS will send
UDP traffic to different queues.Quoted 8 lines
I'm a little confused now. The "per rule" also seems to be a global configuration.
Example:
- start PMD with 0,1,2,3
- create TCP packets to 2,3 queues. At this moment, only 2,3 queues can be received for other types of packets.
Because this rule is implemented by modifying the entry of the redirection table which is global for this device.
Quoted 3 lines
Hi, Ori and Stephen.
Can you help me clear up the confusion above? If some NICs behave like this, what should we do about it?
I'm not sure I understand the issue, maybe it is releated to some HW/PMD limitation. In your example non TCP traffic will be routed to one of the 4 queues (0,1,2,3), While TCP traffic will only be routed to queues 2,3.
Now I can add new rule that matches on UDP packet and RSS to queue 0 and 3 in this case:
TCP packets will be routed to queues 0,3.
UDP packets will be routed to queues 2,3.
All the rest of the traffic will be routed to queues 0,1,2,3
And just to be clear if now I add a rule to match all packets in higher priority, with RSS to queues 1,2. Then all traffic will be routed to queues 1,2.
At least this is what is expected, from API point of view.
Best,
Ori
Quoted 27 lines
Quoted 27 lines
Quoted 27 lines
Quoted 5 lines
However, as far as I know, the hash algorithm can be configured via this
API,Quoted 9 lines
but not via ethdev ops API.
Quoted 1 line
and if other PMDs check this configuration for flow API?
Some PMDs already have similar check in RSS releated ops or
rte_flowAPI.For example, hinic, axbge, bnxt, cnxk, otx2, and ena.
Quoted 1 line
.
From my view point those are two different settings. The
RTE_ETH_MQ_RX_RSS_FLAGis global per port whilerte_flowis per rule.I think, that if a PMD needs this flag, in order to enable it also for
rte_flowthen
it should be documented in the release note of the PMD.
It is a valid use case that the default traffic will not have RSS and only rules created byrte_flowwill have the RSS, for matching traffc.Best,
Ori
Re: [PATCH 2/6] net/hns3: fix inconsistent enabled RSS behavior
Quoted 73 lines · Ori Kam
Hi Lihusiong,
Quoted 59 lines
-----Original Message-----
From: lihuisong (C) <[email protected]>
Sent: Wednesday, March 9, 2022 10:03 AM
Subject: Re: [PATCH 2/6] net/hns3: fix inconsistent enabled RSS behaviorQuoted 44 lines · lihuisong (C)
Hi, Ori,
Quoted 33 lines · Ori Kam
Hi Lihuisong,
Quoted 31 lines
-----Original Message-----
From: lihuisong (C) <[email protected]>
Sent: Wednesday, March 2, 2022 4:10 AM
Subject: Re: [PATCH 2/6] net/hns3: fix inconsistent enabled RSS behaviorQuoted 23 lines · Ferruh Yigit
Quoted 9 lines · Min Hu (Connor)
From: Huisong Li <[email protected]>
RSS will not be enabled if the
RTE_ETH_MQ_RX_RSS_FLAGisn't be set indev_configurephase. However, if this flag isn't set, RSS can be enabled
through the ethdev ops andrte_flowAPI. This behavior is contrary to each
other.Quoted 4 lines
Fixes c37ca66f2b27 ("net/hns3: support RSS")Signed-off-by Huisong Li <[email protected]>Hi Huisong, Connor,
Let's get a little more feedback for this patch, cc'ed more people.
To enable RSS, multi queue mode should be set to
'RTE_ETH_MQ_RX_RSS_FLAG'.But I wonder if it is required to configure RSS via flow API,
Quoted 8 lines
Quoted 3 lines
I do not know the original purpose of adding the RSS configuration in flow API.
The purpose is simple, this allow to create RSS per rule and not a global one.
For example create RSS that sends TCP to some queues while othe RSS will send
UDP traffic to different queues.Quoted 8 lines
I'm a little confused now. The "per rule" also seems to be a global configuration.
Example:
- start PMD with 0,1,2,3
- create TCP packets to 2,3 queues. At this moment, only 2,3 queues
can be received for other types of packets.
Because this rule is implemented by modifying the entry of the redirection table which is global for this device.Quoted 3 lines
Hi, Ori and Stephen.
Can you help me clear up the confusion above? If some NICs behave like this, what should we do about it?I'm not sure I understand the issue, maybe it is releated to some HW/PMD limitation. In your example non TCP traffic will be routed to one of the 4 queues (0,1,2,3), While TCP traffic will only be routed to queues 2,3.
Now I can add new rule that matches on UDP packet and RSS to queue 0 and 3 in this case:
TCP packets will be routed to queues 0,3.
UDP packets will be routed to queues 2,3.
All the rest of the traffic will be routed to queues 0,1,2,3
Quoted 7 lines
And just to be clear if now I add a rule to match all packets in higher priority, with RSS to queues 1,2. Then all traffic will be routed to queues 1,2.
At least this is what is expected, from API point of view.
Best,
Ori
Thank you for your answer. I understand it.
hns3 PMD cannot implement the above functions due to hardware limitation.
we may need add a check that specified RSS queues cannot be supported when specified packets types. And only the packet type is specified, which meets the requirements of rte_flow API. The check for the RTE_ETH_MQ_RX_RSS_FLAG flag in rte_flow is not correct.
Thanks, Ori and Stephen😁
But, I think, it is necessary for the '.rss_hash_update' and '.reta_update' APIs in eth_dev_ops to verify this flag. What do you think? @Thomas, @Ferruh, @Ori and @Stephen.
Quoted 27 lines
Quoted 27 lines
Quoted 27 lines
Quoted 27 lines
Quoted 5 lines
However, as far as I know, the hash algorithm can be configured via this
API,Quoted 9 lines
but not via ethdev ops API.
Quoted 1 line
and if other PMDs check this configuration for flow API?
Some PMDs already have similar check in RSS releated ops or
rte_flowAPI.For example, hinic, axbge, bnxt, cnxk, otx2, and ena.
Quoted 1 line
.
From my view point those are two different settings.
TheRTE_ETH_MQ_RX_RSS_FLAGis global per port whilerte_flowis per rule.I think, that if a PMD needs this flag, in order to enable it also for
rte_flowthen
it should be documented in the release note of the PMD.
It is a valid use case that the default traffic will not have RSS and only rules created byrte_flowwill have the RSS, for matching traffc.Best,
Ori
Re: [PATCH 2/6] net/hns3: fix inconsistent enabled RSS behavior
Hi, all,
Quoted 89 lines · lihuisong (C)
Quoted 73 lines · Ori Kam
Hi Lihusiong,
Quoted 59 lines
-----Original Message-----
From: lihuisong (C) <[email protected]>
Sent: Wednesday, March 9, 2022 10:03 AM
Subject: Re: [PATCH 2/6] net/hns3: fix inconsistent enabled RSS behaviorQuoted 44 lines · lihuisong (C)
Hi, Ori,
Quoted 33 lines · Ori Kam
Hi Lihuisong,
Quoted 31 lines
-----Original Message-----
From: lihuisong (C) <[email protected]>
Sent: Wednesday, March 2, 2022 4:10 AM
Subject: Re: [PATCH 2/6] net/hns3: fix inconsistent enabled RSS behaviorQuoted 23 lines · Ferruh Yigit
Quoted 9 lines · Min Hu (Connor)
From: Huisong Li <[email protected]>
RSS will not be enabled if the
RTE_ETH_MQ_RX_RSS_FLAGisn't be set indev_configurephase. However, if this flag isn't set, RSS can be enabled
through the ethdev ops andrte_flowAPI. This behavior is contrary to each
other.Quoted 4 lines
Fixes c37ca66f2b27 ("net/hns3: support RSS")Signed-off-by Huisong Li <[email protected]>Hi Huisong, Connor,
Let's get a little more feedback for this patch, cc'ed more people.
To enable RSS, multi queue mode should be set to
'RTE_ETH_MQ_RX_RSS_FLAG'.But I wonder if it is required to configure RSS via flow API,
Quoted 8 lines
Quoted 3 lines
I do not know the original purpose of adding the RSS configuration in flow API.
The purpose is simple, this allow to create RSS per rule and not a global one.
For example create RSS that sends TCP to some queues while othe RSS will send
UDP traffic to different queues.Quoted 8 lines
I'm a little confused now. The "per rule" also seems to be a global configuration.
Example:
- start PMD with 0,1,2,3
- create TCP packets to 2,3 queues. At this moment, only 2,3 queues can be received for other types of packets.
Because this rule is implemented by modifying the entry of the redirection table which is global for this device.Quoted 3 lines
Hi, Ori and Stephen.
Can you help me clear up the confusion above? If some NICs behave like this, what should we do about it?I'm not sure I understand the issue, maybe it is releated to some HW/PMD limitation. In your example non TCP traffic will be routed to one of the 4 queues (0,1,2,3), While TCP traffic will only be routed to queues 2,3.
Now I can add new rule that matches on UDP packet and RSS to queue 0 and 3 in this case:
TCP packets will be routed to queues 0,3.
UDP packets will be routed to queues 2,3.
All the rest of the traffic will be routed to queues 0,1,2,3Quoted 7 lines
And just to be clear if now I add a rule to match all packets in higher priority, with RSS to queues 1,2. Then all traffic will be routed to queues 1,2.
At least this is what is expected, from API point of view.
Best,
OriThank you for your answer. I understand it.
hns3 PMD cannot implement the above functions due to hardware limitation.
we may need add a check that specified RSS queues cannot be supported when specified packets types. And only the packet type is specified, which meets the requirements ofrte_flowAPI. The check for theRTE_ETH_MQ_RX_RSS_FLAGflag inrte_flowis not correct.
Thanks, Ori and Stephen😁
Quoted 3 lines
But, I think, it is necessary for the '.rss_hash_update' and '.reta_update' APIs in
eth_dev_opsto verify this flag. What do you think? @Thomas, @Ferruh, @Ori and @Stephen.
What's your take on it? I am looking forward to your reply. Thanks!
Quoted 28 lines
Quoted 25 lines
Quoted 25 lines
Quoted 25 lines
Quoted 25 lines
Quoted 5 lines
However, as far as I know, the hash algorithm can be configured via this
API,Quoted 9 lines
but not via ethdev ops API.
Quoted 1 line
and if other PMDs check this configuration for flow API?
Some PMDs already have similar check in RSS releated ops or
rte_flowAPI.For example, hinic, axbge, bnxt, cnxk, otx2, and ena.
Quoted 1 line
.
From my view point those are two different settings. The
RTE_ETH_MQ_RX_RSS_FLAGis global per port whilerte_flowis per rule.I think, that if a PMD needs this flag, in order to enable it also for
rte_flowthen
it should be documented in the release note of the PMD.
It is a valid use case that the default traffic will not have RSS and only rules created byrte_flowwill have the RSS, for matching traffc.Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Best,
Ori.
Re: [PATCH 2/6] net/hns3: fix inconsistent enabled RSS behavior
21/03/2022 08:14, lihuisong (C):
Quoted 80 lines
2022/3/10 16:08, lihuisong (C):
Quoted 79 lines
2022/3/9 17:55, Ori Kam:
Quoted 61 lines
From: lihuisong (C) <[email protected]>
Quoted 45 lines
2022/3/3 10:47, lihuisong (C):
Quoted 36 lines
2022/3/2 22:07, Ori Kam:
Quoted 30 lines
From: lihuisong (C) <[email protected]>
Quoted 21 lines
2022/3/1 0:42, Ferruh Yigit:
Quoted 20 lines · Min Hu (Connor)
Quoted 11 lines
From: Huisong Li <[email protected]>
RSS will not be enabled if the
RTE_ETH_MQ_RX_RSS_FLAGisn't be set indev_configurephase. However, if this flag isn't set, RSS can be enabled
through the ethdev ops andrte_flowAPI. This behavior is contrary to
each
other.Quoted 4 lines
Fixes c37ca66f2b27 ("net/hns3: support RSS")Signed-off-by Huisong Li <[email protected]>Hi Huisong, Connor,
Let's get a little more feedback for this patch, cc'ed more people.
Quoted 8 lines
Quoted 4 lines
To enable RSS, multi queue mode should be set to
'RTE_ETH_MQ_RX_RSS_FLAG'.But I wonder if it is required to configure RSS via flow API,
I do not know the original purpose of adding the RSS configuration in
flow API.Quoted 5 lines
The purpose is simple, this allow to create RSS per rule and not a global one.
For example create RSS that sends TCP to some queues while othe RSS will send
UDP traffic to different queues.Quoted 8 lines
I'm a little confused now. The "per rule" also seems to be a global configuration.
Example:
- start PMD with 0,1,2,3
- create TCP packets to 2,3 queues. At this moment, only 2,3 queues
can be received for other types of packets.
Because this rule is implemented by modifying the entry of the redirection table which is global for this device.Quoted 3 lines
Hi, Ori and Stephen.
Can you help me clear up the confusion above? If some NICs behave like this, what should we do about it?I'm not sure I understand the issue, maybe it is releated to some HW/PMD limitation.
In your example non TCP traffic will be routed to one of the 4 queues (0,1,2,3),
While TCP traffic will only be routed to queues 2,3.Now I can add new rule that matches on UDP packet and RSS to queue 0 and 3 in this case:
TCP packets will be routed to queues 0,3.
UDP packets will be routed to queues 2,3.
All the rest of the traffic will be routed to queues 0,1,2,3Quoted 8 lines
And just to be clear if now I add a rule to match all packets in higher priority,
with RSS to queues 1,2. Then all traffic will be routed to queues 1,2.At least this is what is expected, from API point of view.
Best,
OriThank you for your answer. I understand it.
hns3 PMD cannot implement the above functions due to hardware limitation. we may need add a check that specified RSS queues cannot be supported when specified packets types.
And only the packet type is specified, which meets the requirements ofrte_flowAPI.
The check for theRTE_ETH_MQ_RX_RSS_FLAGflag inrte_flowis not correct. Thanks, Ori and Stephen😁
Quoted 5 lines
Quoted 4 lines
But, I think, it is necessary for the '.rss_hash_update' and '.reta_update' APIs
ineth_dev_opsto verify this flag. What do you think? @Thomas, @Ferruh, @Ori and @Stephen.What's your take on it? I am looking forward to your reply. Thanks!
I am not sure why you want to check this flag.
I can imagine we configure the hash and the table before enabling RSS with the RTE_ETH_MQ_RX_RSS_FLAG flag.
Re: [PATCH 2/6] net/hns3: fix inconsistent enabled RSS behavior
Quoted 81 lines · Thomas Monjalon
21/03/2022 08:14, lihuisong (C):
Quoted 80 lines
2022/3/10 16:08, lihuisong (C):
Quoted 79 lines
2022/3/9 17:55, Ori Kam:
Quoted 61 lines
From: lihuisong (C) <[email protected]>
Quoted 45 lines
2022/3/3 10:47, lihuisong (C):
Quoted 36 lines
2022/3/2 22:07, Ori Kam:
Quoted 30 lines
From: lihuisong (C) <[email protected]>
Quoted 21 lines
2022/3/1 0:42, Ferruh Yigit:
Quoted 20 lines · Min Hu (Connor)
Quoted 11 lines
From: Huisong Li <[email protected]>
RSS will not be enabled if the
RTE_ETH_MQ_RX_RSS_FLAGisn't be set indev_configurephase. However, if this flag isn't set, RSS can be enabled
through the ethdev ops andrte_flowAPI. This behavior is contrary to
each
other.Quoted 4 lines
Fixes c37ca66f2b27 ("net/hns3: support RSS")Signed-off-by Huisong Li <[email protected]>Hi Huisong, Connor,
Let's get a little more feedback for this patch, cc'ed more people.
Quoted 8 lines
Quoted 4 lines
To enable RSS, multi queue mode should be set to
'RTE_ETH_MQ_RX_RSS_FLAG'.But I wonder if it is required to configure RSS via flow API,
I do not know the original purpose of adding the RSS configuration in
flow API.Quoted 5 lines
The purpose is simple, this allow to create RSS per rule and not a global one.
For example create RSS that sends TCP to some queues while othe RSS will send
UDP traffic to different queues.Quoted 8 lines
I'm a little confused now. The "per rule" also seems to be a global configuration.
Example:
- start PMD with 0,1,2,3
- create TCP packets to 2,3 queues. At this moment, only 2,3 queues
can be received for other types of packets.
Because this rule is implemented by modifying the entry of the redirection table which is global for this device.Quoted 3 lines
Hi, Ori and Stephen.
Can you help me clear up the confusion above? If some NICs behave like this, what should we do about it?I'm not sure I understand the issue, maybe it is releated to some HW/PMD limitation.
In your example non TCP traffic will be routed to one of the 4 queues (0,1,2,3),
While TCP traffic will only be routed to queues 2,3.Now I can add new rule that matches on UDP packet and RSS to queue 0 and 3 in this case:
TCP packets will be routed to queues 0,3.
UDP packets will be routed to queues 2,3.
All the rest of the traffic will be routed to queues 0,1,2,3Quoted 8 lines
And just to be clear if now I add a rule to match all packets in higher priority,
with RSS to queues 1,2. Then all traffic will be routed to queues 1,2.At least this is what is expected, from API point of view.
Best,
OriThank you for your answer. I understand it.
hns3 PMD cannot implement the above functions due to hardware limitation. we may need add a check that specified RSS queues cannot be supported when specified packets types.
And only the packet type is specified, which meets the requirements ofrte_flowAPI.
The check for theRTE_ETH_MQ_RX_RSS_FLAGflag inrte_flowis not correct. Thanks, Ori and Stephen😁
Quoted 6 lines
Quoted 5 lines
Quoted 4 lines
But, I think, it is necessary for the '.rss_hash_update' and '.reta_update' APIs
ineth_dev_opsto verify this flag. What do you think? @Thomas, @Ferruh, @Ori and @Stephen.What's your take on it? I am looking forward to your reply. Thanks!
I am not sure why you want to check this flag.
I want to make sure that the behavior that PMD configured RSS is consistent across different interfaces. The RTE_ETH_MQ_RX_RSS_FLAG flag is a switch to enable RSS hash. If the switch isn't open, some PMD do not configure RSS function. I think the consistency is necessary. If not set RSS muti-queue mode, it is unnecessary to configure RSS.
Quoted 2 lines
I can imagine we configure the hash and the table before enabling RSS with the
RTE_ETH_MQ_RX_RSS_FLAGflag.
The flag is derived from dev_configure() which also configures hash and key. I don't think it makes sense to configure hash and reta before calling dev_configure. Because they'll be updated. This is similar to configuring mtu.
Quoted 3 lines
.
Re: [PATCH 2/6] net/hns3: fix inconsistent enabled RSS behavior
23/03/2022 04:05, lihuisong (C):
Quoted 96 lines · Thomas Monjalon
Quoted 81 lines
21/03/2022 08:14, lihuisong (C):
Quoted 80 lines
2022/3/10 16:08, lihuisong (C):
Quoted 79 lines
2022/3/9 17:55, Ori Kam:
Quoted 61 lines
From: lihuisong (C) <[email protected]>
Quoted 45 lines
2022/3/3 10:47, lihuisong (C):
Quoted 36 lines
2022/3/2 22:07, Ori Kam:
Quoted 30 lines
From: lihuisong (C) <[email protected]>
Quoted 21 lines
2022/3/1 0:42, Ferruh Yigit:
Quoted 20 lines · Min Hu (Connor)
Quoted 11 lines
From: Huisong Li <[email protected]>
RSS will not be enabled if the
RTE_ETH_MQ_RX_RSS_FLAGisn't be set indev_configurephase. However, if this flag isn't set, RSS can be enabled
through the ethdev ops andrte_flowAPI. This behavior is contrary to
each
other.Quoted 4 lines
Fixes c37ca66f2b27 ("net/hns3: support RSS")Signed-off-by Huisong Li <[email protected]>Hi Huisong, Connor,
Let's get a little more feedback for this patch, cc'ed more people.
Quoted 8 lines
Quoted 4 lines
To enable RSS, multi queue mode should be set to
'RTE_ETH_MQ_RX_RSS_FLAG'.But I wonder if it is required to configure RSS via flow API,
I do not know the original purpose of adding the RSS configuration in
flow API.Quoted 5 lines
The purpose is simple, this allow to create RSS per rule and not a global one.
For example create RSS that sends TCP to some queues while othe RSS will send
UDP traffic to different queues.Quoted 8 lines
I'm a little confused now. The "per rule" also seems to be a global configuration.
Example:
- start PMD with 0,1,2,3
- create TCP packets to 2,3 queues. At this moment, only 2,3 queues
can be received for other types of packets.
Because this rule is implemented by modifying the entry of the redirection table which is global for this device.Quoted 3 lines
Hi, Ori and Stephen.
Can you help me clear up the confusion above? If some NICs behave like this, what should we do about it?I'm not sure I understand the issue, maybe it is releated to some HW/PMD limitation.
In your example non TCP traffic will be routed to one of the 4 queues (0,1,2,3),
While TCP traffic will only be routed to queues 2,3.Now I can add new rule that matches on UDP packet and RSS to queue 0 and 3 in this case:
TCP packets will be routed to queues 0,3.
UDP packets will be routed to queues 2,3.
All the rest of the traffic will be routed to queues 0,1,2,3Quoted 8 lines
And just to be clear if now I add a rule to match all packets in higher priority,
with RSS to queues 1,2. Then all traffic will be routed to queues 1,2.At least this is what is expected, from API point of view.
Best,
OriThank you for your answer. I understand it.
hns3 PMD cannot implement the above functions due to hardware limitation. we may need add a check that specified RSS queues cannot be supported when specified packets types.
And only the packet type is specified, which meets the requirements ofrte_flowAPI.
The check for theRTE_ETH_MQ_RX_RSS_FLAGflag inrte_flowis not correct. Thanks, Ori and Stephen😁Quoted 7 lines
Quoted 5 lines
Quoted 4 lines
But, I think, it is necessary for the '.rss_hash_update' and '.reta_update' APIs
ineth_dev_opsto verify this flag. What do you think? @Thomas, @Ferruh, @Ori and @Stephen.What's your take on it? I am looking forward to your reply. Thanks!
I am not sure why you want to check this flag.
I want to make sure that the behavior that PMD configured RSS is consistent across different interfaces. The
RTE_ETH_MQ_RX_RSS_FLAGflag is a switch to enable RSS hash. If the switch isn't open, some PMD do not configure RSS function. I think the consistency is necessary. If not set RSS muti-queue mode, it is unnecessary to configure RSS.
Quoted 7 lines
Quoted 2 lines
I can imagine we configure the hash and the table before enabling RSS with the
RTE_ETH_MQ_RX_RSS_FLAGflag.The flag is derived from
dev_configure()which also configures hash and key. I don't think it makes sense to configure hash and reta before callingdev_configure. Because they'll be updated. This is similar to configuring mtu.
OK I see your point.
So you would like to return an error in RSS functions if the flag RTE_ETH_MQ_RX_RSS_FLAG is not set? Should it be checked in ethdev library or PMDs?
Re: [PATCH 2/6] net/hns3: fix inconsistent enabled RSS behavior
Quoted 97 lines · Thomas Monjalon
23/03/2022 04:05, lihuisong (C):
Quoted 96 lines · Thomas Monjalon
Quoted 81 lines
21/03/2022 08:14, lihuisong (C):
Quoted 80 lines
2022/3/10 16:08, lihuisong (C):
Quoted 79 lines
2022/3/9 17:55, Ori Kam:
Quoted 61 lines
From: lihuisong (C) <[email protected]>
Quoted 45 lines
2022/3/3 10:47, lihuisong (C):
Quoted 36 lines
2022/3/2 22:07, Ori Kam:
Quoted 30 lines
From: lihuisong (C) <[email protected]>
Quoted 21 lines
2022/3/1 0:42, Ferruh Yigit:
Quoted 20 lines · Min Hu (Connor)
Quoted 11 lines
From: Huisong Li <[email protected]>
RSS will not be enabled if the
RTE_ETH_MQ_RX_RSS_FLAGisn't be set indev_configurephase. However, if this flag isn't set, RSS can be enabled
through the ethdev ops andrte_flowAPI. This behavior is contrary to
each
other.Quoted 4 lines
Fixes c37ca66f2b27 ("net/hns3: support RSS")Signed-off-by Huisong Li <[email protected]>Hi Huisong, Connor,
Let's get a little more feedback for this patch, cc'ed more people.
Quoted 8 lines
Quoted 4 lines
To enable RSS, multi queue mode should be set to
'RTE_ETH_MQ_RX_RSS_FLAG'.But I wonder if it is required to configure RSS via flow API,
I do not know the original purpose of adding the RSS configuration in
flow API.Quoted 5 lines
The purpose is simple, this allow to create RSS per rule and not a global one.
For example create RSS that sends TCP to some queues while othe RSS will send
UDP traffic to different queues.Quoted 8 lines
I'm a little confused now. The "per rule" also seems to be a global configuration.
Example:
- start PMD with 0,1,2,3
- create TCP packets to 2,3 queues. At this moment, only 2,3 queues
can be received for other types of packets.
Because this rule is implemented by modifying the entry of the redirection table which is global for this device.Quoted 3 lines
Hi, Ori and Stephen.
Can you help me clear up the confusion above? If some NICs behave like this, what should we do about it?I'm not sure I understand the issue, maybe it is releated to some HW/PMD limitation.
In your example non TCP traffic will be routed to one of the 4 queues (0,1,2,3),
While TCP traffic will only be routed to queues 2,3.Now I can add new rule that matches on UDP packet and RSS to queue 0 and 3 in this case:
TCP packets will be routed to queues 0,3.
UDP packets will be routed to queues 2,3.
All the rest of the traffic will be routed to queues 0,1,2,3Quoted 8 lines
And just to be clear if now I add a rule to match all packets in higher priority,
with RSS to queues 1,2. Then all traffic will be routed to queues 1,2.At least this is what is expected, from API point of view.
Best,
OriThank you for your answer. I understand it.
hns3 PMD cannot implement the above functions due to hardware limitation. we may need add a check that specified RSS queues cannot be supported when specified packets types.
And only the packet type is specified, which meets the requirements ofrte_flowAPI.
The check for theRTE_ETH_MQ_RX_RSS_FLAGflag inrte_flowis not correct. Thanks, Ori and Stephen😁Quoted 6 lines
Quoted 5 lines
Quoted 4 lines
But, I think, it is necessary for the '.rss_hash_update' and '.reta_update' APIs
ineth_dev_opsto verify this flag. What do you think? @Thomas, @Ferruh, @Ori and @Stephen.What's your take on it? I am looking forward to your reply. Thanks!
I am not sure why you want to check this flag.
I want to make sure that the behavior that PMD configured RSS is consistent across different interfaces. The
RTE_ETH_MQ_RX_RSS_FLAGflag is a switch to enable RSS hash. If the switch isn't open, some PMD do not configure RSS function. I think the consistency is necessary. If not set RSS muti-queue mode, it is unnecessary to configure RSS.Quoted 2 lines
I can imagine we configure the hash and the table before enabling RSS with the
RTE_ETH_MQ_RX_RSS_FLAGflag.
Quoted 7 lines
Quoted 4 lines
The flag is derived from
dev_configure()which also configures hash and key. I don't think it makes sense to configure hash and reta before callingdev_configure. Because they'll be updated. This is similar to configuring mtu.OK I see your point.
So you would like to return an error in RSS functions if the flagRTE_ETH_MQ_RX_RSS_FLAGis not set?
Yes
Quoted 1 line
Should it be checked in ethdev library or PMDs?
I think it's better to put it in the ethdev layer if we do it. Should we add this check in 'rss_hash_update' and 'reta_update' APIs?
Quoted 4 lines
.
Re: [PATCH 2/6] net/hns3: fix inconsistent enabled RSS behavior
23/03/2022 12:04, lihuisong (C):
Quoted 102 lines · Thomas Monjalon
Quoted 101 lines
23/03/2022 04:05, lihuisong (C):
Quoted 100 lines · Thomas Monjalon
Quoted 81 lines
21/03/2022 08:14, lihuisong (C):
Quoted 80 lines
2022/3/10 16:08, lihuisong (C):
Quoted 79 lines
2022/3/9 17:55, Ori Kam:
Quoted 61 lines
From: lihuisong (C) <[email protected]>
Quoted 45 lines
2022/3/3 10:47, lihuisong (C):
Quoted 36 lines
2022/3/2 22:07, Ori Kam:
Quoted 30 lines
From: lihuisong (C) <[email protected]>
Quoted 21 lines
2022/3/1 0:42, Ferruh Yigit:
Quoted 20 lines · Min Hu (Connor)
Quoted 15 lines
From: Huisong Li <[email protected]>
RSS will not be enabled if the RTE_ETH_MQ_RX_RSS_FLAG isn't be
set in
dev_configure phase. However, if this flag isn't set, RSS can be
enabled
through the ethdev ops and rte_flow API. This behavior is
contrary to
each
other.Fixes: c37ca66f2b27 ("net/hns3: support RSS")
Cc: [email protected]Signed-off-by: Huisong Li <[email protected]>
Hi Huisong, Connor,
Let's get a little more feedback for this patch, cc'ed more people.
Quoted 8 lines
Quoted 4 lines
To enable RSS, multi queue mode should be set to
'RTE_ETH_MQ_RX_RSS_FLAG'.But I wonder if it is required to configure RSS via flow API,
I do not know the original purpose of adding the RSS configuration in
flow API.Quoted 5 lines
The purpose is simple, this allow to create RSS per rule and not a global one.
For example create RSS that sends TCP to some queues while othe RSS will send
UDP traffic to different queues.Quoted 8 lines
I'm a little confused now. The "per rule" also seems to be a global configuration.
Example:
- start PMD with 0,1,2,3
- create TCP packets to 2,3 queues. At this moment, only 2,3 queues
can be received for other types of packets.
Because this rule is implemented by modifying the entry of the redirection table which is global for this device.Quoted 3 lines
Hi, Ori and Stephen.
Can you help me clear up the confusion above? If some NICs behave like this, what should we do about it?I'm not sure I understand the issue, maybe it is releated to some HW/PMD limitation.
In your example non TCP traffic will be routed to one of the 4 queues (0,1,2,3),
While TCP traffic will only be routed to queues 2,3.Now I can add new rule that matches on UDP packet and RSS to queue 0 and 3 in this case:
TCP packets will be routed to queues 0,3.
UDP packets will be routed to queues 2,3.
All the rest of the traffic will be routed to queues 0,1,2,3Quoted 8 lines
And just to be clear if now I add a rule to match all packets in higher priority,
with RSS to queues 1,2. Then all traffic will be routed to queues 1,2.At least this is what is expected, from API point of view.
Best,
OriThank you for your answer. I understand it.
hns3 PMD cannot implement the above functions due to hardware limitation. we may need add a check that specified RSS queues cannot be supported when specified packets types.
And only the packet type is specified, which meets the requirements ofrte_flowAPI.
The check for theRTE_ETH_MQ_RX_RSS_FLAGflag inrte_flowis not correct. Thanks, Ori and Stephen😁Quoted 6 lines
Quoted 5 lines
Quoted 4 lines
But, I think, it is necessary for the '.rss_hash_update' and '.reta_update' APIs
ineth_dev_opsto verify this flag. What do you think? @Thomas, @Ferruh, @Ori and @Stephen.What's your take on it? I am looking forward to your reply. Thanks!
I am not sure why you want to check this flag.
I want to make sure that the behavior that PMD configured RSS is consistent across different interfaces. The
RTE_ETH_MQ_RX_RSS_FLAGflag is a switch to enable RSS hash. If the switch isn't open, some PMD do not configure RSS function. I think the consistency is necessary. If not set RSS muti-queue mode, it is unnecessary to configure RSS.Quoted 2 lines
I can imagine we configure the hash and the table before enabling RSS with the
RTE_ETH_MQ_RX_RSS_FLAGflag.The flag is derived from
dev_configure()which also configures hash and key. I don't think it makes sense to configure hash and reta before callingdev_configure. Because they'll be updated. This is similar to configuring mtu.
Quoted 7 lines
Quoted 3 lines
OK I see your point.
So you would like to return an error in RSS functions if the flagRTE_ETH_MQ_RX_RSS_FLAGis not set?Yes
Quoted 1 line
Should it be checked in ethdev library or PMDs?
I think it's better to put it in the ethdev layer if we do it. Should we add this check in '
rss_hash_update' and 'reta_update' APIs?
I'm OK with adding the check in ethdev.
Re: [PATCH 2/6] net/hns3: fix inconsistent enabled RSS behavior
Quoted 107 lines · Thomas Monjalon
23/03/2022 12:04, lihuisong (C):
Quoted 105 lines · Thomas Monjalon
Quoted 104 lines
23/03/2022 04:05, lihuisong (C):
Quoted 94 lines · Thomas Monjalon
Quoted 81 lines
21/03/2022 08:14, lihuisong (C):
Quoted 80 lines
2022/3/10 16:08, lihuisong (C):
Quoted 79 lines
2022/3/9 17:55, Ori Kam:
Quoted 61 lines
From: lihuisong (C) <[email protected]>
Quoted 45 lines
2022/3/3 10:47, lihuisong (C):
Quoted 36 lines
2022/3/2 22:07, Ori Kam:
Quoted 30 lines
From: lihuisong (C) <[email protected]>
Quoted 21 lines
2022/3/1 0:42, Ferruh Yigit:
Quoted 20 lines · Min Hu (Connor)
From: Huisong Li <[email protected]>
RSS will not be enabled if the RTE_ETH_MQ_RX_RSS_FLAG isn't be
set in
dev_configure phase. However, if this flag isn't set, RSS can be
enabled
through the ethdev ops and rte_flow API. This behavior is
contrary to
each
other.Fixes: c37ca66f2b27 ("net/hns3: support RSS")
Cc: [email protected]Signed-off-by: Huisong Li <[email protected]>
Hi Huisong, Connor,Let's get a little more feedback for this patch, cc'ed more people.
Quoted 8 lines
Quoted 4 lines
To enable RSS, multi queue mode should be set to
'RTE_ETH_MQ_RX_RSS_FLAG'.But I wonder if it is required to configure RSS via flow API,
I do not know the original purpose of adding the RSS configuration in
flow API.Quoted 5 lines
The purpose is simple, this allow to create RSS per rule and not a global one.
For example create RSS that sends TCP to some queues while othe RSS will send
UDP traffic to different queues.Quoted 8 lines
I'm a little confused now. The "per rule" also seems to be a global configuration.
Example:
- start PMD with 0,1,2,3
- create TCP packets to 2,3 queues. At this moment, only 2,3 queues
can be received for other types of packets.
Because this rule is implemented by modifying the entry of the redirection table which is global for this device.Quoted 3 lines
Hi, Ori and Stephen.
Can you help me clear up the confusion above? If some NICs behave like this, what should we do about it?I'm not sure I understand the issue, maybe it is releated to some HW/PMD limitation.
In your example non TCP traffic will be routed to one of the 4 queues (0,1,2,3),
While TCP traffic will only be routed to queues 2,3.Now I can add new rule that matches on UDP packet and RSS to queue 0 and 3 in this case:
TCP packets will be routed to queues 0,3.
UDP packets will be routed to queues 2,3.
All the rest of the traffic will be routed to queues 0,1,2,3Quoted 8 lines
And just to be clear if now I add a rule to match all packets in higher priority,
with RSS to queues 1,2. Then all traffic will be routed to queues 1,2.At least this is what is expected, from API point of view.
Best,
OriThank you for your answer. I understand it.
hns3 PMD cannot implement the above functions due to hardware limitation. we may need add a check that specified RSS queues cannot be supported when specified packets types.
And only the packet type is specified, which meets the requirements ofrte_flowAPI.
The check for theRTE_ETH_MQ_RX_RSS_FLAGflag inrte_flowis not correct. Thanks, Ori and Stephen😁Quoted 6 lines
Quoted 5 lines
Quoted 4 lines
But, I think, it is necessary for the '.rss_hash_update' and '.reta_update' APIs
ineth_dev_opsto verify this flag. What do you think? @Thomas, @Ferruh, @Ori and @Stephen.What's your take on it? I am looking forward to your reply. Thanks!
I am not sure why you want to check this flag.
I want to make sure that the behavior that PMD configured RSS is consistent across different interfaces. The
RTE_ETH_MQ_RX_RSS_FLAGflag is a switch to enable RSS hash. If the switch isn't open, some PMD do not configure RSS function. I think the consistency is necessary. If not set RSS muti-queue mode, it is unnecessary to configure RSS.Quoted 6 lines
Quoted 2 lines
I can imagine we configure the hash and the table before enabling RSS with the
RTE_ETH_MQ_RX_RSS_FLAGflag.The flag is derived from
dev_configure()which also configures hash and key. I don't think it makes sense to configure hash and reta before callingdev_configure. Because they'll be updated. This is similar to configuring mtu.OK I see your point.
So you would like to return an error in RSS functions if the flagRTE_ETH_MQ_RX_RSS_FLAGis not set?
Quoted 6 lines
Quoted 4 lines
Yes
Quoted 1 line
Should it be checked in ethdev library or PMDs?
I think it's better to put it in the ethdev layer if we do it. Should we add this check in '
rss_hash_update' and 'reta_update' APIs?I'm OK with adding the check in ethdev.
+1
Apologies for getting late to this thread.
Re: [PATCH 2/6] net/hns3: fix inconsistent enabled RSS behavior
Quoted 107 lines · Ajit Khaparde
Quoted 106 lines · Thomas Monjalon
23/03/2022 12:04, lihuisong (C):
Quoted 105 lines · Thomas Monjalon
Quoted 104 lines
23/03/2022 04:05, lihuisong (C):
Quoted 94 lines · Thomas Monjalon
Quoted 81 lines
21/03/2022 08:14, lihuisong (C):
Quoted 80 lines
2022/3/10 16:08, lihuisong (C):
Quoted 79 lines
2022/3/9 17:55, Ori Kam:
Quoted 61 lines
From: lihuisong (C) <[email protected]>
Quoted 45 lines
2022/3/3 10:47, lihuisong (C):
Quoted 36 lines
2022/3/2 22:07, Ori Kam:
Quoted 30 lines
From: lihuisong (C) <[email protected]>
Quoted 29 lines
2022/3/1 0:42, Ferruh Yigit:
On 2/28/2022 3:21 AM, Min Hu (Connor) wrote:
From: Huisong Li <[email protected]>RSS will not be enabled if the RTE_ETH_MQ_RX_RSS_FLAG isn't be
set in
dev_configure phase. However, if this flag isn't set, RSS can be
enabled
through the ethdev ops and rte_flow API. This behavior is
contrary to
each
other.Fixes: c37ca66f2b27 ("net/hns3: support RSS")
Cc: [email protected]Signed-off-by: Huisong Li <[email protected]>
Hi Huisong, Connor,Let's get a little more feedback for this patch, cc'ed more people.
To enable RSS, multi queue mode should be set to
'RTE_ETH_MQ_RX_RSS_FLAG'.But I wonder if it is required to configure RSS via flow API,
I do not know the original purpose of adding the RSS
configuration in
flow API.Quoted 5 lines
The purpose is simple, this allow to create RSS per rule and not a global one.
For example create RSS that sends TCP to some queues while othe RSS will send
UDP traffic to different queues.Quoted 8 lines
I'm a little confused now. The "per rule" also seems to be a global configuration.
Example:
- start PMD with 0,1,2,3
- create TCP packets to 2,3 queues. At this moment, only 2,3 queues
can be received for other types of packets.
Because this rule is implemented by modifying the entry of the redirection table which is global for this device.Quoted 3 lines
Hi, Ori and Stephen.
Can you help me clear up the confusion above? If some NICs behave like this, what should we do about it?I'm not sure I understand the issue, maybe it is releated to some HW/PMD limitation.
In your example non TCP traffic will be routed to one of the 4 queues (0,1,2,3),
While TCP traffic will only be routed to queues 2,3.Now I can add new rule that matches on UDP packet and RSS to queue 0 and 3 in this case:
TCP packets will be routed to queues 0,3.
UDP packets will be routed to queues 2,3.
All the rest of the traffic will be routed to queues 0,1,2,3Quoted 8 lines
And just to be clear if now I add a rule to match all packets in higher priority,
with RSS to queues 1,2. Then all traffic will be routed to queues 1,2.At least this is what is expected, from API point of view.
Best,
OriThank you for your answer. I understand it.
hns3 PMD cannot implement the above functions due to hardware limitation. we may need add a check that specified RSS queues cannot be supported when specified packets types.
And only the packet type is specified, which meets the requirements ofrte_flowAPI.
The check for theRTE_ETH_MQ_RX_RSS_FLAGflag inrte_flowis not correct. Thanks, Ori and Stephen😁Quoted 6 lines
Quoted 5 lines
Quoted 4 lines
But, I think, it is necessary for the '.rss_hash_update' and '.reta_update' APIs
ineth_dev_opsto verify this flag. What do you think? @Thomas, @Ferruh, @Ori and @Stephen.What's your take on it? I am looking forward to your reply. Thanks!
I am not sure why you want to check this flag.
I want to make sure that the behavior that PMD configured RSS is consistent across different interfaces. The
RTE_ETH_MQ_RX_RSS_FLAGflag is a switch to enable RSS hash. If the switch isn't open, some PMD do not configure RSS function. I think the consistency is necessary. If not set RSS muti-queue mode, it is unnecessary to configure RSS.Quoted 6 lines
Quoted 2 lines
I can imagine we configure the hash and the table before enabling RSS with the
RTE_ETH_MQ_RX_RSS_FLAGflag.The flag is derived from
dev_configure()which also configures hash and key. I don't think it makes sense to configure hash and reta before callingdev_configure. Because they'll be updated. This is similar to configuring mtu.OK I see your point.
So you would like to return an error in RSS functions if the flagRTE_ETH_MQ_RX_RSS_FLAGis not set?
Quoted 8 lines
Quoted 5 lines
Quoted 4 lines
Yes
Quoted 1 line
Should it be checked in ethdev library or PMDs?
I think it's better to put it in the ethdev layer if we do it. Should we add this check in '
rss_hash_update' and 'reta_update' APIs?I'm OK with adding the check in ethdev.
+1
Apologies for getting late to this thread.
Thanks. I'll fix it.
Re: [PATCH 2/6] net/hns3: fix inconsistent enabled RSS behavior
In reply to Ori KamQuoted 66 lines · Ori Kam
Hi Lihusiong,
Quoted 60 lines
-----Original Message-----
From: lihuisong (C) <[email protected]>
Sent: Wednesday, March 9, 2022 10:03 AM
Subject: Re: [PATCH 2/6] net/hns3: fix inconsistent enabled RSS behaviorQuoted 45 lines · lihuisong (C)
Hi, Ori,
Quoted 34 lines · Ori Kam
Hi Lihuisong,
Quoted 32 lines
-----Original Message-----
From: lihuisong (C) <[email protected]>
Sent: Wednesday, March 2, 2022 4:10 AM
Subject: Re: [PATCH 2/6] net/hns3: fix inconsistent enabled RSS behaviorQuoted 24 lines · Ferruh Yigit
Quoted 9 lines · Min Hu (Connor)
From: Huisong Li <[email protected]>
RSS will not be enabled if the
RTE_ETH_MQ_RX_RSS_FLAGisn't be set indev_configurephase. However, if this flag isn't set, RSS can be enabled
through the ethdev ops andrte_flowAPI. This behavior is contrary to each
other.Quoted 4 lines
Fixes c37ca66f2b27 ("net/hns3: support RSS")Signed-off-by Huisong Li <[email protected]>Hi Huisong, Connor,
Let's get a little more feedback for this patch, cc'ed more people.
To enable RSS, multi queue mode should be set to
'RTE_ETH_MQ_RX_RSS_FLAG'.But I wonder if it is required to configure RSS via flow API,
Quoted 8 lines
Quoted 3 lines
I do not know the original purpose of adding the RSS configuration in flow API.
The purpose is simple, this allow to create RSS per rule and not a global one.
For example create RSS that sends TCP to some queues while othe RSS will send
UDP traffic to different queues.Quoted 8 lines
I'm a little confused now. The "per rule" also seems to be a global configuration.
Example:
- start PMD with 0,1,2,3
- create TCP packets to 2,3 queues. At this moment, only 2,3 queues
can be received for other types of packets.
Because this rule is implemented by modifying the entry of the redirection table which is global for this device.Quoted 3 lines
Hi, Ori and Stephen.
Can you help me clear up the confusion above? If some NICs behave like this, what should we do about it?
Quoted 9 lines
I'm not sure I understand the issue, maybe it is releated to some HW/PMD limitation. In your example non TCP traffic will be routed to one of the 4 queues (0,1,2,3), While TCP traffic will only be routed to queues 2,3.
Now I can add new rule that matches on UDP packet and RSS to queue 0 and 3 in this case:
TCP packets will be routed to queues 0,3.
UDP packets will be routed to queues 2,3.
All the rest of the traffic will be routed to queues 0,1,2,3
Hi Ori,
How RETA is managed for per flow RSS configuration? And is there a limit on how many per flow RSS rule can be created?
Quoted 35 lines
And just to be clear if now I add a rule to match all packets in higher priority, with RSS to queues 1,2. Then all traffic will be routed to queues 1,2.
At least this is what is expected, from API point of view.
Best,
OriQuoted 27 lines
Quoted 27 lines
Quoted 27 lines
Quoted 5 lines
However, as far as I know, the hash algorithm can be configured via this
API,Quoted 9 lines
but not via ethdev ops API.
Quoted 1 line
and if other PMDs check this configuration for flow API?
Some PMDs already have similar check in RSS releated ops or
rte_flowAPI.For example, hinic, axbge, bnxt, cnxk, otx2, and ena.
Quoted 1 line
.
From my view point those are two different settings.
TheRTE_ETH_MQ_RX_RSS_FLAGis global per port whilerte_flowis per rule.I think, that if a PMD needs this flag, in order to enable it also for
rte_flowthen
it should be documented in the release note of the PMD.
It is a valid use case that the default traffic will not have RSS and only rules created byrte_flowwill have the RSS, for matching traffc.Best,
Ori
PATCH 3/6 net/hns3: remove unnecessary RSS switch
In reply to Min Hu (Connor)From: Huisong Li <[email protected]>
Whether the RSS is enabled depends on RTE_ETH_MQ_RX_RSS_FLAG and packet tuple are enabled. So the RSS switch is unnecessary.
--- drivers/net/hns3/hns3_ethdev.c | 2 -- drivers/net/hns3/hns3_ethdev.h | 1 - drivers/net/hns3/hns3_ethdev_vf.c | 2 -- drivers/net/hns3/hns3_flow.c | 1 - drivers/net/hns3/hns3_rss.c | 3 --- 5 files changed, 9 deletions(-)
drivers/net/hns3/hns3_ethdev.c +0 -2
@@ -2019,7 +2019,6 @@ hns3_dev_configure(struct rte_eth_dev *dev)if ((uint32_t )mq_mode &RTE_ETH_MQ_RX_RSS_FLAG ) { conf->rxmode.offloads |=RTE_ETH_RX_OFFLOAD_RSS_HASH ; rss_conf = conf->rx_adv_conf.rss_conf; - hw->rss_dis_flag = false; ret =hns3_dev_rss_hash_update (dev, &rss_conf);if (ret) goto cfg_err;
@@ -2825,7 +2824,6 @@ hns3_get_board_configuration(struct hns3_hw *hw) hw->mac.media_type = cfg.media_type; hw->rss_size_max = cfg.rss_size_max; - hw->rss_dis_flag = false;memcpy (hw->mac.mac_addr, cfg.mac_addr,RTE_ETHER_ADDR_LEN ); hw->mac.phy_addr = cfg.phy_addr; hw->dcb_info.num_pg =1 ;
drivers/net/hns3/hns3_ethdev.h +0 -1
@@ -520,7 +520,6 @@ struct hns3_hw {/* The configuration info of RSS */ struct hns3_rss_conf rss_info; -bool rss_dis_flag;/* disable rss flag. true: disable, false: enable */ uint16_t rss_ind_tbl_size;uint16_t rss_key_size;
drivers/net/hns3/hns3_ethdev_vf.c +0 -2
@@ -495,7 +495,6 @@ hns3vf_dev_configure(struct rte_eth_dev *dev)/* When RSS is not configured, redirect the packet queue 0 */ if ((uint32_t )mq_mode &RTE_ETH_MQ_RX_RSS_FLAG ) { conf->rxmode.offloads |=RTE_ETH_RX_OFFLOAD_RSS_HASH ; - hw->rss_dis_flag = false; rss_conf = conf->rx_adv_conf.rss_conf; ret =hns3_dev_rss_hash_update (dev, &rss_conf);if (ret)
@@ -997,7 +996,6 @@ hns3vf_get_configuration(struct hns3_hw *hw)int ret; hw->mac.media_type =HNS3_MEDIA_TYPE_NONE ; - hw->rss_dis_flag = false;/* Get device capability */ ret =hns3vf_get_capability (hw);
drivers/net/hns3/hns3_flow.c +0 -1
@@ -1458,7 +1458,6 @@ hns3_disable_rss(struct hns3_hw *hw)/* Disable RSS */ hw->rss_info.conf.types =0 ; - hw->rss_dis_flag = true;return 0 ; }
drivers/net/hns3/hns3_rss.c +0 -3
@@ -414,9 +414,6 @@ hns3_dev_rss_hash_update(struct rte_eth_dev *dev,return -EOPNOTSUPP ; } -if (hw->rss_dis_flag) -return -EINVAL ; -rte_spinlock_lock (&hw->lock); ret =hns3_set_rss_tuple_by_rss_hf (hw, tuple, rss_hf);if (ret)
Signature · 1 line
2.33.0
PATCH 4/6 net/hns3: fix the time waiting for PF reset completion
In reply to Min Hu (Connor)From: Huisong Li <[email protected]>
On the case that PF and VF need to be reset, after the hardware reset is complete, VF needs wait for 1 second to restore the configuration so that VF does not fail to recover because PF reset isn't complete. But the estimated time is not sufficient. This patch fixes it to 5 seconds.
--- drivers/net/hns3/hns3_ethdev_vf.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
drivers/net/hns3/hns3_ethdev_vf.c +5 -2
@@ -1875,6 +1875,7 @@ hns3vf_is_reset_pending(struct hns3_adapter *hns)static int hns3vf_wait_hardware_ready (struct hns3_adapter *hns) { +#define HNS3_WAIT_PF_RESET_READY_TIME 5struct hns3_hw *hw = &hns->hw;struct hns3_wait_data *wait_data = hw->reset.wait_data;struct timeval tv;
@@ -1895,12 +1896,14 @@ hns3vf_wait_hardware_ready(struct hns3_adapter *hns)return 0 ; wait_data->check_completion =NULL ; - wait_data->interval =1 *MSEC_PER_SEC *USEC_PER_MSEC ; + wait_data->interval = +HNS3_WAIT_PF_RESET_READY_TIME *MSEC_PER_SEC *USEC_PER_MSEC ; wait_data->count =1 ; wait_data->result =HNS3_WAIT_REQUEST ;rte_eal_alarm_set (wait_data->interval, hns3_wait_callback, wait_data); -hns3_warn (hw,"hardware is ready, delay 1 sec for PF reset complete" ); +hns3_warn (hw,"hardware is ready, delay %d sec for PF reset complete" , +HNS3_WAIT_PF_RESET_READY_TIME );return -EAGAIN ; }else if (wait_data->result ==HNS3_WAIT_TIMEOUT ) {hns3_clock_gettime (&tv);
Signature · 1 line
2.33.0
Re: [PATCH 4/6] net/hns3: fix the time waiting for PF reset completion
drivers/net/hns3/hns3_ethdev_vf.c hns3vf_wait_hardware_ready(struct hns3_adapter *hns) · line 1900
Quoted 7 lines · Min Hu (Connor)
drivers/net/hns3/hns3_ethdev_vf.c +2
-1@@ -1895,12 +1896,14 @@ hns3vf_wait_hardware_ready(struct hns3_adapter *hns)return 0 ; wait_data->check_completion =NULL ; - wait_data->interval =1 *MSEC_PER_SEC *USEC_PER_MSEC ; + wait_data->interval = +HNS3_WAIT_PF_RESET_READY_TIME *MSEC_PER_SEC *USEC_PER_MSEC ;
Can you please fix the syntax?
I guess all can fit into single line...
Re: [PATCH 4/6] net/hns3: fix the time waiting for PF reset completion
Hi, Ferruh,
Quoted 11 lines · Ferruh Yigit
drivers/net/hns3/hns3_ethdev_vf.c hns3vf_wait_hardware_ready(struct hns3_adapter · line 1900
Quoted 7 lines · Min Hu (Connor)
drivers/net/hns3/hns3_ethdev_vf.c +2
-1@@ -1895,12 +1896,14 @@ hns3vf_wait_hardware_ready(struct hns3_adapter *hns) return 0; wait_data->check_completion = NULL; - wait_data->interval = 1 * MSEC_PER_SEC * USEC_PER_MSEC; + wait_data->interval = + HNS3_WAIT_PF_RESET_READY_TIME * MSEC_PER_SEC * USEC_PER_MSEC;Can you please fix the syntax?
I guess all can fit into single line...
If not so, the code in single line will exceed 80 characters.
Quoted 1 line
.
Re: [PATCH 4/6] net/hns3: fix the time waiting for PF reset completion
Quoted 13 lines · Min Hu (Connor)
Hi, Ferruh,
Quoted 10 lines · Ferruh Yigit
drivers/net/hns3/hns3_ethdev_vf.c hns3vf_wait_hardware_ready(struct hns3_adapter *hns) · line 1899
Quoted 6 lines · Min Hu (Connor)
drivers/net/hns3/hns3_ethdev_vf.c +2
-1@@ -1895,12 +1896,14 @@ hns3vf_wait_hardware_ready(struct hns3_adapter *hns) return 0; wait_data->check_completion = NULL; - wait_data->interval = 1 * MSEC_PER_SEC * USEC_PER_MSEC; + wait_data->interval = + HNS3_WAIT_PF_RESET_READY_TIME * MSEC_PER_SEC * USEC_PER_MSEC;Can you please fix the syntax?
I guess all can fit into single line...
Quoted 2 lines
If not so, the code in single line will exceed 80 characters.
Right, it doesn't fit into single line, still it can be formatted better.
wait_data->interval = HNS3_WAIT_PF_RESET_READY_TIME *
MSEC_PER_SEC * USEC_PER_MSEC;
PATCH v2 1/1 net/hns3: fix the time waiting for PF reset completion
In reply to Min Hu (Connor)From: Huisong Li <[email protected]>
On the case that PF and VF need to be reset, after the hardware reset is complete, VF needs wait for 1 second to restore the configuration so that VF does not fail to recover because PF reset isn't complete. But the estimated time is not sufficient. This patch fixes it to 5 seconds.
---
v2:
* fix syntax.
--- drivers/net/hns3/hns3_ethdev_vf.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
drivers/net/hns3/hns3_ethdev_vf.c +5 -2
@@ -1875,6 +1875,7 @@ hns3vf_is_reset_pending(struct hns3_adapter *hns)static int hns3vf_wait_hardware_ready (struct hns3_adapter *hns) { +#define HNS3_WAIT_PF_RESET_READY_TIME 5struct hns3_hw *hw = &hns->hw;struct hns3_wait_data *wait_data = hw->reset.wait_data;struct timeval tv;
@@ -1895,12 +1896,14 @@ hns3vf_wait_hardware_ready(struct hns3_adapter *hns)return 0 ; wait_data->check_completion =NULL ; - wait_data->interval =1 *MSEC_PER_SEC *USEC_PER_MSEC ; + wait_data->interval =HNS3_WAIT_PF_RESET_READY_TIME * +MSEC_PER_SEC *USEC_PER_MSEC ; wait_data->count =1 ; wait_data->result =HNS3_WAIT_REQUEST ;rte_eal_alarm_set (wait_data->interval, hns3_wait_callback, wait_data); -hns3_warn (hw,"hardware is ready, delay 1 sec for PF reset complete" ); +hns3_warn (hw,"hardware is ready, delay %d sec for PF reset complete" , +HNS3_WAIT_PF_RESET_READY_TIME );return -EAGAIN ; }else if (wait_data->result ==HNS3_WAIT_TIMEOUT ) {hns3_clock_gettime (&tv);
Signature · 1 line
2.33.0
Re: [PATCH v2] net/hns3: fix the time waiting for PF reset completion
Quoted 11 lines · Min Hu (Connor)
From: Huisong Li<[email protected]>
On the case that PF and VF need to be reset, after the hardware reset is complete, VF needs wait for 1 second to restore the configuration so that VF does not fail to recover because PF reset isn't complete. But the estimated time is not sufficient. This patch fixes it to 5 seconds.
Fixes 2790c6464725 ("net/hns3: support device reset")Signed-off-by Huisong Li<[email protected]>
Converting to explicit ack:
Applied to dpdk-next-net/main, thanks.
PATCH 5/6 net/hns3: fix RSS TC mode entry
In reply to Min Hu (Connor)From: Huisong Li <[email protected]>
The driver allocates queues only to valid TCs. But the driver also configure queues for invalid TCs, which is unreasonable.
--- drivers/net/hns3/hns3_rss.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/hns3/hns3_rss.c +2 -2
@@ -610,8 +610,8 @@ hns3_set_rss_tc_mode(struct hns3_hw *hw)for (i =0 ; i <HNS3_MAX_TC_NUM ; i++) { tc_valid[i] = !!(hw->hw_tc_map &BIT (i)); - tc_size[i] = roundup_size; - tc_offset[i] = rss_size * i; + tc_size[i] = tc_valid[i] ? roundup_size :0 ; + tc_offset[i] = tc_valid[i] ? rss_size * i :0 ; }hns3_cmd_setup_basic_desc (&desc,HNS3_OPC_RSS_TC_MODE , false);
Signature · 1 line
2.33.0
PATCH 6/6 net/hns3: fix VF RSS TC mode entry
In reply to Min Hu (Connor)From: Huisong Li <[email protected]>
For packets with VLAN priorities destined for the VF, hardware still assign Rx queue based on the Up-to-TC mapping PF configured. But VF has only one TC. If other TC don't enable, it causes that the priority packets that aren't destined for TC0 aren't received by RSS hash but is destined for queue 0. So driver has to enable the unused TC by using TC0 queue mapping configuration.
--- drivers/net/hns3/hns3_rss.c | 56 +++++++++++++++++++++++++++---------- 1 file changed, 41 insertions(+), 15 deletions(-)
drivers/net/hns3/hns3_rss.c +41 -15
@@ -587,33 +587,59 @@ hns3_dev_rss_reta_query(struct rte_eth_dev *dev,return 0 ; } -/* -* Used to configure the tc_size and tc_offset. -*/ +static void +hns3_set_rss_tc_mode_entry (struct hns3_hw *hw,uint8_t *tc_valid, +uint16_t *tc_size,uint16_t *tc_offset, +uint8_t tc_num) +{ +struct hns3_adapter *hns =HNS3_DEV_HW_TO_ADAPTER (hw); +uint16_t rss_size = hw->alloc_rss_size; +uint16_t roundup_size; +uint16_t i; + + roundup_size =roundup_pow_of_two (rss_size); + roundup_size =ilog2 (roundup_size); + +for (i =0 ; i < tc_num; i++) { +if (hns->is_vf) { +/* +* For packets with VLAN priorities destined for the VF, +* hardware still assign Rx queue based on the Up-to-TC +* mapping PF configured. But VF has only one TC. If +* other TC don't enable, it causes that the priority +* packets that aren't destined for TC0 aren't received +* by RSS hash but is destined for queue 0. So driver +* has to enable the unused TC by using TC0 queue +* mapping configuration. +*/ + tc_valid[i] = (hw->hw_tc_map &BIT (i)) ? + !!(hw->hw_tc_map &BIT (i)) :1 ; + tc_size[i] = roundup_size; + tc_offset[i] = (hw->hw_tc_map &BIT (i)) ? + rss_size * i :0 ; + }else { + tc_valid[i] = !!(hw->hw_tc_map &BIT (i)); + tc_size[i] = tc_valid[i] ? roundup_size :0 ; + tc_offset[i] = tc_valid[i] ? rss_size * i :0 ; + } + } +} +static int hns3_set_rss_tc_mode (struct hns3_hw *hw) { -uint16_t rss_size = hw->alloc_rss_size;struct hns3_rss_tc_mode_cmd *req;uint16_t tc_offset[HNS3_MAX_TC_NUM ];uint8_t tc_valid[HNS3_MAX_TC_NUM ];uint16_t tc_size[HNS3_MAX_TC_NUM ];struct hns3_cmd_desc desc; -uint16_t roundup_size;uint16_t i;int ret; - req = (struct hns3_rss_tc_mode_cmd *)desc.data; - - roundup_size =roundup_pow_of_two (rss_size); - roundup_size =ilog2 (roundup_size); - -for (i =0 ; i <HNS3_MAX_TC_NUM ; i++) { - tc_valid[i] = !!(hw->hw_tc_map &BIT (i)); - tc_size[i] = tc_valid[i] ? roundup_size :0 ; - tc_offset[i] = tc_valid[i] ? rss_size * i :0 ; - } +hns3_set_rss_tc_mode_entry (hw, tc_valid, tc_size, + tc_offset,HNS3_MAX_TC_NUM ); + req = (struct hns3_rss_tc_mode_cmd *)desc.data;hns3_cmd_setup_basic_desc (&desc,HNS3_OPC_RSS_TC_MODE , false);for (i =0 ; i <HNS3_MAX_TC_NUM ; i++) {uint16_t mode =0 ;
Signature · 1 line
2.33.0
v2 cover fix RSS bugs
In reply to Min Hu (Connor)This patch contains following patches:
ethdev: fix enabling RSS behavior inconsistent
net/hns3: remove unnecessary RSS switch
Huisong Li (2):
ethdev: fix enabling RSS behavior inconsistent
net/hns3: remove unnecessary RSS switch
drivers/net/hns3/hns3_ethdev.c | 2 -- drivers/net/hns3/hns3_ethdev.h | 1 - drivers/net/hns3/hns3_ethdev_vf.c | 2 -- drivers/net/hns3/hns3_flow.c | 1 - drivers/net/hns3/hns3_rss.c | 3 --- lib/ethdev/rte_ethdev.c | 15 +++++++++++++++ 6 files changed, 15 insertions(+), 9 deletions(-)
Signature · 1 line
2.33.0
PATCH v2 1/2 ethdev: fix enabling RSS behavior inconsistent
From: Huisong Li <[email protected]>
The RTE_ETH_MQ_RX_RSS_FLAG flag is a switch to enable RSS. If the flag is not set in dev_configure, RSS will be not configured and enabled. However, RSS hash and reta can still be configured by ethdev ops to enable RSS if the flag isn't set. The behavior is inconsistent.
--- lib/ethdev/rte_ethdev.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+)
lib/ethdev/rte_ethdev.c +15 -0
@@ -3867,6 +3867,7 @@ rte_eth_dev_rss_reta_update(uint16_t port_id, struct rte_eth_rss_reta_entry64 *reta_conf, uint16_t reta_size) { +enum rte_eth_rx_mq_mode mq_mode;struct rte_eth_dev *dev;int ret;
@@ -3898,6 +3899,12 @@ rte_eth_dev_rss_reta_update(uint16_t port_id,if (ret <0 )return ret; + mq_mode = dev->data->dev_conf.rxmode.mq_mode; +if (!(mq_mode &RTE_ETH_MQ_RX_RSS_FLAG )) { +RTE_ETHDEV_LOG (ERR ,"Multi-queue RSS mode isn't enabled.\n" ); +return -ENOTSUP ; + } +RTE_FUNC_PTR_OR_ERR_RET (*dev->dev_ops->reta_update, -ENOTSUP );return eth_err (port_id, (*dev->dev_ops->reta_update)(dev, reta_conf, reta_size));
@@ -3937,6 +3944,7 @@ rte_eth_dev_rss_hash_update(uint16_t port_id, {struct rte_eth_dev *dev;struct rte_eth_dev_info dev_info = { .flow_type_rss_offloads =0 , }; +enum rte_eth_rx_mq_mode mq_mode;int ret;RTE_ETH_VALID_PORTID_OR_ERR_RET (port_id, -ENODEV );
@@ -3962,6 +3970,13 @@ rte_eth_dev_rss_hash_update(uint16_t port_id, dev_info.flow_type_rss_offloads);return -EINVAL ; } + + mq_mode = dev->data->dev_conf.rxmode.mq_mode; +if (!(mq_mode &RTE_ETH_MQ_RX_RSS_FLAG )) { +RTE_ETHDEV_LOG (ERR ,"Multi-queue RSS mode isn't enabled.\n" ); +return -ENOTSUP ; + } +RTE_FUNC_PTR_OR_ERR_RET (*dev->dev_ops->rss_hash_update, -ENOTSUP );return eth_err (port_id, (*dev->dev_ops->rss_hash_update)(dev, rss_conf));
Signature · 1 line
2.33.0
Re: [PATCH v2 1/2] ethdev: fix enabling RSS behavior inconsistent
Quoted 7 lines · Min Hu (Connor)
From: Huisong Li<[email protected]>
The
RTE_ETH_MQ_RX_RSS_FLAGflag is a switch to enable RSS. If the flag is not set indev_configure, RSS will be not configured and enabled. However, RSS hash and reta can still be configured by ethdev ops to enable RSS if the flag isn't set. The behavior is inconsistent.
Quoted 5 lines
Fixes 99a2dd955fba ("lib: remove librte_ prefix from directory names")Signed-off-by Huisong Li<[email protected]>Signed-off-by Min Hu (Connor)<[email protected]>
PATCH v2 2/2 net/hns3: remove unnecessary RSS switch
In reply to Min Hu (Connor)From: Huisong Li <[email protected]>
Whether the RSS is enabled depends on RTE_ETH_MQ_RX_RSS_FLAG and packet tuple are enabled. So the RSS switch is unnecessary.
--- drivers/net/hns3/hns3_ethdev.c | 2 -- drivers/net/hns3/hns3_ethdev.h | 1 - drivers/net/hns3/hns3_ethdev_vf.c | 2 -- drivers/net/hns3/hns3_flow.c | 1 - drivers/net/hns3/hns3_rss.c | 3 --- 5 files changed, 9 deletions(-)
drivers/net/hns3/hns3_ethdev.c +0 -2
@@ -2019,7 +2019,6 @@ hns3_dev_configure(struct rte_eth_dev *dev)if ((uint32_t )mq_mode &RTE_ETH_MQ_RX_RSS_FLAG ) { conf->rxmode.offloads |=RTE_ETH_RX_OFFLOAD_RSS_HASH ; rss_conf = conf->rx_adv_conf.rss_conf; - hw->rss_dis_flag = false; ret =hns3_dev_rss_hash_update (dev, &rss_conf);if (ret) goto cfg_err;
@@ -2825,7 +2824,6 @@ hns3_get_board_configuration(struct hns3_hw *hw) hw->mac.media_type = cfg.media_type; hw->rss_size_max = cfg.rss_size_max; - hw->rss_dis_flag = false;memcpy (hw->mac.mac_addr, cfg.mac_addr,RTE_ETHER_ADDR_LEN ); hw->mac.phy_addr = cfg.phy_addr; hw->dcb_info.num_pg =1 ;
drivers/net/hns3/hns3_ethdev.h +0 -1
@@ -520,7 +520,6 @@ struct hns3_hw {/* The configuration info of RSS */ struct hns3_rss_conf rss_info; -bool rss_dis_flag;/* disable rss flag. true: disable, false: enable */ uint16_t rss_ind_tbl_size;uint16_t rss_key_size;
drivers/net/hns3/hns3_ethdev_vf.c +0 -2
@@ -495,7 +495,6 @@ hns3vf_dev_configure(struct rte_eth_dev *dev)/* When RSS is not configured, redirect the packet queue 0 */ if ((uint32_t )mq_mode &RTE_ETH_MQ_RX_RSS_FLAG ) { conf->rxmode.offloads |=RTE_ETH_RX_OFFLOAD_RSS_HASH ; - hw->rss_dis_flag = false; rss_conf = conf->rx_adv_conf.rss_conf; ret =hns3_dev_rss_hash_update (dev, &rss_conf);if (ret)
@@ -997,7 +996,6 @@ hns3vf_get_configuration(struct hns3_hw *hw)int ret; hw->mac.media_type =HNS3_MEDIA_TYPE_NONE ; - hw->rss_dis_flag = false;/* Get device capability */ ret =hns3vf_get_capability (hw);
drivers/net/hns3/hns3_flow.c +0 -1
@@ -1453,7 +1453,6 @@ hns3_disable_rss(struct hns3_hw *hw)/* Disable RSS */ hw->rss_info.conf.types =0 ; - hw->rss_dis_flag = true;return 0 ; }
drivers/net/hns3/hns3_rss.c +0 -3
@@ -408,9 +408,6 @@ hns3_dev_rss_hash_update(struct rte_eth_dev *dev,uint8_t *key = rss_conf->rss_key;int ret; -if (hw->rss_dis_flag) -return -EINVAL ; -rte_spinlock_lock (&hw->lock); ret =hns3_set_rss_tuple_by_rss_hf (hw, tuple, rss_hf);if (ret)
Signature · 1 line
2.33.0
Re: [PATCH v2 0/2] fix RSS bugs
In reply to Min Hu (Connor)Quoted 8 lines · Min Hu (Connor)
This patch contains following patches:
ethdev: fix enabling RSS behavior inconsistent
net/hns3: remove unnecessary RSS switchHuisong Li (2):
ethdev: fix enabling RSS behavior inconsistent
net/hns3: remove unnecessary RSS switch
Series applied to dpdk-next-net/main, thanks.