Skip to contentSkip to conversation

2.4.28-rc1, more lost patches [6/10]

PATCH [email protected] 2 participants 4 messages Oct 27, 2004 Uniform cdrom driver

lore
Share & tools
lore
#0 lore raw

[6/10] cdrom: If the device is opened O_EXCL but there are other openers, return busy. From ac/redhat. (by Arjan??)

from -ac / redhat
location of code moved upwards a bit

drivers/cdrom/cdrom.c +4 -0
diff -urN 28rc1/drivers/cdrom/cdrom.c 28rc1_aac/drivers/cdrom/cdrom.c
@@ -465,6 +465,10 @@
 	if ((cdi = cdrom_find_device(dev)) == NULL)
 		return -ENODEV;
 
+	/* If the device is opened O_EXCL but there are other openers, return busy */
+	if ( (fp->f_flags & O_EXCL) && (cdi->use_count>0) )
+		return -EBUSY;
+
 	if ((fp->f_mode & FMODE_WRITE) && !CDROM_CAN(CDC_DVD_RAM))
 		return -EROFS;
 
#1 lore raw
Quoted 2 lines · On Wed, 2004-10-27 at 12:40 +0300, [email protected] wrote:

[6/10] cdrom: If the device is opened O_EXCL but there are other openers, return busy. From ac/redhat. (by Arjan??)

this is a "feature" patch not a strict bugfix, so I'm not convinced it's suitable for 2.4 inclusion anymore.

author
#2 lore raw
Quoted 9 lines · Arjan van de Ven
Quoted 2 lines · On Wed, 2004-10-27 at 12:40 +0300, [email protected] wrote:

[6/10] cdrom: If the device is opened O_EXCL but there are other openers, return busy. From ac/redhat. (by Arjan??)

this is a "feature" patch not a strict bugfix, so I'm not convinced it's suitable for 2.4 inclusion anymore.

Do you think this would change 2.4-cdrom behavior incompatibly? It is not that extreme I think...

#3 lore raw
Quoted 3 lines · O.Sezer

Do you think this would change 2.4-cdrom behavior incompatibly? It is not that extreme I think...

wrong question ;)
for a very frozen tree like 2.4... the question is: what is the pressing reason to add this.
Not: why not add it.