Skip to contentSkip to conversation

Problem with hotplug functions

DISCUSSION Marcel Holtmann 3 participants 3 messages Oct 30, 2004

lore
Share & tools
lore
#0 lore raw

Hi,

I have a little problem with the hotplug functions and in particular with the one from firmware_class. The problem is that the extra env variables are not set when hotplug is called. Maybe this is fixed somewhere, but the lastest Bitkeeper snapshot of the Linus tree is not working for me.

I see a problem in kobject_hotplug() at lib/kobject_uevent.c:

        if (hotplug_ops->hotplug) {
                /* have the kset specific function add its stuff */
                retval = hotplug_ops->hotplug (kset, kobj,
                                  &envp[i], NUM_ENVP - i, scratch,
                                  BUFFER_SIZE - (scratch - buffer));
                if (retval) {
                        pr_debug ("%s - hotplug() returned %d\n",
                                  __FUNCTION__, retval);
                        goto exit;
                }
        }

        spin_lock(&sequence_lock);
        seq = ++hotplug_seqnum;
        spin_unlock(&sequence_lock);

        envp [i++] = scratch;
        scratch += sprintf(scratch, "SEQNUM=%lld", (long long)seq) + 1;

The hotplug function of hotplug_ops get called, but afterwards its values are overwritten by the sequence number. Is this correct or do I made a thinking mistake?

Regards

Marcel

#1 lore raw
Quoted 5 lines · Marcel Holtmann

Hi,

I have a little problem with the hotplug functions and in particular with the one from firmware_class. The problem is that the extra env variables are not set when hotplug is called.

Hm, that must be the reason why firmare loading for my atmel wireless card stopped working recently.

Signature · 1 line
Dmitry
#2 lore raw
In reply to Marcel Holtmann
Quoted 4 lines · Marcel Holtmann

The hotplug function of hotplug_ops get called, but afterwards its values are overwritten by the sequence number. Is this correct or do I made a thinking mistake?

You are correct, there's another thread on lkml about proposed patches to solve this bug. The last one from Kay looks like the final version I'll send to Linus tomorrow.

Sorry about this.

thanks,

greg k-h