mmc: add quirk to disable eMMC cache for Micron eMMC v5.0 cards
PATCH 1/1 mmc: add quirk to disable eMMC cache for Micron eMMC v5.0 cards
From: Vladimir Olovyannikov <[email protected]>
In certain rare combination of operations, Micron eMMC v5.0 cards may experience data errors if internal cache is enabled. This may lead to eMMC related data errors.
Introduce a quirk to disable cache on these eMMC cards.
--- drivers/mmc/core/card.h | 5 +++++ drivers/mmc/core/mmc.c | 4 ++-- drivers/mmc/core/quirks.h | 8 ++++++++ include/linux/mmc/card.h | 1 + 4 files changed, 16 insertions(+), 2 deletions(-)
drivers/mmc/core/card.h +5 -0
@@ -222,4 +222,9 @@ static inline int mmc_card_broken_hpi(const struct mmc_card *c) return c->quirks & MMC_QUIRK_BROKEN_HPI; } +static inline int mmc_card_broken_cache (const struct mmc_card *c) +{ +return c->quirks &MMC_QUIRK_BROKEN_CACHE ; +} +#endif
drivers/mmc/core/mmc.c +2 -2
@@ -1820,12 +1820,12 @@ static int mmc_init_card(struct mmc_host *host, u32 ocr,* sudden power failure tests. Let's extend the timeout to a minimum of * DEFAULT_CACHE_EN_TIMEOUT_MS and do it for all cards. */ -if (card->ext_csd.cache_size >0 ) { +if (!mmc_card_broken_cache (card) && card->ext_csd.cache_size >0 ) {unsigned int timeout_ms =MIN_CACHE_EN_TIMEOUT_MS ; timeout_ms =max (card->ext_csd.generic_cmd6_time, timeout_ms); err =mmc_switch (card,EXT_CSD_CMD_SET_NORMAL , -EXT_CSD_CACHE_CTRL ,1 , timeout_ms); +EXT_CSD_CACHE_CTRL ,1 , timeout_ms);if (err && err != -EBADMSG ) goto free_card;
drivers/mmc/core/quirks.h +8 -0
@@ -116,6 +116,14 @@ static const struct mmc_fixup __maybe_unused mmc_ext_csd_fixups[] = {MMC_FIXUP_EXT_CSD_REV (CID_NAME_ANY ,CID_MANFID_NUMONYX ,0x014e , add_quirk,MMC_QUIRK_BROKEN_HPI ,6 ), +/* +* In certain rare combination of operations, Micron eMMC v5.0 cards +* may experience data errors if internal cache is enabled. +* Disabling cache for these cards eliminates the issue. +*/ +MMC_FIXUP_EXT_CSD_REV (CID_NAME_ANY ,CID_MANFID_MICRON , +0x014e , add_quirk,MMC_QUIRK_BROKEN_CACHE ,7 ), + END_FIXUP };
include/linux/mmc/card.h +1 -0
@@ -270,6 +270,7 @@ struct mmc_card {#define MMC_QUIRK_BROKEN_IRQ_POLLING (1<<11)/* Polling SDIO_CCCR_INTx could create a fake interrupt */ #define MMC_QUIRK_TRIM_BROKEN (1<<12)/* Skip trim */ #define MMC_QUIRK_BROKEN_HPI (1<<13)/* Disable broken HPI support */ +#define MMC_QUIRK_BROKEN_CACHE (1<<14)/* Disable broken cache */ bool reenable_cmdq;/* Re-enable Command Queue */
Signature · 1 line
2.17.1
+ Bean Huo, Luca Porzio
Quoted 7 lines · Scott Branden
From: Vladimir Olovyannikov <[email protected]>
In certain rare combination of operations, Micron eMMC v5.0 cards may experience data errors if internal cache is enabled. This may lead to eMMC related data errors.
Introduce a quirk to disable cache on these eMMC cards.
Can you please elaborate on this, what combinations of operations are you referring to - and what kind of data errors?
I have also looped in some of the Micron guys, to let them chim in.
Quoted 3 lines
Signed-off-by Vladimir Olovyannikov <[email protected]>Signed-off-by Scott Branden <[email protected]>
Kind regards
Uffe
Quoted 74 lines
--- drivers/mmc/core/card.h | 5 +++++ drivers/mmc/core/mmc.c | 4 ++-- drivers/mmc/core/quirks.h | 8 ++++++++ include/linux/mmc/card.h | 1 + 4 files changed, 16 insertions(+), 2 deletions(-)drivers/mmc/core/card.h +5
-0@@ -222,4 +222,9 @@ static inline int mmc_card_broken_hpi(const struct mmc_card *c) return c->quirks & MMC_QUIRK_BROKEN_HPI; } +static inline int mmc_card_broken_cache (const struct mmc_card *c) +{ +return c->quirks &MMC_QUIRK_BROKEN_CACHE ; +} +#endif drivers/mmc/core/mmc.c +2
-2@@ -1820,12 +1820,12 @@ static int mmc_init_card(struct mmc_host *host, u32 ocr,* sudden power failure tests. Let's extend the timeout to a minimum of * DEFAULT_CACHE_EN_TIMEOUT_MS and do it for all cards. */ -if (card->ext_csd.cache_size >0 ) { +if (!mmc_card_broken_cache (card) && card->ext_csd.cache_size >0 ) {unsigned int timeout_ms =MIN_CACHE_EN_TIMEOUT_MS ; timeout_ms =max (card->ext_csd.generic_cmd6_time, timeout_ms); err =mmc_switch (card,EXT_CSD_CMD_SET_NORMAL , -EXT_CSD_CACHE_CTRL ,1 , timeout_ms); +EXT_CSD_CACHE_CTRL ,1 , timeout_ms);if (err && err != -EBADMSG ) goto free_card;drivers/mmc/core/quirks.h +8
-0@@ -116,6 +116,14 @@ static const struct mmc_fixup __maybe_unused mmc_ext_csd_fixups[] = {MMC_FIXUP_EXT_CSD_REV (CID_NAME_ANY ,CID_MANFID_NUMONYX ,0x014e , add_quirk,MMC_QUIRK_BROKEN_HPI ,6 ), +/* +* In certain rare combination of operations, Micron eMMC v5.0 cards +* may experience data errors if internal cache is enabled. +* Disabling cache for these cards eliminates the issue. +*/ +MMC_FIXUP_EXT_CSD_REV (CID_NAME_ANY ,CID_MANFID_MICRON , +0x014e , add_quirk,MMC_QUIRK_BROKEN_CACHE ,7 ), + END_FIXUP };include/linux/mmc/card.h +1
-1@@ -270,6 +270,7 @@ struct mmc_card {#define MMC_QUIRK_BROKEN_IRQ_POLLING (1<<11)/* Polling SDIO_CCCR_INTx could create a fake interrupt */ #define MMC_QUIRK_TRIM_BROKEN (1<<12)/* Skip trim */ #define MMC_QUIRK_BROKEN_HPI (1<<13)/* Disable broken HPI support */ +#define MMC_QUIRK_BROKEN_CACHE (1<<14)/* Disable broken cache */ bool reenable_cmdq;/* Re-enable Command Queue */ --2.17.1
+Travis Dirkes,
Could you provide more details on the Micron data error.
Quoted 97 lines · Ulf Hansson
+ Bean Huo, Luca Porzio
Quoted 7 lines · Scott Branden
From: Vladimir Olovyannikov <[email protected]>
In certain rare combination of operations, Micron eMMC v5.0 cards may experience data errors if internal cache is enabled. This may lead to eMMC related data errors.
Introduce a quirk to disable cache on these eMMC cards.Can you please elaborate on this, what combinations of operations are you referring to - and what kind of data errors?
I have also looped in some of the Micron guys, to let them chim in.
Quoted 3 lines
Signed-off-by Vladimir Olovyannikov <[email protected]>Signed-off-by Scott Branden <[email protected]>Kind regards
UffeQuoted 74 lines
--- drivers/mmc/core/card.h | 5 +++++ drivers/mmc/core/mmc.c | 4 ++-- drivers/mmc/core/quirks.h | 8 ++++++++ include/linux/mmc/card.h | 1 + 4 files changed, 16 insertions(+), 2 deletions(-)drivers/mmc/core/card.h +5
-0@@ -222,4 +222,9 @@ static inline int mmc_card_broken_hpi(const struct mmc_card *c) return c->quirks & MMC_QUIRK_BROKEN_HPI; } +static inline int mmc_card_broken_cache (const struct mmc_card *c) +{ +return c->quirks &MMC_QUIRK_BROKEN_CACHE ; +} +#endif drivers/mmc/core/mmc.c +2
-2@@ -1820,12 +1820,12 @@ static int mmc_init_card(struct mmc_host *host, u32 ocr,* sudden power failure tests. Let's extend the timeout to a minimum of * DEFAULT_CACHE_EN_TIMEOUT_MS and do it for all cards. */ -if (card->ext_csd.cache_size >0 ) { +if (!mmc_card_broken_cache (card) && card->ext_csd.cache_size >0 ) {unsigned int timeout_ms =MIN_CACHE_EN_TIMEOUT_MS ; timeout_ms =max (card->ext_csd.generic_cmd6_time, timeout_ms); err =mmc_switch (card,EXT_CSD_CMD_SET_NORMAL , -EXT_CSD_CACHE_CTRL ,1 , timeout_ms); +EXT_CSD_CACHE_CTRL ,1 , timeout_ms);if (err && err != -EBADMSG ) goto free_card;drivers/mmc/core/quirks.h +8
-0@@ -116,6 +116,14 @@ static const struct mmc_fixup __maybe_unused mmc_ext_csd_fixups[] = {MMC_FIXUP_EXT_CSD_REV (CID_NAME_ANY ,CID_MANFID_NUMONYX ,0x014e , add_quirk,MMC_QUIRK_BROKEN_HPI ,6 ), +/* +* In certain rare combination of operations, Micron eMMC v5.0 cards +* may experience data errors if internal cache is enabled. +* Disabling cache for these cards eliminates the issue. +*/ +MMC_FIXUP_EXT_CSD_REV (CID_NAME_ANY ,CID_MANFID_MICRON , +0x014e , add_quirk,MMC_QUIRK_BROKEN_CACHE ,7 ), + END_FIXUP };include/linux/mmc/card.h +1
-1@@ -270,6 +270,7 @@ struct mmc_card {#define MMC_QUIRK_BROKEN_IRQ_POLLING (1<<11)/* Polling SDIO_CCCR_INTx could create a fake interrupt */ #define MMC_QUIRK_TRIM_BROKEN (1<<12)/* Skip trim */ #define MMC_QUIRK_BROKEN_HPI (1<<13)/* Disable broken HPI support */ +#define MMC_QUIRK_BROKEN_CACHE (1<<14)/* Disable broken cache */ bool reenable_cmdq;/* Re-enable Command Queue */ --2.17.1
+Travis Dirkes (with corrected email),
Could you provide more details on the Micron data error.
Quoted 99 lines · Ulf Hansson
Quoted 97 lines
+ Bean Huo, Luca Porzio
Quoted 7 lines · Scott Branden
From: Vladimir Olovyannikov <[email protected]>
In certain rare combination of operations, Micron eMMC v5.0 cards may experience data errors if internal cache is enabled. This may lead to eMMC related data errors.
Introduce a quirk to disable cache on these eMMC cards.Can you please elaborate on this, what combinations of operations are you referring to - and what kind of data errors?
I have also looped in some of the Micron guys, to let them chim in.
Quoted 3 lines
Signed-off-by Vladimir Olovyannikov <[email protected]>Signed-off-by Scott Branden <[email protected]>Kind regards
UffeQuoted 74 lines
--- drivers/mmc/core/card.h | 5 +++++ drivers/mmc/core/mmc.c | 4 ++-- drivers/mmc/core/quirks.h | 8 ++++++++ include/linux/mmc/card.h | 1 + 4 files changed, 16 insertions(+), 2 deletions(-)drivers/mmc/core/card.h +5
-0@@ -222,4 +222,9 @@ static inline int mmc_card_broken_hpi(const struct mmc_card *c) return c->quirks & MMC_QUIRK_BROKEN_HPI; } +static inline int mmc_card_broken_cache (const struct mmc_card *c) +{ +return c->quirks &MMC_QUIRK_BROKEN_CACHE ; +} +#endif drivers/mmc/core/mmc.c +2
-2@@ -1820,12 +1820,12 @@ static int mmc_init_card(struct mmc_host *host, u32 ocr,* sudden power failure tests. Let's extend the timeout to a minimum of * DEFAULT_CACHE_EN_TIMEOUT_MS and do it for all cards. */ -if (card->ext_csd.cache_size >0 ) { +if (!mmc_card_broken_cache (card) && card->ext_csd.cache_size >0 ) {unsigned int timeout_ms =MIN_CACHE_EN_TIMEOUT_MS ; timeout_ms =max (card->ext_csd.generic_cmd6_time, timeout_ms); err =mmc_switch (card,EXT_CSD_CMD_SET_NORMAL , -EXT_CSD_CACHE_CTRL ,1 , timeout_ms); +EXT_CSD_CACHE_CTRL ,1 , timeout_ms);if (err && err != -EBADMSG ) goto free_card;drivers/mmc/core/quirks.h +8
-0@@ -116,6 +116,14 @@ static const struct mmc_fixup __maybe_unused mmc_ext_csd_fixups[] = {MMC_FIXUP_EXT_CSD_REV (CID_NAME_ANY ,CID_MANFID_NUMONYX ,0x014e , add_quirk,MMC_QUIRK_BROKEN_HPI ,6 ), +/* +* In certain rare combination of operations, Micron eMMC v5.0 cards +* may experience data errors if internal cache is enabled. +* Disabling cache for these cards eliminates the issue. +*/ +MMC_FIXUP_EXT_CSD_REV (CID_NAME_ANY ,CID_MANFID_MICRON , +0x014e , add_quirk,MMC_QUIRK_BROKEN_CACHE ,7 ), + END_FIXUP };include/linux/mmc/card.h +1
-1@@ -270,6 +270,7 @@ struct mmc_card {#define MMC_QUIRK_BROKEN_IRQ_POLLING (1<<11)/* Polling SDIO_CCCR_INTx could create a fake interrupt */ #define MMC_QUIRK_TRIM_BROKEN (1<<12)/* Skip trim */ #define MMC_QUIRK_BROKEN_HPI (1<<13)/* Disable broken HPI support */ +#define MMC_QUIRK_BROKEN_CACHE (1<<14)/* Disable broken cache */ bool reenable_cmdq;/* Re-enable Command Queue */ --2.17.1
Scott hi,
Can you take a look at https://lore.kernel.org/lkml/[email protected]/
Is there a chance that it will work for you as well?
Thanks,
Avri
Quoted 128 lines
-----Original Message-----
From: Scott Branden <[email protected]>
Sent: Tuesday, 13 April 2021 18:46
To: Ulf Hansson <[email protected]>; Bean Huo (beanhuo) <[email protected]>; Luca Porzio (lporzio) <[email protected]>; [email protected]
Cc: BCM Kernel Feedback <[email protected]>; linux- mmc <[email protected]>; Linux Kernel Mailing List <linux- [email protected]>; Vladimir Olovyannikov <[email protected]>
Subject: Re: [PATCH] mmc: add quirk to disable eMMC cache for Micron eMMC v5.0 cards+Travis Dirkes (with corrected email),
Could you provide more details on the Micron data error.
Quoted 4 lines · Ulf Hansson
Quoted 3 lines
+ Bean Huo, Luca Porzio
On Thu, 8 Apr 2021 at 19:59, Scott Branden
Quoted 8 lines · <[email protected]> wrote:
Quoted 8 lines
Quoted 7 lines
From: Vladimir Olovyannikov <[email protected]>
In certain rare combination of operations, Micron eMMC v5.0 cards may experience data errors if internal cache is enabled. This may lead to eMMC related data errors.
Introduce a quirk to disable cache on these eMMC cards.Quoted 7 lines
Quoted 7 lines
Can you please elaborate on this, what combinations of operations are you referring to - and what kind of data errors?
I have also looped in some of the Micron guys, to let them chim in.
Quoted 2 lines
Signed-off-by Vladimir OlovyannikovQuoted 12 lines
Quoted 12 lines
Quoted 1 line
Signed-off-by Scott Branden <[email protected]>Kind regards
UffeQuoted 7 lines
--- drivers/mmc/core/card.h | 5 +++++ drivers/mmc/core/mmc.c | 4 ++-- drivers/mmc/core/quirks.h | 8 ++++++++ include/linux/mmc/card.h | 1 + 4 files changed, 16 insertions(+), 2 deletions(-)Quoted 5 lines
Quoted 5 lines
drivers/mmc/core/card.h static inline int mmc_card_broken_hpi(const
Quoted 5 lines
drivers/mmc/core/card.h +0
-0@@ -222,4 +222,9 @@ static inline int mmc_card_broken_hpi(conststruct
mmc_card*c)Quoted 14 lines
Quoted 14 lines
drivers/mmc/core/mmc.c static int mmc_init_card(struct mmc_host
Quoted 14 lines
drivers/mmc/core/card.h +5
-0return c->quirks & MMC_QUIRK_BROKEN_HPI; } +static inline int mmc_card_broken_cache (const struct mmc_card *c) +{ +return c->quirks &MMC_QUIRK_BROKEN_CACHE ; +} +#endif drivers/mmc/core/mmc.c +0
-0@@ -1820,12 +1820,12 @@ static int mmc_init_card(struct mmc_host*host, u32 ocr,
Quoted 5 lines
Quoted 5 lines
drivers/mmc/core/mmc.c static int mmc_init_card(struct mmc_host *host, u32 ocr,
Quoted 5 lines
drivers/mmc/core/mmc.c +1
-1* sudden power failure tests. Let's extend the timeout to a minimum of * DEFAULT_CACHE_EN_TIMEOUT_MS and do it for all cards. */ -if (card->ext_csd.cache_size >0 ) { +if (!mmc_card_broken_cache (card) && card->ext_csd.cache_size >0 ){
Quoted 3 lines
Quoted 3 lines
drivers/mmc/core/mmc.c static int mmc_init_card(struct mmc_host *host, u32 ocr,
Quoted 3 lines
drivers/mmc/core/mmc.c +0
-0unsigned int timeout_ms =MIN_CACHE_EN_TIMEOUT_MS ; timeout_ms = max(card->ext_csd.generic_cmd6_time,
timeout_ms);Quoted 11 lines
Quoted 11 lines
drivers/mmc/core/quirks.h static const struct mmc_fixup __maybe_unused
Quoted 11 lines
drivers/mmc/core/mmc.c +1
-1err =mmc_switch (card,EXT_CSD_CMD_SET_NORMAL , -EXT_CSD_CACHE_CTRL ,1 , timeout_ms); +EXT_CSD_CACHE_CTRL ,1 , timeout_ms);if (err && err != -EBADMSG ) goto free_card;drivers/mmc/core/quirks.h +0
-0@@ -116,6 +116,14 @@ static const struct mmc_fixup __maybe_unusedmmc_ext_csd_fixups[] = {
Quoted 1 line
Quoted 1 line
drivers/mmc/core/quirks.h static const struct mmc_fixup __maybe_unused · line 116
Quoted 1 line
drivers/mmc/core/quirks.h +0
-0MMC_FIXUP_EXT_CSD_REV(CID_NAME_ANY,
CID_MANFID_NUMONYX,Quoted 8 lines
Quoted 8 lines
drivers/mmc/core/quirks.h static const struct mmc_fixup __maybe_unused mmc_ext_csd_fixups[] = {
Quoted 8 lines
drivers/mmc/core/quirks.h +6
-00x014e, add_quirk, MMC_QUIRK_BROKEN_HPI, 6), +/* +* In certain rare combination of operations, Micron eMMC v5.0 cards +* may experience data errors if internal cache is enabled. +* Disabling cache for these cards eliminates the issue. +*/ + MMC_FIXUP_EXT_CSD_REV(CID_NAME_ANY,
CID_MANFID_MICRON,Quoted 11 lines
Quoted 11 lines
include/linux/mmc/card.h struct mmc_card { · line 270
Quoted 11 lines
drivers/mmc/core/quirks.h +2
-0+ 0x014e, add_quirk, MMC_QUIRK_BROKEN_CACHE, 7), +END_FIXUP };include/linux/mmc/card.h +0
-0@@ -270,6 +270,7 @@ struct mmc_card {#define MMC_QUIRK_BROKEN_IRQ_POLLING (1<<11)/* Polling
SDIO_CCCR_INTxcould create a fake interrupt */Quoted 2 lines
Quoted 2 lines
include/linux/mmc/card.h struct mmc_card { · line 272
Quoted 2 lines
include/linux/mmc/card.h +0
-0#define MMC_QUIRK_TRIM_BROKEN (1<<12)/* Skip trim */ #define MMC_QUIRK_BROKEN_HPI (1<<13)/* Disable broken HPI support */
Quoted 1 line
Quoted 1 line
include/linux/mmc/card.h struct mmc_card { · line 273
Quoted 1 line
include/linux/mmc/card.h +1
-0+#define MMC_QUIRK_BROKEN_CACHE (1<<14)/* Disable broken cache */
Quoted 7 lines
Quoted 6 lines
Quoted 6 lines
include/linux/mmc/card.h +0
-1bool reenable_cmdq;/* Re-enable Command Queue */ --2.17.1
Quoted 11 lines · Scott Branden
From: Vladimir Olovyannikov <[email protected]>
In certain rare combination of operations, Micron eMMC v5.0 cards
may experience data errors if internal cache is enabled.
This may lead to eMMC related data errors.
Introduce a quirk to disable cache on these eMMC cards.
Hi, Scott
Give me some time, let check and confirm this interanlly.
thanks,
Bean