Skip to contentSkip to conversation

ti-librpmsg-dma: Move this recipe to its own directory

PATCH In review Andrew Davis 3 participants 7 messages Jun 24 – Jul 2

lore
Share & tools
lore
#0 lore raw

PATCH 1/3 ti-librpmsg-dma: Move this recipe to its own directory

Keeping all IPC related recipes in one "ipc" directory is not very well organized. Like most other recipes give this one its own directory.

---
 .../recipes-ti/{ipc => ti-librpmsg-dma}/ti-librpmsg-dma_1.0.bb    | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 rename meta-ti-bsp/recipes-ti/{ipc => ti-librpmsg-dma}/ti-librpmsg-dma_1.0.bb (100%)
meta-ti-bsp/recipes-ti/ti-librpmsg-dma/ti-librpmsg-dma_1.0.bb renamed from meta-ti-bsp/recipes-ti/ipc/ti-librpmsg-dma_1.0.bb +0 -0
similarity index 100%
rename from meta-ti-bsp/recipes-ti/ipc/ti-librpmsg-dma_1.0.bb
rename to meta-ti-bsp/recipes-ti/ti-librpmsg-dma/ti-librpmsg-dma_1.0.bb
Signature · 1 line
2.39.2
#1 lore raw

PATCH 2/3 ti-rpmsg-char: Move this recipe to its own directory

Keeping all IPC related recipes in one "ipc" directory is not very well organized. Like most other recipes give this one its own directory.

---
 .../0001-examples-Remove-use-of-includedir-and-libdir.patch       | 0
 .../{ipc => ti-rpmsg-char}/ti-rpmsg-char-examples_git.bb          | 0
 meta-ti-bsp/recipes-ti/{ipc => ti-rpmsg-char}/ti-rpmsg-char.inc   | 0
 .../recipes-ti/{ipc => ti-rpmsg-char}/ti-rpmsg-char_git.bb        | 0
 4 files changed, 0 insertions(+), 0 deletions(-)
 rename meta-ti-bsp/recipes-ti/{ipc => ti-rpmsg-char}/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch (100%)
 rename meta-ti-bsp/recipes-ti/{ipc => ti-rpmsg-char}/ti-rpmsg-char-examples_git.bb (100%)
 rename meta-ti-bsp/recipes-ti/{ipc => ti-rpmsg-char}/ti-rpmsg-char.inc (100%)
 rename meta-ti-bsp/recipes-ti/{ipc => ti-rpmsg-char}/ti-rpmsg-char_git.bb (100%)
meta-ti-bsp/recipes-ti/ti-rpmsg-char/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch renamed from meta-ti-bsp/recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch +0 -0
similarity index 100%
rename from meta-ti-bsp/recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch
rename to meta-ti-bsp/recipes-ti/ti-rpmsg-char/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch
meta-ti-bsp/recipes-ti/ti-rpmsg-char/ti-rpmsg-char-examples_git.bb renamed from meta-ti-bsp/recipes-ti/ipc/ti-rpmsg-char-examples_git.bb +0 -0
similarity index 100%
rename from meta-ti-bsp/recipes-ti/ipc/ti-rpmsg-char-examples_git.bb
rename to meta-ti-bsp/recipes-ti/ti-rpmsg-char/ti-rpmsg-char-examples_git.bb
meta-ti-bsp/recipes-ti/ti-rpmsg-char/ti-rpmsg-char.inc renamed from meta-ti-bsp/recipes-ti/ipc/ti-rpmsg-char.inc +0 -0
similarity index 100%
rename from meta-ti-bsp/recipes-ti/ipc/ti-rpmsg-char.inc
rename to meta-ti-bsp/recipes-ti/ti-rpmsg-char/ti-rpmsg-char.inc
meta-ti-bsp/recipes-ti/ti-rpmsg-char/ti-rpmsg-char_git.bb renamed from meta-ti-bsp/recipes-ti/ipc/ti-rpmsg-char_git.bb +0 -0
similarity index 100%
rename from meta-ti-bsp/recipes-ti/ipc/ti-rpmsg-char_git.bb
rename to meta-ti-bsp/recipes-ti/ti-rpmsg-char/ti-rpmsg-char_git.bb
Signature · 1 line
2.39.2
#2 lore raw

PATCH 3/3 ti-rpmsg-char: Update to latest with CMake support

In reply to Andrew Davis

This project now uses CMake. This allows us to cleanup this recipe in 3 ways:

- Remove patch for includedir and libdir as CMake handles this correctly
- Combine in the in the examples recipe, CMake builds the examples along with the library in one step.
- As there is now only one recipe, merge the .inc into the one .bb file

---
 ...-Remove-use-of-includedir-and-libdir.patch | 44 -------------------
 .../ti-rpmsg-char-examples_git.bb             | 13 ------
 .../ti-rpmsg-char/ti-rpmsg-char.inc           | 15 -------
 .../ti-rpmsg-char/ti-rpmsg-char_git.bb        | 20 +++++++--
 4 files changed, 17 insertions(+), 75 deletions(-)
 delete mode 100644 meta-ti-bsp/recipes-ti/ti-rpmsg-char/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch
 delete mode 100644 meta-ti-bsp/recipes-ti/ti-rpmsg-char/ti-rpmsg-char-examples_git.bb
 delete mode 100644 meta-ti-bsp/recipes-ti/ti-rpmsg-char/ti-rpmsg-char.inc
meta-ti-bsp/recipes-ti/ti-rpmsg-char/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch deleted +0 -44
deleted file mode 100644
index 3539e8d9..00000000
@@ -1,44 +0,0 @@
-From 1a26cb577ba54dd9214eeb94fed0ce3a0f4603b6 Mon Sep 17 00:00:00 2001
-From: Khem Raj <[email protected]>
-Date: Sat, 24 Oct 2020 23:46:39 -0700
-Subject: [PATCH] examples: Remove use of includedir and libdir
-
-These point to standard include and library paths which already are used
-from sysroot relative paths secondly, they use absolute paths which
-means we are asking to add -I/usr/include which might be ok in a native
-build but not in cross build. This helps mitigate QA errors found with
-OE build system since it finds it adding host include and library search
-paths to linker/compiler commandline
-
-Upstream-Status: Pending
-Signed-off-by: Khem Raj <[email protected]>
----
- examples/Makefile.am | 6 +-----
- 1 file changed, 1 insertion(+), 5 deletions(-)
-
-diff --git a/examples/Makefile.am b/examples/Makefile.am
-index da34204..34ac7a8 100644
---- a/examples/Makefile.am
-+++ b/examples/Makefile.am
-@@ -1,6 +1,4 @@
--INCLUDE = -I${includedir}
--
--AM_CFLAGS = -Wall -g -O2 $(INCLUDE)
-+AM_CFLAGS = -Wall -g -O2
- 
- bin_PROGRAMS = rpmsg_char_simple rpmsg_char_benchmark
- 
-@@ -8,10 +6,8 @@ bin_PROGRAMS = rpmsg_char_simple rpmsg_char_benchmark
- rpmsg_char_simple_SOURCES = rpmsg_char_simple.c
- rpmsg_char_simple_CPPFLAGS = $(AM_CFLAGS)
- rpmsg_char_simple_LDADD = -lpthread -lti_rpmsg_char
--rpmsg_char_simple_LDFLAGS = -L${libdir}
-
- # rpmsg_char_benchmark program
- rpmsg_char_benchmark_SOURCES = rpmsg_char_benchmark.c
- rpmsg_char_benchmark_CPPFLAGS = $(AM_CFLAGS)
- rpmsg_char_benchmark_LDADD = -lpthread -lti_rpmsg_char
--rpmsg_char_benchmark_LDFLAGS = -L${libdir}
--- 
-2.29.1
-
meta-ti-bsp/recipes-ti/ti-rpmsg-char/ti-rpmsg-char-examples_git.bb deleted +0 -13
deleted file mode 100644
index cbe4d7fd..00000000
@@ -1,13 +0,0 @@
-SUMMARY = "TI RPMsg Char Sample Applications and Tests"
-
-require ti-rpmsg-char.inc
-
-SRC_URI += "file://0001-examples-Remove-use-of-includedir-and-libdir.patch"
-
-DEPENDS = "ti-rpmsg-char"
-
-inherit autotools pkgconfig
-
-EXTRA_OEMAKE = "-C ${B}/examples"
-
-PR = "r0"
meta-ti-bsp/recipes-ti/ti-rpmsg-char/ti-rpmsg-char.inc deleted +0 -15
deleted file mode 100644
index f9fb0f25..00000000
@@ -1,15 +0,0 @@
-SUMMARY = "TI RPMsg Char Utility Library"
-
-LICENSE = "BSD-3-Clause"
-LIC_FILES_CHKSUM = "file://${S}/src/rpmsg_char.c;beginline=1;endline=31;md5=71987db43a2159cff5ea00505c6fce58"
-
-PROTOCOL = "https"
-BRANCH = "master"
-SRC_URI = "git://git.ti.com/git/rpmsg/ti-rpmsg-char.git;protocol=${PROTOCOL};branch=${BRANCH};"
-
-# 0.6.11 release
-SRCREV = "dd4783422bf4fbed1015bfaa51054e40057b4f04"
-
-PV = "0.6.11+git"
-
-COMPATIBLE_MACHINE = "^(k3)$"
meta-ti-bsp/recipes-ti/ti-rpmsg-char/ti-rpmsg-char_git.bb +17 -3
index 50565300..a0043caf 100644
@@ -1,9 +1,23 @@
 SUMMARY = "TI RPMsg Char Utility Library"
 
-require ti-rpmsg-char.inc
+LICENSE = "BSD-3-Clause"
+LIC_FILES_CHKSUM = "file://${S}/src/rpmsg_char.c;beginline=1;endline=31;md5=71987db43a2159cff5ea00505c6fce58"
 
-inherit autotools pkgconfig
+PROTOCOL = "https"
+BRANCH = "master"
+SRC_URI = "git://git.ti.com/git/rpmsg/ti-rpmsg-char.git;protocol=${PROTOCOL};branch=${BRANCH};"
 
+# 0.6.11 release
+SRCREV = "e36103aac7d9f6d64125eb917d3c69022cb86e0b"
+
+PV = "0.6.11+git"
 PR = "r0"
 
-DISABLE_STATIC = ""
+COMPATIBLE_MACHINE = "^(k3)$"
+
+inherit cmake
+
+PACKAGES =+ "${PN}-examples"
+FILES:${PN}-examples += "${bindir}/rpmsg_char_simple"
+FILES:${PN}-examples += "${bindir}/rpmsg_char_benchmark"
+RDEPENDS:${PN}-examples += "${PN}"
Signature · 1 line
2.39.2
#3 lore raw

Re: [meta-ti][master/wrynose][PATCH 3/3] ti-rpmsg-char: Update to latest with CMake support

Did you do a test build with this? I'm getting this error for all k3 platforms that depend on ti-rpmsg-char-staticdev:

Solver encountered 1 problem(s):
Problem 1/1:
- package
packagegroup-arago-toolchain-tisdk-target-1.0-r14.7.am62axx_evm requires packagegroup-arago-addons-sdk-target, but none of the providers can be installed
- conflicting requests
- nothing provides ti-rpmsg-char-staticdev needed by
packagegroup-arago-addons-sdk-target-1.0-r44.0.am62axx_evm

Either we should remove the dependency or fix the new recipe.

I'm going to keep patch #2 from this series, but #3 needs to either fix the issue, or remove the dependency.

Quoted 140 lines · Andrew Davis

This project now uses CMake. This allows us to cleanup this recipe in 3 ways:

- Remove patch for includedir and libdir as CMake handles this correctly
- Combine in the in the examples recipe, CMake builds the examples along with the library in one step.
- As there is now only one recipe, merge the .inc into the one .bb file

---
  ...-Remove-use-of-includedir-and-libdir.patch | 44 -------------------
  .../ti-rpmsg-char-examples_git.bb             | 13 ------
  .../ti-rpmsg-char/ti-rpmsg-char.inc           | 15 -------
  .../ti-rpmsg-char/ti-rpmsg-char_git.bb        | 20 +++++++--
  4 files changed, 17 insertions(+), 75 deletions(-)

delete mode 100644 meta-ti-bsp/recipes-ti/ti-rpmsg-char/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch delete mode 100644 meta-ti-bsp/recipes-ti/ti-rpmsg-char/ti-rpmsg-char-examples_git.bb
delete mode 100644 meta-ti-bsp/recipes-ti/ti-rpmsg-char/ti-rpmsg-char.inc

meta-ti-bsp/recipes-ti/ti-rpmsg-char/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch deleted +0 -44
deleted file mode 100644
index 3539e8d9..00000000
@@ -1,44 +0,0 @@
-From 1a26cb577ba54dd9214eeb94fed0ce3a0f4603b6 Mon Sep 17 00:00:00 2001
-From: Khem Raj <[email protected]>
-Date: Sat, 24 Oct 2020 23:46:39 -0700
-Subject: [PATCH] examples: Remove use of includedir and libdir
-
-These point to standard include and library paths which already are used
-from sysroot relative paths secondly, they use absolute paths which
-means we are asking to add -I/usr/include which might be ok in a native
-build but not in cross build. This helps mitigate QA errors found with
-OE build system since it finds it adding host include and library search
-paths to linker/compiler commandline
-
-Upstream-Status: Pending
-Signed-off-by: Khem Raj <[email protected]>
----
- examples/Makefile.am | 6 +-----
- 1 file changed, 1 insertion(+), 5 deletions(-)
-
-diff --git a/examples/Makefile.am b/examples/Makefile.am
-index da34204..34ac7a8 100644
---- a/examples/Makefile.am
-+++ b/examples/Makefile.am
-@@ -1,6 +1,4 @@
--INCLUDE = -I${includedir}
--
--AM_CFLAGS = -Wall -g -O2 $(INCLUDE)
-+AM_CFLAGS = -Wall -g -O2
-
- bin_PROGRAMS = rpmsg_char_simple rpmsg_char_benchmark
-
-@@ -8,10 +6,8 @@ bin_PROGRAMS = rpmsg_char_simple rpmsg_char_benchmark
- rpmsg_char_simple_SOURCES = rpmsg_char_simple.c
- rpmsg_char_simple_CPPFLAGS = $(AM_CFLAGS)
- rpmsg_char_simple_LDADD = -lpthread -lti_rpmsg_char
--rpmsg_char_simple_LDFLAGS = -L${libdir}
-
- # rpmsg_char_benchmark program
- rpmsg_char_benchmark_SOURCES = rpmsg_char_benchmark.c
- rpmsg_char_benchmark_CPPFLAGS = $(AM_CFLAGS)
- rpmsg_char_benchmark_LDADD = -lpthread -lti_rpmsg_char
--rpmsg_char_benchmark_LDFLAGS = -L${libdir}
---
-2.29.1
-
meta-ti-bsp/recipes-ti/ti-rpmsg-char/ti-rpmsg-char-examples_git.bb deleted +0 -13
deleted file mode 100644
index cbe4d7fd..00000000
@@ -1,13 +0,0 @@
-SUMMARY = "TI RPMsg Char Sample Applications and Tests"
-
-require ti-rpmsg-char.inc
-
-SRC_URI += "file://0001-examples-Remove-use-of-includedir-and-libdir.patch"
-
-DEPENDS = "ti-rpmsg-char"
-
-inherit autotools pkgconfig
-
-EXTRA_OEMAKE = "-C ${B}/examples"
-
-PR = "r0"
meta-ti-bsp/recipes-ti/ti-rpmsg-char/ti-rpmsg-char.inc deleted +0 -15
deleted file mode 100644
index f9fb0f25..00000000
@@ -1,15 +0,0 @@
-SUMMARY = "TI RPMsg Char Utility Library"
-
-LICENSE = "BSD-3-Clause"
-LIC_FILES_CHKSUM = "file://${S}/src/rpmsg_char.c;beginline=1;endline=31;md5=71987db43a2159cff5ea00505c6fce58"
-
-PROTOCOL = "https"
-BRANCH = "master"
-SRC_URI = "git://git.ti.com/git/rpmsg/ti-rpmsg-char.git;protocol=${PROTOCOL};branch=${BRANCH};"
-
-# 0.6.11 release
-SRCREV = "dd4783422bf4fbed1015bfaa51054e40057b4f04"
-
-PV = "0.6.11+git"
-
-COMPATIBLE_MACHINE = "^(k3)$"
meta-ti-bsp/recipes-ti/ti-rpmsg-char/ti-rpmsg-char_git.bb +17 -3
index 50565300..a0043caf 100644
@@ -1,9 +1,23 @@
  SUMMARY = "TI RPMsg Char Utility Library"
 
-require ti-rpmsg-char.inc
+LICENSE = "BSD-3-Clause"
+LIC_FILES_CHKSUM = "file://${S}/src/rpmsg_char.c;beginline=1;endline=31;md5=71987db43a2159cff5ea00505c6fce58"
 
-inherit autotools pkgconfig
+PROTOCOL = "https"
+BRANCH = "master"
+SRC_URI = "git://git.ti.com/git/rpmsg/ti-rpmsg-char.git;protocol=${PROTOCOL};branch=${BRANCH};"
 
+# 0.6.11 release
+SRCREV = "e36103aac7d9f6d64125eb917d3c69022cb86e0b"
+
+PV = "0.6.11+git"
  PR = "r0"
 
-DISABLE_STATIC = ""
+COMPATIBLE_MACHINE = "^(k3)$"
+
+inherit cmake
+
+PACKAGES =+ "${PN}-examples"
+FILES:${PN}-examples += "${bindir}/rpmsg_char_simple"
+FILES:${PN}-examples += "${bindir}/rpmsg_char_benchmark"
+RDEPENDS:${PN}-examples += "${PN}"
Signature · 3 lines
Ryan Eatmon                [email protected]
-----------------------------------------
Texas Instruments, Inc.  -  LCPD  -  MGTS
#4 lore raw

Re: [meta-ti][master/wrynose][PATCH 3/3] ti-rpmsg-char: Update to latest with CMake support

Quoted 10 lines · Ryan Eatmon

Did you do a test build with this?  I'm getting this error for all k3 platforms that depend on ti-rpmsg-char-staticdev:

Solver encountered 1 problem(s):
Problem 1/1:
  - package packagegroup-arago-toolchain-tisdk-target-1.0-r14.7.am62axx_evm requires packagegroup-arago-addons-sdk-target, but none of the providers can be installed
  - conflicting requests
  - nothing provides ti-rpmsg-char-staticdev needed by packagegroup-arago-addons-sdk-target-1.0-r44.0.am62axx_evm

Quoted 5 lines

Either we should remove the dependency or fix the new recipe.

I'm going to keep patch #2 from this series, but #3 needs to either fix the issue, or remove the dependency.

Let's go with removing that dependency, there are very few dependencies on -staticdev packages to begin with, so dropping one of the few remaining ones seems like the right direction here. Patch sent[0]. Once that is in meta-arago it should be safe to take patch #3.

As for your question on build testing, the answer is yes and no. I try to test build what I think are relevant packages, in this case ti-rpmsg-char and some dependent packages (like ti-librpmsg-dma) to verify they still work. Lastly I will usually do a full image build, but rarely a full SDK build (as I don't have a spare super-computer :D), and so in this case there was a miss on my part. I realize now that this would have failed early in the build so simply kicking off an SDK build can find these kinds of issues (even if I don't have the time or compute power to run the whole build).

Andrew

[0] https://lists.yoctoproject.org/g/meta-arago/message/17579

Quoted 139 lines · Andrew Davis
Quoted 136 lines

This project now uses CMake. This allows us to cleanup this recipe in 3 ways:

  - Remove patch for includedir and libdir as CMake handles this correctly
  - Combine in the in the examples recipe, CMake builds the examples along with the library in one step.
  - As there is now only one recipe, merge the .inc into the one .bb file

---
  ...-Remove-use-of-includedir-and-libdir.patch | 44 ------------------- .../ti-rpmsg-char-examples_git.bb             | 13 ------ .../ti-rpmsg-char/ti-rpmsg-char.inc           | 15 ------- .../ti-rpmsg-char/ti-rpmsg-char_git.bb        | 20 +++++++--

  4 files changed, 17 insertions(+), 75 deletions(-)

  delete mode 100644 meta-ti-bsp/recipes-ti/ti-rpmsg-char/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch delete mode 100644 meta-ti-bsp/recipes-ti/ti-rpmsg-char/ti-rpmsg-char-examples_git.bb
  delete mode 100644 meta-ti-bsp/recipes-ti/ti-rpmsg-char/ti-rpmsg-char.inc

meta-ti-bsp/recipes-ti/ti-rpmsg-char/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch deleted +0 -44
deleted file mode 100644
index 3539e8d9..00000000
@@ -1,44 +0,0 @@
-From 1a26cb577ba54dd9214eeb94fed0ce3a0f4603b6 Mon Sep 17 00:00:00 2001
-From: Khem Raj <[email protected]>
-Date: Sat, 24 Oct 2020 23:46:39 -0700
-Subject: [PATCH] examples: Remove use of includedir and libdir
-
-These point to standard include and library paths which already are used
-from sysroot relative paths secondly, they use absolute paths which
-means we are asking to add -I/usr/include which might be ok in a native
-build but not in cross build. This helps mitigate QA errors found with
-OE build system since it finds it adding host include and library search
-paths to linker/compiler commandline
-
-Upstream-Status: Pending
-Signed-off-by: Khem Raj <[email protected]>
----
- examples/Makefile.am | 6 +-----
- 1 file changed, 1 insertion(+), 5 deletions(-)
-
-diff --git a/examples/Makefile.am b/examples/Makefile.am
-index da34204..34ac7a8 100644
---- a/examples/Makefile.am
-+++ b/examples/Makefile.am
-@@ -1,6 +1,4 @@
--INCLUDE = -I${includedir}
-- 
--AM_CFLAGS = -Wall -g -O2 $(INCLUDE)
-+AM_CFLAGS = -Wall -g -O2
-
- bin_PROGRAMS = rpmsg_char_simple rpmsg_char_benchmark
-
-@@ -8,10 +6,8 @@ bin_PROGRAMS = rpmsg_char_simple rpmsg_char_benchmark
- rpmsg_char_simple_SOURCES = rpmsg_char_simple.c
- rpmsg_char_simple_CPPFLAGS = $(AM_CFLAGS)
- rpmsg_char_simple_LDADD = -lpthread -lti_rpmsg_char
--rpmsg_char_simple_LDFLAGS = -L${libdir}
-
- # rpmsg_char_benchmark program
- rpmsg_char_benchmark_SOURCES = rpmsg_char_benchmark.c
- rpmsg_char_benchmark_CPPFLAGS = $(AM_CFLAGS)
- rpmsg_char_benchmark_LDADD = -lpthread -lti_rpmsg_char
--rpmsg_char_benchmark_LDFLAGS = -L${libdir}
---
-2.29.1
-
meta-ti-bsp/recipes-ti/ti-rpmsg-char/ti-rpmsg-char-examples_git.bb deleted +0 -13
deleted file mode 100644
index cbe4d7fd..00000000
@@ -1,13 +0,0 @@
-SUMMARY = "TI RPMsg Char Sample Applications and Tests"
-
-require ti-rpmsg-char.inc
-
-SRC_URI += "file://0001-examples-Remove-use-of-includedir-and-libdir.patch"
-
-DEPENDS = "ti-rpmsg-char"
-
-inherit autotools pkgconfig
-
-EXTRA_OEMAKE = "-C ${B}/examples"
-
-PR = "r0"
meta-ti-bsp/recipes-ti/ti-rpmsg-char/ti-rpmsg-char.inc deleted +0 -15
deleted file mode 100644
index f9fb0f25..00000000
@@ -1,15 +0,0 @@
-SUMMARY = "TI RPMsg Char Utility Library"
-
-LICENSE = "BSD-3-Clause"
-LIC_FILES_CHKSUM = "file://${S}/src/rpmsg_char.c;beginline=1;endline=31;md5=71987db43a2159cff5ea00505c6fce58"
-
-PROTOCOL = "https"
-BRANCH = "master"
-SRC_URI = "git://git.ti.com/git/rpmsg/ti-rpmsg-char.git;protocol=${PROTOCOL};branch=${BRANCH};"
-
-# 0.6.11 release
-SRCREV = "dd4783422bf4fbed1015bfaa51054e40057b4f04"
-
-PV = "0.6.11+git"
-
-COMPATIBLE_MACHINE = "^(k3)$"
meta-ti-bsp/recipes-ti/ti-rpmsg-char/ti-rpmsg-char_git.bb +0 -0
index 50565300..a0043caf 100644
@@ -1,9 +1,23 @@

  SUMMARY = "TI RPMsg Char Utility Library"

meta-ti-bsp/recipes-ti/ti-rpmsg-char/ti-rpmsg-char_git.bb +9 -2
-require ti-rpmsg-char.inc
+LICENSE = "BSD-3-Clause"
+LIC_FILES_CHKSUM = "file://${S}/src/rpmsg_char.c;beginline=1;endline=31;md5=71987db43a2159cff5ea00505c6fce58"
-inherit autotools pkgconfig
+PROTOCOL = "https"
+BRANCH = "master"
+SRC_URI = "git://git.ti.com/git/rpmsg/ti-rpmsg-char.git;protocol=${PROTOCOL};branch=${BRANCH};"
+# 0.6.11 release
+SRCREV = "e36103aac7d9f6d64125eb917d3c69022cb86e0b"
+
+PV = "0.6.11+git"

  PR = "r0"

meta-ti-bsp/recipes-ti/ti-rpmsg-char/ti-rpmsg-char_git.bb +8 -1
-DISABLE_STATIC = ""
+COMPATIBLE_MACHINE = "^(k3)$"
+
+inherit cmake
+
+PACKAGES =+ "${PN}-examples"
+FILES:${PN}-examples += "${bindir}/rpmsg_char_simple"
+FILES:${PN}-examples += "${bindir}/rpmsg_char_benchmark"
+RDEPENDS:${PN}-examples += "${PN}"
#5 lore raw
In reply to Andrew Davis

meta-ti / na / 20260624183253.1130737-1-afd

PRC Results: FAIL

=========================================================
check-yocto-patches: FAIL
=========================================================
Patches
----------------------------------------
WARN - [meta-ti][master/wrynose][PATCH 1/3] ti-librpmsg-dma: Move this recipe to its own directory
WARN: Commit message does not include file/recipe name: ti-librpmsg-dma: Move this recipe to its own directory. (COMMIT-MESSAGE-2)
patch

For details on the above errors/warnings visit: https://lists.yoctoproject.org/g/meta-ti/wiki/40887
WARN - [meta-ti][master/wrynose][PATCH 2/3] ti-rpmsg-char: Move this recipe to its own directory
WARN: Commit message does not include file/recipe name: ti-rpmsg-char: Move this recipe to its own directory. (COMMIT-MESSAGE-2)
patch

For details on the above errors/warnings visit: https://lists.yoctoproject.org/g/meta-ti/wiki/40887
FAIL - [meta-ti][master/wrynose][PATCH 3/3] ti-rpmsg-char: Update to latest with CMake support
ERROR: Missing License-Update for change in LIC_FILES_CHKSUM. (LICENSE-UPDATE-1)
patch

ERROR: Missing License-Update for change in LICENSE. (LICENSE-UPDATE-2)
patch

For details on the above errors/warnings visit: https://lists.yoctoproject.org/g/meta-ti/wiki/40887

#6 lore raw
Quoted 23 lines · PRC Automation

meta-ti / na / 20260624183253.1130737-1-afd

PRC Results: FAIL

=========================================================
check-yocto-patches: FAIL
=========================================================
Patches
----------------------------------------
WARN - [meta-ti][master/wrynose][PATCH 1/3] ti-librpmsg-dma: Move this recipe to its own directory
WARN: Commit message does not include file/recipe name: ti-librpmsg-dma: Move this recipe to its own directory. (COMMIT-MESSAGE-2)
patch

For details on the above errors/warnings visit: https://lists.yoctoproject.org/g/meta-ti/wiki/40887
WARN - [meta-ti][master/wrynose][PATCH 2/3] ti-rpmsg-char: Move this recipe to its own directory
WARN: Commit message does not include file/recipe name: ti-rpmsg-char: Move this recipe to its own directory. (COMMIT-MESSAGE-2)
patch

For details on the above errors/warnings visit: https://lists.yoctoproject.org/g/meta-ti/wiki/40887
FAIL - [meta-ti][master/wrynose][PATCH 3/3] ti-rpmsg-char: Update to latest with CMake support
ERROR: Missing License-Update for change in LIC_FILES_CHKSUM. (LICENSE-UPDATE-1)
patch

Quoted 7 lines

ERROR: Missing License-Update for change in LICENSE. (LICENSE-UPDATE-2)
patch

For details on the above errors/warnings visit: https://lists.yoctoproject.org/g/meta-ti/wiki/40887

You can ignore this. My script does not grok moving licensing settings from a .inc file into a .bb file. It thinks you just removed the line without documenting it. It looks fine.

Signature · 3 lines
Ryan Eatmon                [email protected]
-----------------------------------------
Texas Instruments, Inc.  -  LCPD  -  MGTS