Skip to contentSkip to conversation

mm/damon/sysfs: remove unnecessary variables

PATCH In review Xin Hao 2 participants 8 messages Sep 19, 2022 – Sep 21, 2022

Subsystems (2)
lore
Share & tools
lore

Xin Hao

author
#0 lore raw

PATCH 1/2 mm/damon/sysfs: remove unnecessary variables

Just do a little change here, the 'err' variable really no need to stay here.

---
 mm/damon/sysfs.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
mm/damon/sysfs.c +2 -4
index 0cca1909bf67..b852a75b9f39 100644
@@ -1109,9 +1109,8 @@ static ssize_t start_store(struct kobject *kobj, struct kobj_attribute *attr,
 {
 	struct damon_sysfs_region *region = container_of(kobj,
 			struct damon_sysfs_region, kobj);
-	int err = kstrtoul(buf, 0, &region->start);
 
-	if (err)
+	if (kstrtoul(buf, 0, &region->start))
 		return -EINVAL;
 	return count;
 }
@@ -1130,9 +1129,8 @@ static ssize_t end_store(struct kobject *kobj, struct kobj_attribute *attr,
 {
 	struct damon_sysfs_region *region = container_of(kobj,
 			struct damon_sysfs_region, kobj);
-	int err = kstrtoul(buf, 0, &region->end);
 
-	if (err)
+	if (kstrtoul(buf, 0, &region->end))
 		return -EINVAL;
 	return count;
 }

--
2.31.0

author
#1 lore raw

PATCH 2/2 mm/damon/sysfs: use kzmalloc instead kmalloc to simplify codes

In damon_sysfs_access_pattern_alloc() adn damon_sysfs_attrs_alloc(), we can use kzmalloc to alloc instance of the related structs, This makes the function code much cleaner.

---
 mm/damon/sysfs.c | 15 ++-------------
 1 file changed, 2 insertions(+), 13 deletions(-)
mm/damon/sysfs.c +2 -13
index b852a75b9f39..06154ece7960 100644
@@ -657,13 +657,7 @@ struct damon_sysfs_access_pattern {
 static
 struct damon_sysfs_access_pattern *damon_sysfs_access_pattern_alloc(void)
 {
-	struct damon_sysfs_access_pattern *access_pattern =
-		kmalloc(sizeof(*access_pattern), GFP_KERNEL);
-
-	if (!access_pattern)
-		return NULL;
-	access_pattern->kobj = (struct kobject){};
-	return access_pattern;
+	return kzalloc(sizeof(struct damon_sysfs_access_pattern), GFP_KERNEL);
 }
 
 static int damon_sysfs_access_pattern_add_range_dir(
@@ -1620,12 +1614,7 @@ struct damon_sysfs_attrs {
 
 static struct damon_sysfs_attrs *damon_sysfs_attrs_alloc(void)
 {
-	struct damon_sysfs_attrs *attrs = kmalloc(sizeof(*attrs), GFP_KERNEL);
-
-	if (!attrs)
-		return NULL;
-	attrs->kobj = (struct kobject){};
-	return attrs;
+	return kzalloc(sizeof(struct damon_sysfs_attrs), GFP_KERNEL);
 }
 
 static int damon_sysfs_attrs_add_dirs(struct damon_sysfs_attrs *attrs)
Signature · 1 line
2.31.0
maintainer
#2 lore raw

Re: [PATCH v1 2/2] mm/damon/sysfs: use kzmalloc instead kmalloc to simplify codes

Quoted 3 lines · On Mon, 19 Sep 2022 23:12:01 +0800 Xin Hao <[email protected]> wrote:

In damon_sysfs_access_pattern_alloc() adn damon_sysfs_attrs_alloc(), we can use kzmalloc to alloc instance of the related structs, This makes the function code much cleaner.

This definitely makes the code cleaner, thank you. But, the initial intent of the code is to initialize the fiedls that really need to be initialized at the point, for the efficiency and also for making it clear which field is needed to be initialized to what value here. It's also intended to make readers wonder about where and how the remaining fields are initialized.

So, to my humble eyes, this change looks like making the code a little bit inefficient and unclear, sorry.

Thanks,
SJ

Quoted 41 lines
---
 mm/damon/sysfs.c | 15 ++-------------
 1 file changed, 2 insertions(+), 13 deletions(-)
mm/damon/sysfs.c +2 -13
index b852a75b9f39..06154ece7960 100644
@@ -657,13 +657,7 @@ struct damon_sysfs_access_pattern {
 static
 struct damon_sysfs_access_pattern *damon_sysfs_access_pattern_alloc(void)
 {
-	struct damon_sysfs_access_pattern *access_pattern =
-		kmalloc(sizeof(*access_pattern), GFP_KERNEL);
-
-	if (!access_pattern)
-		return NULL;
-	access_pattern->kobj = (struct kobject){};
-	return access_pattern;
+	return kzalloc(sizeof(struct damon_sysfs_access_pattern), GFP_KERNEL);
 }
 
 static int damon_sysfs_access_pattern_add_range_dir(
@@ -1620,12 +1614,7 @@ struct damon_sysfs_attrs {
 
 static struct damon_sysfs_attrs *damon_sysfs_attrs_alloc(void)
 {
-	struct damon_sysfs_attrs *attrs = kmalloc(sizeof(*attrs), GFP_KERNEL);
-
-	if (!attrs)
-		return NULL;
-	attrs->kobj = (struct kobject){};
-	return attrs;
+	return kzalloc(sizeof(struct damon_sysfs_attrs), GFP_KERNEL);
 }
 
 static int damon_sysfs_attrs_add_dirs(struct damon_sysfs_attrs *attrs)
Signature · 1 line
2.31.0
author
#3 lore raw

Re: [PATCH v1 2/2] mm/damon/sysfs: use kzmalloc instead kmalloc to simplify codes

Quoted 10 lines · SeongJae Park
Quoted 3 lines · On Mon, 19 Sep 2022 23:12:01 +0800 Xin Hao <[email protected]> wrote:

In damon_sysfs_access_pattern_alloc() adn damon_sysfs_attrs_alloc(), we can use kzmalloc to alloc instance of the related structs, This makes the function code much cleaner.

This definitely makes the code cleaner, thank you. But, the initial intent of the code is to initialize the fiedls that really need to be initialized at the point, for the efficiency and also for making it clear which field is needed to be initialized to what value here. It's also intended to make readers wonder about where and how the remaining fields are initialized.

Maybe the other func like damon_sysfs_kdamonds_alloc() also need to do like this, you can see it return directly by

kzalloc.

static struct damon_sysfs_kdamonds *damon_sysfs_kdamonds_alloc(void) {
            return kzalloc(sizeof(struct damon_sysfs_kdamonds), GFP_KERNEL); }

Quoted 47 lines

So, to my humble eyes, this change looks like making the code a little bit inefficient and unclear, sorry.

Thanks,
SJ

Quoted 40 lines
---
  mm/damon/sysfs.c | 15 ++-------------
  1 file changed, 2 insertions(+), 13 deletions(-)
mm/damon/sysfs.c +2 -13
index b852a75b9f39..06154ece7960 100644
@@ -657,13 +657,7 @@ struct damon_sysfs_access_pattern {
  static
  struct damon_sysfs_access_pattern *damon_sysfs_access_pattern_alloc(void)
  {
-	struct damon_sysfs_access_pattern *access_pattern =
-		kmalloc(sizeof(*access_pattern), GFP_KERNEL);
-
-	if (!access_pattern)
-		return NULL;
-	access_pattern->kobj = (struct kobject){};
-	return access_pattern;
+	return kzalloc(sizeof(struct damon_sysfs_access_pattern), GFP_KERNEL);
  }
 
  static int damon_sysfs_access_pattern_add_range_dir(
@@ -1620,12 +1614,7 @@ struct damon_sysfs_attrs {
 
  static struct damon_sysfs_attrs *damon_sysfs_attrs_alloc(void)
  {
-	struct damon_sysfs_attrs *attrs = kmalloc(sizeof(*attrs), GFP_KERNEL);
-
-	if (!attrs)
-		return NULL;
-	attrs->kobj = (struct kobject){};
-	return attrs;
+	return kzalloc(sizeof(struct damon_sysfs_attrs), GFP_KERNEL);
  }
 
  static int damon_sysfs_attrs_add_dirs(struct damon_sysfs_attrs *attrs)
Signature · 1 line
2.31.0
maintainer
#4 lore raw

Re: [PATCH v1 2/2] mm/damon/sysfs: use kzmalloc instead kmalloc to simplify codes

Hi Xin,

Quoted 16 lines · On Tue, 20 Sep 2022 09:58:41 +0800 haoxin <[email protected]> wrote:
Quoted 10 lines · SeongJae Park
Quoted 3 lines · On Mon, 19 Sep 2022 23:12:01 +0800 Xin Hao <[email protected]> wrote:

In damon_sysfs_access_pattern_alloc() adn damon_sysfs_attrs_alloc(), we can use kzmalloc to alloc instance of the related structs, This makes the function code much cleaner.

This definitely makes the code cleaner, thank you. But, the initial intent of the code is to initialize the fiedls that really need to be initialized at the point, for the efficiency and also for making it clear which field is needed to be initialized to what value here. It's also intended to make readers wonder about where and how the remaining fields are initialized.

Maybe the other func like damon_sysfs_kdamonds_alloc() also need to do like this, you can see it return directly by

Quoted 7 lines

kzalloc.

static struct damon_sysfs_kdamonds *damon_sysfs_kdamonds_alloc(void) {
return kzalloc(sizeof(struct damon_sysfs_kdamonds),
GFP_KERNEL);
}

In this case, all the fields of the struct need to be initialized as zero. That's why we use kzalloc() there.

Of course, my opinion is not a static and concrete rule, but changing mind. And obviously everyone makes many mistakes and DAMON code has many rooms for improvement. I really appreciate for your greatful efforts for that. But, at least in this case, I think it doesn't really need the change at the moment, IMHO.

Thanks,
SJ

[...]

author
#5 lore raw

Re: [PATCH v1 2/2] mm/damon/sysfs: use kzmalloc instead kmalloc to simplify codes

Quoted 25 lines · SeongJae Park

Hi Xin,

Quoted 14 lines · On Tue, 20 Sep 2022 09:58:41 +0800 haoxin <[email protected]> wrote:
Quoted 10 lines · SeongJae Park
Quoted 3 lines · On Mon, 19 Sep 2022 23:12:01 +0800 Xin Hao <[email protected]> wrote:

In damon_sysfs_access_pattern_alloc() adn damon_sysfs_attrs_alloc(), we can use kzmalloc to alloc instance of the related structs, This makes the function code much cleaner.

This definitely makes the code cleaner, thank you. But, the initial intent of the code is to initialize the fiedls that really need to be initialized at the point, for the efficiency and also for making it clear which field is needed to be initialized to what value here. It's also intended to make readers wonder about where and how the remaining fields are initialized.

Maybe the other func like damon_sysfs_kdamonds_alloc() also need to do like this, you can see it return directly by

Quoted 7 lines

kzalloc.

static struct damon_sysfs_kdamonds *damon_sysfs_kdamonds_alloc(void) {
return kzalloc(sizeof(struct damon_sysfs_kdamonds),
GFP_KERNEL);
}

Quoted 6 lines

In this case, all the fields of the struct need to be initialized as zero. That's why we use kzalloc() there.

Of course, my opinion is not a static and concrete rule, but changing mind. And obviously everyone makes many mistakes and DAMON code has many rooms for improvement.

Understand your concern,  at least, there is no point in simplifying the code too mush if we are ignoring its readability.

Quoted 9 lines

I really appreciate for your greatful efforts for that. But, at
least in this case, I think it doesn't really need the change at the moment, IMHO.

Thanks,
SJ

[...]

maintainer
#6 lore raw
In reply to Xin Hao
Quoted 13 lines · On Mon, 19 Sep 2022 23:12:00 +0800 Xin Hao <[email protected]> wrote:

Just do a little change here, the 'err' variable really no need to stay here.

---
 mm/damon/sysfs.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
mm/damon/sysfs.c +0 -0
index 0cca1909bf67..b852a75b9f39 100644

mm/damon/sysfs.c static ssize_t start_store(struct kobject *kobj, struct kobj_attribute *attr, · line 1114

Quoted 8 lines
mm/damon/sysfs.c +1 -2
@@ -1109,9 +1109,8 @@ static ssize_t start_store(struct kobject *kobj, struct kobj_attribute *attr,
 {
 	struct damon_sysfs_region *region = container_of(kobj,
 			struct damon_sysfs_region, kobj);
-	int err = kstrtoul(buf, 0, &region->start);
 
-	if (err)
+	if (kstrtoul(buf, 0, &region->start))
 		return -EINVAL;

Good finding. But, I'd like to let the user know why it really fails by giving them the error code that returned by 'kstrtoul()' here. Let's keep the 'err' but return 'err' here.

mm/damon/sysfs.c static ssize_t end_store(struct kobject *kobj, struct kobj_attribute *attr, · line 1134

Quoted 11 lines
mm/damon/sysfs.c +1 -2
 	return count;
 }
@@ -1130,9 +1129,8 @@ static ssize_t end_store(struct kobject *kobj, struct kobj_attribute *attr,
 {
 	struct damon_sysfs_region *region = container_of(kobj,
 			struct damon_sysfs_region, kobj);
-	int err = kstrtoul(buf, 0, &region->end);
 
-	if (err)
+	if (kstrtoul(buf, 0, &region->end))
 		return -EINVAL;

ditto.

Quoted 4 lines
mm/damon/sysfs.c +0 -1
 	return count;
 }
--

2.31.0

Thanks,
SJ

author
#7 lore raw
Quoted 20 lines · SeongJae Park
Quoted 18 lines · On Mon, 19 Sep 2022 23:12:00 +0800 Xin Hao <[email protected]> wrote:

Just do a little change here, the 'err' variable really no need to stay here.

---
  mm/damon/sysfs.c | 6 ++----
  1 file changed, 2 insertions(+), 4 deletions(-)
mm/damon/sysfs.c +0 -1
index 0cca1909bf67..b852a75b9f39 100644
@@ -1109,9 +1109,8 @@ static ssize_t start_store(struct kobject *kobj, struct kobj_attribute *attr,
  {
  	struct damon_sysfs_region *region = container_of(kobj,
  			struct damon_sysfs_region, kobj);
-	int err = kstrtoul(buf, 0, &region->start);
 
Quoted 6 lines

mm/damon/sysfs.c static ssize_t start_store(struct kobject *kobj, struct kobj_attribute *attr, · line 1114

Quoted 3 lines
mm/damon/sysfs.c +1 -1
-	if (err)
+	if (kstrtoul(buf, 0, &region->start))
  		return -EINVAL;

Good finding. But, I'd like to let the user know why it really fails by giving them the error code that returned by 'kstrtoul()' here. Let's keep the 'err' but return 'err' here.

Ok,  it make sense.

Quoted 21 lines

mm/damon/sysfs.c static ssize_t end_store(struct kobject *kobj, struct kobj_attribute *attr, · line 1134

Quoted 12 lines
mm/damon/sysfs.c +1 -2
  	return count;
  }
@@ -1130,9 +1129,8 @@ static ssize_t end_store(struct kobject *kobj, struct kobj_attribute *attr,
  {
  	struct damon_sysfs_region *region = container_of(kobj,
  			struct damon_sysfs_region, kobj);
-	int err = kstrtoul(buf, 0, &region->end);
 
-	if (err)
+	if (kstrtoul(buf, 0, &region->end))
  		return -EINVAL;

ditto.

Quoted 4 lines
mm/damon/sysfs.c +0 -1
  	return count;
  }
--

2.31.0

Thanks,
SJ