Skip to contentSkip to conversation

crypto: arm64/aes-neonbs - add return value of skcipher_walk_done() in __xts_crypt()

PATCH Superseded Yunfeng Ye 3 participants 5 messages Oct 22, 2019 – Nov 1, 2019

Subsystems (2)
lore
Share & tools
lore

Yunfeng Ye

author
#0 lore raw

PATCH v3 1/1 crypto: arm64/aes-neonbs - add return value of skcipher_walk_done() in __xts_crypt()

A warning is found by the static code analysis tool:
"Identical condition 'err', second condition is always false"

Fix this by adding return value of skcipher_walk_done().

Fixes 67cfa5d3b721 ("crypto: arm64/aes-neonbs - implement ciphertext stealing for XTS")

---
v2 -> v3:
- add "Acked-by:"

v1 -> v2:
- update the subject and comment
- add return value of skcipher_walk_done()

 arch/arm64/crypto/aes-neonbs-glue.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/crypto/aes-neonbs-glue.c +1 -1
index ea873b8904c4..e3e27349a9fe 100644
@@ -384,7 +384,7 @@ static int __xts_crypt(struct skcipher_request *req, bool encrypt,
 			goto xts_tail;
 
 		kernel_neon_end();
-		skcipher_walk_done(&walk, nbytes);
+		err = skcipher_walk_done(&walk, nbytes);
 	}
 
 	if (err || likely(!tail))
Signature · 1 line
2.7.4.3
author
#1 lore raw

PATCH v3 1/1 crypto: arm64/aes-neonbs - add return value of skcipher_walk_done() in __xts_crypt()

A warning is found by the static code analysis tool:
"Identical condition 'err', second condition is always false"

Fix this by adding return value of skcipher_walk_done().

Fixes 67cfa5d3b721 ("crypto: arm64/aes-neonbs - implement ciphertext stealing for XTS")

---
v2 -> v3:
- add "Acked-by:"

v1 -> v2:
- update the subject and comment
- add return value of skcipher_walk_done()

 arch/arm64/crypto/aes-neonbs-glue.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/crypto/aes-neonbs-glue.c +1 -1
index ea873b8904c4..e3e27349a9fe 100644
@@ -384,7 +384,7 @@ static int __xts_crypt(struct skcipher_request *req, bool encrypt,
 			goto xts_tail;
 
 		kernel_neon_end();
-		skcipher_walk_done(&walk, nbytes);
+		err = skcipher_walk_done(&walk, nbytes);
 	}
 
 	if (err || likely(!tail))
Signature · 1 line
2.7.4.3
#2 lore raw
Quoted 9 lines · Yunfeng Ye

A warning is found by the static code analysis tool:
"Identical condition 'err', second condition is always false"

Fix this by adding return value of skcipher_walk_done().

Fixes 67cfa5d3b721 ("crypto: arm64/aes-neonbs - implement ciphertext stealing for XTS")

Please don't send the exact same patch twice, and when you feel the need to do so, just ask instead whether your patch was received or not.

I'm sure Herbert will pick it up shortly.

Quoted 28 lines

---
v2 -> v3:
- add "Acked-by:"

v1 -> v2:
- update the subject and comment
- add return value of skcipher_walk_done()

 arch/arm64/crypto/aes-neonbs-glue.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/crypto/aes-neonbs-glue.c +1 -2
index ea873b8904c4..e3e27349a9fe 100644
@@ -384,7 +384,7 @@ static int __xts_crypt(struct skcipher_request *req, bool encrypt,
                        goto xts_tail;
 
                kernel_neon_end();
-               skcipher_walk_done(&walk, nbytes);
+               err = skcipher_walk_done(&walk, nbytes);
        }
 
        if (err || likely(!tail))
--

2.7.4.3

author
#3 lore raw
Quoted 7 lines · Ard Biesheuvel
Quoted 6 lines · Yunfeng Ye

A warning is found by the static code analysis tool:
"Identical condition 'err', second condition is always false"

Fix this by adding return value of skcipher_walk_done().

Quoted 8 lines
Quoted 3 lines
Fixes 67cfa5d3b721 ("crypto: arm64/aes-neonbs - implement ciphertext stealing for XTS")

Please don't send the exact same patch twice, and when you feel the need to do so, just ask instead whether your patch was received or not.

ok, thanks.

Quoted 33 lines

I'm sure Herbert will pick it up shortly.

Quoted 25 lines

---
v2 -> v3:
- add "Acked-by:"

v1 -> v2:
- update the subject and comment
- add return value of skcipher_walk_done()

 arch/arm64/crypto/aes-neonbs-glue.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/crypto/aes-neonbs-glue.c +1 -2
index ea873b8904c4..e3e27349a9fe 100644
@@ -384,7 +384,7 @@ static int __xts_crypt(struct skcipher_request *req, bool encrypt,
                        goto xts_tail;
 
                kernel_neon_end();
-               skcipher_walk_done(&walk, nbytes);
+               err = skcipher_walk_done(&walk, nbytes);
        }
 
        if (err || likely(!tail))
--
Quoted 3 lines

2.7.4.3

.

maintainer
#4 lore raw
In reply to Yunfeng Ye
Quoted 12 lines · Yunfeng Ye

A warning is found by the static code analysis tool:
"Identical condition 'err', second condition is always false"

Fix this by adding return value of skcipher_walk_done().

Fixes 67cfa5d3b721 ("crypto: arm64/aes-neonbs - implement ciphertext stealing for XTS")

---
v2 -> v3:
- add "Acked-by:"

Quoted 6 lines

v1 -> v2:
- update the subject and comment
- add return value of skcipher_walk_done()

 arch/arm64/crypto/aes-neonbs-glue.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch applied. Thanks.

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt