Skip to contentSkip to conversation

ppc: fix up pmac IDE driver for driver core changes

DISCUSSION Benjamin Herrenschmidt 2 participants 2 messages Nov 14, 2004 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 7 lines · Linux Kernel Mailing List

ChangeSet 1.2115, 2004/11/13 12:53:51-08:00, [email protected]

ppc: fix up pmac IDE driver for driver core changes

device power state is in "dev.power.power_state" now, rather than in "dev.power_state".

Hrm... Missed that core change, where does it come from ? doesn't quite go in the direction we have been discussing on linux-pm lately, which is rather to remove this power_state field entirely since it's mostly meaningless at this point (or rather, it's semantics are confuse and the userland interface to it is means pretty much nothing).

While having a power_state field here for internal use of the driver may be "useful" (avoiding the need for drivers to maintain something equivalent locally), it's pretty much impossible to have a generic abstract power_state that has globally defined semantics, at least not with our current scheme.

Ben.

#2 lore raw
Quoted 10 lines · Benjamin Herrenschmidt
Quoted 7 lines · Linux Kernel Mailing List

ChangeSet 1.2115, 2004/11/13 12:53:51-08:00, [email protected]

ppc: fix up pmac IDE driver for driver core changes

device power state is in "dev.power.power_state" now, rather than in "dev.power_state".

Hrm... Missed that core change, where does it come from ?

It's the core "struct device" shrinkage patch:

[email protected], 2004-11-12 11:41:25-08:00, [email protected]
[PATCH] driver core: shrink struct device a bit

This patch removes two fields from "struct device" that are duplicated in "struct dev_pm_info": power_state (which should probably vanish) and "saved_state". There were only two "real" uses of saved_state; both are now switched over to use dev_pm_info.

so I think the people involved agree with you on moving it ever outwards..

Linus