Skip to contentSkip to conversation

x86_64: assign_irq_vector should not be marked __init

PATCH In review Alexander Nyberg 2 participants 2 messages Nov 14, 2004

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86_64: assign_irq_vector should not be marked __init

Hej Linus

This box crashed at startup today and I noticed that some modules will need to have assign_irq_vector() available although it is marked as __init. Looks like it was done for i386 in but not x86_64...

Signed off by: Alexander Nyberg <[email protected]>

===== arch/x86_64/kernel/io_apic.c 1.38 vs edited =====

arch/x86_64/kernel/io_apic.c +0 -4
@@ -654,11 +654,7 @@
 /* irq_vectors is indexed by the sum of all RTEs in all I/O APICs. */
 u8 irq_vector[NR_IRQ_VECTORS] = { FIRST_DEVICE_VECTOR , 0 };
 
-#ifdef CONFIG_PCI_MSI
 int assign_irq_vector(int irq)
-#else
-int __init assign_irq_vector(int irq)
-#endif
 {
 	static int current_vector = FIRST_DEVICE_VECTOR, offset = 0;
 
#1 lore raw
Quoted 5 lines · Alexander Nyberg

Hej Linus

This box crashed at startup today and I noticed that some modules will need to have assign_irq_vector() available although it is marked as __init. Looks like it was done for i386 in but not x86_64...

Thanks added to my tree.

-Andi