Skip to contentSkip to conversation

sysrq and 8250 serial console 2.6.10-rc1-mm3

PATCH In review Steven Rostedt 2 participants 2 messages Nov 16, 2004

lore
Share & tools
lore

Steven Rostedt

author
#0 lore raw

PATCH 1/1 sysrq and 8250 serial console 2.6.10-rc1-mm3

I don't know if anyone else caught this, but the sysrq doesn't work with the serial console for 8250. This is a simple patch, the serial_8250.h also calls serial_core.h before SUPPORT_SYSRQ is defined. And thus the inlines in serial core do not support sysrq.

Here's the fix, I was even more paranoid and put the define before all serial headers.

drivers/serial/8250.c 2004-11-16 14:07:47.000000000 -0500 renamed from drivers/serial/8250.c_orig 2004-11-16 14:07:08.000000000 -0500 +5 -4
@@ -27,6 +27,11 @@
 #include <linux/init.h>
 #include <linux/console.h>
 #include <linux/sysrq.h>
+
+#if defined(CONFIG_SERIAL_8250_CONSOLE) && defined(CONFIG_MAGIC_SYSRQ)
+#define SUPPORT_SYSRQ
+#endif
+
 #include <linux/serial_reg.h>
 #include <linux/serial.h>
 #include <linux/serial_8250.h>

@@ -37,10 +42,6 @@
 #include <asm/io.h>
 #include <asm/irq.h>
 
-#if defined(CONFIG_SERIAL_8250_CONSOLE) && defined(CONFIG_MAGIC_SYSRQ)
-#define SUPPORT_SYSRQ
-#endif
-
 #include <linux/serial_core.h>
 #include "8250.h"
Signature · 3 lines
Steven Rostedt
Senior Engineer
Kihon Technologies
#1 lore raw
Quoted 4 lines · Steven Rostedt

I don't know if anyone else caught this, but the sysrq doesn't work with the serial console for 8250. This is a simple patch, the serial_8250.h also calls serial_core.h before SUPPORT_SYSRQ is defined. And thus the inlines in serial core do not support sysrq.

Already fixed in 2.6.10-rc2.

Thanks anyway.

Signature · 4 lines
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 PCMCIA      - http://pcmcia.arm.linux.org.uk/
                 2.6 Serial core