Skip to contentSkip to conversation

pcnet32: 79c976 with fiber optic

PATCH Guido Guenther 2 participants 3 messages Nov 24, 2004 – Nov 26, 2004

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Hi,
I have a Allied Telesys using a 79c976 with a fibre optic connectior. pcnet32 detects the card fine but looses the link when I ifup the interface. If I use:

drivers/net/pcnet32.c renamed from linux-2.6.9/drivers/net/pcnet32.c +3 -0
@@ -1425,6 +1425,8 @@
 	val |= 0x10;
     lp->a.write_csr (ioaddr, 124, val);
 
+    printk(KERN_DEBUG "pcnet32: Skipping AMD workaround\n");
+#if 0
     /* 24 Jun 2004 according AMD, in order to change the PHY,
      * DANAS (or DISPM for 79C976) must be set; then select the speed,
      * duplex, and/or enable auto negotiation, and clear DANAS */
@@ -1446,6 +1448,7 @@
 	    lp->a.write_bcr(ioaddr, 32, val);
 	}
     }
+#endif
 
 #ifdef DO_DXSUFLO
     if (lp->dxsuflo) { /* Disable transmit stop on und

it works fine. Any idea what exactly causes the problem? Cheers,
-- Guido

#1 lore raw
Quoted 1 line · Guido Guenther

it works fine. Any idea what exactly causes the problem?

I've no idea whether the workaround is simply not supposed to be used on fibre devices (I'm suprised the driver works on fibre full stop 8)). Its certainly possible to do a cleaner change though even if nobody can work out why.

Use lspci -v to find the subvendor/subdevice ID for the particular board assembly and then skip the fixup for that device alone. That should let you produce a diff that is safely mergable

#2 lore raw
Quoted 4 lines · Alan Cox

Use lspci -v to find the subvendor/subdevice ID for the particular board assembly and then skip the fixup for that device alone. That should let you produce a diff that is safely mergable

You mean like:

Skip PHY selection on Allied Telesyn 2701FX, it looses the link otherwise.

include/linux/pci_ids.h renamed from linux-2.6.9/include/linux/pci_ids.h +4 -0
@@ -1622,6 +1622,10 @@
 #define PCI_DEVICE_ID_OPTIBASE_VPLEXCC	0x2120
 #define PCI_DEVICE_ID_OPTIBASE_VQUEST	0x2130
 
+/* Allied Telesyn */
+#define PCI_VENDOR_ID_AT    		0x1259
+#define PCI_SUBDEVICE_ID_AT_2701FX	0x2703
+
 #define PCI_VENDOR_ID_ESS		0x125d
 #define PCI_DEVICE_ID_ESS_ESS1968	0x1968
 #define PCI_DEVICE_ID_ESS_AUDIOPCI	0x1969
drivers/net/pcnet32.c renamed from linux-2.6.9/drivers/net/pcnet32.c +25 -19

51 lines not on this page · raw message

Cheers,
-- Guido