hid-core: Configurable USB HID Mouse Interrupt Polling Interval

Hi!

This patch adds the option "USB HID Mouse Interrupt Polling Interval" to drivers/usb/input/Kconfig, and a few lines of code to drivers/usb/input/hid-core.c, to make the config option function.

It allows people to change the interval, at which their USB HID mice are polled at. This is extremely useful for people who require high precision, or just likes the feeling of a very precise mouse. ;)

As the Kconfig help implies, setting a lower polling interval is known to work on several mice produced by Logitech and Microsoft. I only have a Logitech MX500 to test it on. My results have been positive, and so have many other people's.

Mikkel Krautz

Signed-off-by Mikkel Krautz <[email protected]>

---

drivers/usb/input/Kconfig +0 -0

@@ -24,6 +24,38 @@
 	  To compile this driver as a module, choose M here: the
 	  module will be called usbhid.

Hi!

This patch adds the option "USB HID Mouse Interrupt Polling Interval" to drivers/usb/input/Kconfig, and a few lines of code to drivers/usb/input/hid-core.c, to make the config option function.

It allows people to change the interval, at which their USB HID mice are polled at. This is extremely useful for people who require high precision, or just likes the feeling of a very precise mouse. ;)

As the Kconfig help implies, setting a lower polling interval is known to work on several mice produced by Logitech and Microsoft. I only have a Logitech MX500 to test it on. My results have been positive, and so have many other people's.

Mikkel, could you please turn off the word wrap in your MTA's composer and repost this? I'd like to try it.

On Fri, 17 Dec 2004 19:43:23 -0500, Gene Heskett

Quoted 2 lines · <[email protected]> wrote:

Mikkel, could you please turn off the word wrap in your MTA's composer and repost this? I'd like to try it.

Sorry about that.
Here's a repost. Now even with a diffstat:

Quoted 6 lines · Mikkel Krautz

Hi!

This patch adds the option "USB HID Mouse Interrupt Polling Interval" to drivers/usb/input/Kconfig, and a few lines of code to drivers/usb/input/hid-core.c, to make the config option function.

Quoted 10 lines

It allows people to change the interval, at which their USB HID mice are polled at. This is extremely useful for people who require high precision, or just likes the feeling of a very precise mouse. ;)

As the Kconfig help implies, setting a lower polling interval is known to work on several mice produced by Logitech and Microsoft. I only have a Logitech MX500 to test it on. My results have been positive, and so have many other people's.

Why not just make it a sysfs file, so you can tune it per device? That way you also don't have to make it a Kconfig option.

thanks,

greg k-h

Quoted 15 lines · Greg KH

Quoted 13 lines · Mikkel Krautz

This patch adds the option "USB HID Mouse Interrupt Polling Interval" to drivers/usb/input/Kconfig, and a few lines of code to drivers/usb/input/hid-core.c, to make the config option function.

It allows people to change the interval, at which their USB HID mice are polled at. This is extremely useful for people who require high precision, or just likes the feeling of a very precise mouse. ;)

As the Kconfig help implies, setting a lower polling interval is known to work on several mice produced by Logitech and Microsoft. I only have a Logitech MX500 to test it on. My results have been positive, and so have many other people's.

Quoted 3 lines

Why not just make it a sysfs file, so you can tune it per device? That way you also don't have to make it a Kconfig option.

I'm not too familiar with sysfs, so I really don't know.

The interval is set when the device is configured - that's only once.

Therefore I think a static value in Kconfig is fine. Wouldn't a sysfs entry be a little overkill for this?

What about makeing it a module paramater then, that is exported to sysfs? That makes it easier to adjust on the fly (before the mouse is inserted), and doesn't require the kernel to be rebuilt.

Hi Mikkel,

Review line 1919

Quoted 5 lines

(quoted diff) +1 -0

@@ -1910,6 +1916,7 @@
 
 module_init(hid_init);
 module_exit(hid_exit);
+module_param(hid_mouse_polling_interval, int, 644);

I think the use of module_param_named() makes more sense here.

Regards

Marcel

Quoted 3 lines · Greg KH

What about makeing it a module paramater then, that is exported to sysfs? That makes it easier to adjust on the fly (before the mouse is inserted), and doesn't require the kernel to be rebuilt.

I really like the idea. I'm start to think that this is the ideal way to accomplish this.

Here's a new patch. Let's hope it doesn't wrap!

module_init(hid_init); module_exit(hid_exit); +module_param(hid_mouse_polling_interval, int, 644);

Quoted 9 lines · Mikkel Krautz

Quoted 3 lines · Greg KH

What about makeing it a module paramater then, that is exported to sysfs? That makes it easier to adjust on the fly (before the mouse is inserted), and doesn't require the kernel to be rebuilt.

I really like the idea. I'm start to think that this is the ideal way to accomplish this.

Here's a new patch. Let's hope it doesn't wrap!

It was eaten :(

Quoted 3 lines

module_init(hid_init); module_exit(hid_exit); +module_param(hid_mouse_polling_interval, int, 644);

0644, or use the proper #defines instead.

thanks,

greg k-h

Quoted 17 lines · Greg KH

Quoted 9 lines · Mikkel Krautz

Quoted 3 lines · Greg KH

What about makeing it a module paramater then, that is exported to sysfs? That makes it easier to adjust on the fly (before the mouse is inserted), and doesn't require the kernel to be rebuilt.

I really like the idea. I'm start to think that this is the ideal way to accomplish this.

Here's a new patch. Let's hope it doesn't wrap!

It was eaten :(

Quoted 3 lines

module_init(hid_init); module_exit(hid_exit); +module_param(hid_mouse_polling_interval, int, 644);

Quoted 6 lines

0644, or use the proper #defines instead.

thanks,

greg k-h

Here's an updated version, with your and Marcel's suggestions:

Signed-off-by Mikkel Krautz <[email protected]>

---

 hid-core.c |    9 ++++++++-
 1 files changed, 8 insertions(+), 1 deletion(-)

drviers/usb/input/hid-core.c renamed from drivers/usb/input/hid-core.c +8 -1

@@ -37,11 +37,12 @@
  * Version Information
  */
 
-#define DRIVER_VERSION "v2.0"
+#define DRIVER_VERSION "v2.01"
 #define DRIVER_AUTHOR "Andreas Gal, Vojtech Pavlik"
 #define DRIVER_DESC "USB HID core driver"
 #define DRIVER_LICENSE "GPL"
 
+static unsigned int hid_mousepoll_interval;
 static char *hid_types[] = {"Device", "Pointer", "Mouse", "Device", "Joystick",
 				"Gamepad", "Keyboard", "Keypad", "Multi-Axis Controller"};
 

@@ -1663,6 +1664,11 @@
 		if ((endpoint->bmAttributes & 3) != 3)		/* Not an interrupt endpoint */
 			continue;
 
+		/* Change the polling interval of mice. */
+		if (hid->collection->usage == HID_GD_MOUSE
+				&& hid_mousepoll_interval > 0)
+			endpoint->bInterval = hid_mousepoll_interval;
+		
 		/* handle potential highspeed HID correctly */
 		interval = endpoint->bInterval;
 		if (dev->speed == USB_SPEED_HIGH)

@@ -1910,6 +1916,7 @@
 
 module_init(hid_init);
 module_exit(hid_exit);
+module_param_named(mousepoll, hid_mousepoll_interval, uint, 0644);
 
 MODULE_AUTHOR(DRIVER_AUTHOR);
 MODULE_DESCRIPTION(DRIVER_DESC);

Quoted 18 lines · Mikkel Krautz

Quoted 17 lines · Greg KH

Quoted 9 lines · Mikkel Krautz

Quoted 3 lines · Greg KH

What about makeing it a module paramater then, that is exported to sysfs? That makes it easier to adjust on the fly (before the mouse is inserted), and doesn't require the kernel to be rebuilt.

I really like the idea. I'm start to think that this is the ideal way to accomplish this.

Here's a new patch. Let's hope it doesn't wrap!

It was eaten :(

Quoted 3 lines

module_init(hid_init); module_exit(hid_exit); +module_param(hid_mouse_polling_interval, int, 644);

Quoted 8 lines

Quoted 6 lines

0644, or use the proper #defines instead.

thanks,

greg k-h

Here's an updated version, with your and Marcel's suggestions:

Some more suggestions:

A MODULE_PARM_DESC() would be good, as well as a patch to kernel-parameters.txt.

Also, it'd be better instead of changing the bInterval in the endpoint descriptor to change the "interval" variable. This way one wouldn't need to think about whether the device is Full-speed or High-speed when setting the parameter. Also the endpoint descriptor should be considered read only.

Quoted 38 lines

Signed-off-by Mikkel Krautz <[email protected]>

---

 hid-core.c |    9 ++++++++-
 1 files changed, 8 insertions(+), 1 deletion(-)

drviers/usb/input/hid-core.c renamed from drivers/usb/input/hid-core.c +7 -1

@@ -37,11 +37,12 @@
  * Version Information
  */
 
-#define DRIVER_VERSION "v2.0"
+#define DRIVER_VERSION "v2.01"
 #define DRIVER_AUTHOR "Andreas Gal, Vojtech Pavlik"
 #define DRIVER_DESC "USB HID core driver"
 #define DRIVER_LICENSE "GPL"
 
+static unsigned int hid_mousepoll_interval;
 static char *hid_types[] = {"Device", "Pointer", "Mouse", "Device", "Joystick",
                              "Gamepad", "Keyboard", "Keypad", "Multi-Axis Controller"};
 

@@ -1663,6 +1664,11 @@
              if ((endpoint->bmAttributes & 3) != 3)          /* Not an interrupt endpoint */
                      continue;
 
+             /* Change the polling interval of mice. */
+             if (hid->collection->usage == HID_GD_MOUSE
+                             && hid_mousepoll_interval > 0)
+                     endpoint->bInterval = hid_mousepoll_interval;
+
              /* handle potential highspeed HID correctly */
              interval = endpoint->bInterval;
              if (dev->speed == USB_SPEED_HIGH)

drviers/usb/input/hid-core.c line 1922

Quoted 7 lines

drviers/usb/input/hid-core.c renamed from drivers/usb/input/hid-core.c +1 -0

@@ -1910,6 +1916,7 @@
 
 module_init(hid_init);
 module_exit(hid_exit);
+module_param_named(mousepoll, hid_mousepoll_interval, uint, 0644);
 
 MODULE_AUTHOR(DRIVER_AUTHOR);
 MODULE_DESCRIPTION(DRIVER_DESC);

--
Vojtech Pavlik
SuSE Labs, SuSE CR