gfs2: Add a few missing newlines in messages

PATCH New Andreas Gruenbacher 2 participants 2 messages Jan 29, 2018 – Jan 30, 2018 GFS2 file system

lore

Share & tools

lore

Andreas Gruenbacher

author maintainer

2018-01-29 18:12 UTC #0 lore raw

PATCH 1/1 gfs2: Add a few missing newlines in messages

Some of the info, warning, and error messages are missing their trailing newline.

Signed-off-by Andreas Gruenbacher <[email protected]>

---
 fs/gfs2/lock_dlm.c | 4 ++--
 fs/gfs2/rgrp.c     | 2 +-
 fs/gfs2/sys.c      | 4 ++--
 3 files changed, 5 insertions(+), 5 deletions(-)

fs/gfs2/lock_dlm.c +2 -2

index 65f33a0ac190..006c6164f759 100644
@@ -1091,7 +1091,7 @@ static void gdlm_recover_slot(void *arg, struct dlm_slot *slot)
 
 	spin_lock(&ls->ls_recover_spin);
 	if (ls->ls_recover_size < jid + 1) {
-		fs_err(sdp, "recover_slot jid %d gen %u short size %d",
+		fs_err(sdp, "recover_slot jid %d gen %u short size %d\n",
 		       jid, ls->ls_recover_block, ls->ls_recover_size);
 		spin_unlock(&ls->ls_recover_spin);
 		return;

@@ -1153,7 +1153,7 @@ static void gdlm_recovery_result(struct gfs2_sbd *sdp, unsigned int jid,
 		return;
 	}
 	if (ls->ls_recover_size < jid + 1) {
-		fs_err(sdp, "recovery_result jid %d short size %d",
+		fs_err(sdp, "recovery_result jid %d short size %d\n",
 		       jid, ls->ls_recover_size);
 		spin_unlock(&ls->ls_recover_spin);
 		return;

fs/gfs2/rgrp.c +1 -1

index 078b002e0a68..8b683917a27e 100644
@@ -1339,7 +1339,7 @@ int gfs2_rgrp_send_discards(struct gfs2_sbd *sdp, u64 offset,
 
 fail:
 	if (sdp->sd_args.ar_discard)
-		fs_warn(sdp, "error %d on discard request, turning discards off for this filesystem", rv);
+		fs_warn(sdp, "error %d on discard request, turning discards off for this filesystem\n", rv);
 	sdp->sd_args.ar_discard = 0;
 	return -EIO;
 }

fs/gfs2/sys.c +2 -2

index 9eb9d0a1abd9..c191fa58a1df 100644
@@ -112,7 +112,7 @@ static ssize_t freeze_store(struct gfs2_sbd *sdp, const char *buf, size_t len)
 	}
 
 	if (error) {
-		fs_warn(sdp, "freeze %d error %d", n, error);
+		fs_warn(sdp, "freeze %d error %d\n", n, error);
 		return error;
 	}

@@ -679,7 +679,7 @@ int gfs2_sys_fs_add(struct gfs2_sbd *sdp)
 	sysfs_remove_group(&sdp->sd_kobj, &tune_group);
 fail_reg:
 	free_percpu(sdp->sd_lkstats);
-	fs_err(sdp, "error %d adding sysfs files", error);
+	fs_err(sdp, "error %d adding sysfs files\n", error);
 	if (sysfs_frees_sdp)
 		kobject_put(&sdp->sd_kobj);
 	else

Signature · 1 line

2.14.3

Bob Peterson

2018-01-30 17:36 UTC #1 lore raw

PATCH 1/1 gfs2: Add a few missing newlines in messages

----- Original Message -----

| Some of the info, warning, and error messages are missing their trailing
| newline.
| 
| Signed-off-by: Andreas Gruenbacher <[email protected]>
| ---
|  fs/gfs2/lock_dlm.c | 4 ++--
|  fs/gfs2/rgrp.c     | 2 +-
|  fs/gfs2/sys.c      | 4 ++--
|  3 files changed, 5 insertions(+), 5 deletions(-)

Hi,

Thanks. This is now pushed to the for-next branch of the linux-gfs2 tree:

https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git/commit/fs/gfs2?h=for-next&id=af38816e4801d2868258085831172a003d1634ff

Regards,

Bob Peterson
Red Hat File Systems