Skip to contentSkip to conversation

Trusted Path Execution LSM 0.2 (20050108)

PATCH Steve G 3 participants 3 messages Jan 11, 2005

lore
Share & tools
lore

Steve G

author
#0 lore raw

This patch leaks memory in the error paths. For example:

+static ssize_t trustedlistadd_read_file(struct tpe_list *list, char *buf) +{
<snip>
+ char *buffer = kmalloc(400, GFP_KERNEL);
+
+ user = (char *)__get_free_page(GFP_KERNEL);
+ if (!user)
+ return -ENOMEM;

There's several of these.

-Steve Grubb

__________________________________
Do you Yahoo!?
The all-new My Yahoo! - What will yours do?
http://my.yahoo.com

#1 lore raw

Review

Quoted 10 lines · * Steve G ([email protected]) wrote:

This patch leaks memory in the error paths. For example:

(quoted diff) +7 -0
+static ssize_t trustedlistadd_read_file(struct tpe_list *list, char *buf)
+{
<snip>
+ char *buffer = kmalloc(400, GFP_KERNEL);
+
+ user = (char *)__get_free_page(GFP_KERNEL);
+ if (!user)
+ return -ENOMEM;

Helps to inform the author ;-)

-chris

#2 lore raw

Hi,

Quoted 13 lines · Chris Wright

Review

Quoted 10 lines · * Steve G ([email protected]) wrote:

This patch leaks memory in the error paths. For example:

(quoted diff) +7 -0
+static ssize_t trustedlistadd_read_file(struct tpe_list *list, char *buf)
+{
<snip>
+ char *buffer = kmalloc(400, GFP_KERNEL);
+
+ user = (char *)__get_free_page(GFP_KERNEL);
+ if (!user)
+ return -ENOMEM;

Helps to inform the author ;-)

It's fixed now and i will update the patches ASAP.

Next time it would be better to CC me directly, but anyway, thanks for reporting this, as much as you mess it up, it's as much as i will work to make it better ;).

Cheers,

Signature · 2 lines
Lorenzo Hernández García-Hierro <[email protected]> [1024D/6F2B2DEC]
[2048g/9AE91A22] Hardened Debian head developer & project manager