add support for sysdev class attributes
Hi Greg,
Would you consider a patch such as the one below which adds support for sysdev class attributes? I would like to have this for doing cpu add and remove on ppc64 (for "probing" and removing cpus on partitioned machines). I think the memory hotplug people probably will want it, too, eventually.
---
drivers/base/sys.c renamed from drivers/base/sys.c~sysdev_class-attr-support +54 -0
@@ -76,6 +76,41 @@ void sysdev_remove_file(struct sys_devicEXPORT_SYMBOL_GPL (sysdev_create_file);EXPORT_SYMBOL_GPL (sysdev_remove_file); +#define to_sysdev_class (k) container_of(to_kset(k), struct sysdev_class, kset) +#define to_sysdev_class_attr (a) container_of(a, struct sysdev_class_attribute, attr) + +static ssize_t +sysdev_class_show (struct kobject * kobj,struct attribute * attr,char * buffer) +{ +struct sysdev_class * sysdev_class =to_sysdev_class (kobj); +struct sysdev_class_attribute * sysdev_class_attr =to_sysdev_class_attr (attr); + +if (sysdev_class_attr->show) +return sysdev_class_attr->show (sysdev_class, buffer); +return 0 ; +} + +static ssize_t +sysdev_class_store (struct kobject * kobj,struct attribute * attr, +const char * buffer,size_t count) +{ +struct sysdev_class * sysdev_class =to_sysdev_class (kobj); +struct sysdev_class_attribute * sysdev_class_attr =to_sysdev_class_attr (attr); + +if (sysdev_class_attr->store) +return sysdev_class_attr->store (sysdev_class, buffer, count); +return 0 ; +} + +static struct sysfs_ops sysdev_class_sysfs_ops = { + .show = sysdev_class_show, + .store = sysdev_class_store, +}; + +static struct kobj_type sysdev_class_ktype = { + .sysfs_ops = &sysdev_class_sysfs_ops, +}; +/* * declare system_subsys */
@@ -88,6 +123,12 @@ int sysdev_class_register(struct sysdev_INIT_LIST_HEAD (&cls->drivers); cls->kset.subsys = &system_subsys;kset_set_kset_s (cls, system_subsys); + +/* I'm not going to claim to understand this; see +* fs/sysfs/file::check_perm for how sysfs_ops are selected +*/ + cls->kset.kobj.ktype = &sysdev_class_ktype; +return kset_register (&cls->kset); }
@@ -98,6 +139,19 @@ void sysdev_class_unregister(struct sysdkset_unregister (&cls->kset); } +int sysdev_class_create_file (struct sysdev_class *s,struct sysdev_class_attribute *a) +{ +return sysfs_create_file (&s->kset.kobj, &a->attr); +} + + +void sysdev_class_remove_file (struct sysdev_class *s,struct sysdev_class_attribute *a) +{ +sysfs_remove_file (&s->kset.kobj, &a->attr); +} + +EXPORT_SYMBOL_GPL (sysdev_class_create_file); +EXPORT_SYMBOL_GPL (sysdev_class_remove_file);EXPORT_SYMBOL_GPL (sysdev_class_register);EXPORT_SYMBOL_GPL (sysdev_class_unregister);
include/linux/sysdev.h renamed from include/linux/sysdev.h~sysdev_class-attr-support +15 -0
@@ -40,6 +40,21 @@ struct sysdev_class {extern int sysdev_class_register (struct sysdev_class *);extern void sysdev_class_unregister (struct sysdev_class *); +struct sysdev_class_attribute { +struct attribute attr; +ssize_t (*show)(struct sysdev_class *,char *); +ssize_t (*store)(struct sysdev_class *,const char *,size_t ); +}; + +#define SYSDEV_CLASS_ATTR (_name,_mode,_show,_store) \ +struct sysdev_class_attribute attr_##_name = { \ + .attr = {.name = __stringify(_name), .mode = _mode }, \ + .show = _show, \ + .store = _store, \ +}; + +extern int sysdev_class_create_file (struct sysdev_class *,struct sysdev_class_attribute *); +extern void sysdev_class_remove_file (struct sysdev_class *,struct sysdev_class_attribute *);/** * Auxillary system device drivers.
_
drivers/base/sys.c int sysdev_class_register(struct sysdev_ · line 131
Quoted 10 lines · Nathan Lynch
drivers/base/sys.c renamed from drivers/base/sys.c~sysdev_class-attr-support +6
-0@@ -88,6 +123,12 @@ int sysdev_class_register(struct sysdev_INIT_LIST_HEAD (&cls->drivers); cls->kset.subsys = &system_subsys;kset_set_kset_s (cls, system_subsys); + +/* I'm not going to claim to understand this; see +* fs/sysfs/file::check_perm for how sysfs_ops are selected +*/ + cls->kset.kobj.ktype = &sysdev_class_ktype; +
I think you need to understand this, and then submit a patch without such a comment :)
And probably without such code, as I don't think you need to do that.
thanks,
greg k-h
Quoted 15 lines · Greg KH
drivers/base/sys.c int sysdev_class_register(struct sysdev_ · line 131
Quoted 10 lines · Nathan Lynch
drivers/base/sys.c renamed from drivers/base/sys.c~sysdev_class-attr-support +6
-0@@ -88,6 +123,12 @@ int sysdev_class_register(struct sysdev_INIT_LIST_HEAD (&cls->drivers); cls->kset.subsys = &system_subsys;kset_set_kset_s (cls, system_subsys); + +/* I'm not going to claim to understand this; see +* fs/sysfs/file::check_perm for how sysfs_ops are selected +*/ + cls->kset.kobj.ktype = &sysdev_class_ktype; +I think you need to understand this, and then submit a patch without such a comment :)
Quoted 1 line
And probably without such code, as I don't think you need to do that.
Sure, now I'm not sure how I convinced myself that bit was needed. Things work fine without it.
Before I repatch, does sysdev_class_ktype need a release function?
Thanks,
Nathan
Quoted 16 lines · Nathan Lynch
Quoted 15 lines · Greg KH
drivers/base/sys.c int sysdev_class_register(struct sysdev_ · line 131
Quoted 10 lines · Nathan Lynch
drivers/base/sys.c renamed from drivers/base/sys.c~sysdev_class-attr-support +6
-0@@ -88,6 +123,12 @@ int sysdev_class_register(struct sysdev_INIT_LIST_HEAD (&cls->drivers); cls->kset.subsys = &system_subsys;kset_set_kset_s (cls, system_subsys); + +/* I'm not going to claim to understand this; see +* fs/sysfs/file::check_perm for how sysfs_ops are selected +*/ + cls->kset.kobj.ktype = &sysdev_class_ktype; +I think you need to understand this, and then submit a patch without such a comment :)
Quoted 6 lines
Quoted 1 line
And probably without such code, as I don't think you need to do that.
Sure, now I'm not sure how I convinced myself that bit was needed. Things work fine without it.
Before I repatch, does
sysdev_class_ktypeneed a release function?
Why would it not?
thanks,
greg k-h
Quoted 17 lines · Greg KH
Quoted 16 lines · Nathan Lynch
Quoted 15 lines · Greg KH
Review int sysdev_class_register(struct sysdev_ · line 131
Quoted 10 lines · Nathan Lynch
(quoted diff) +6
-0@@ -88,6 +123,12 @@ int sysdev_class_register(struct sysdev_ INIT_LIST_HEAD(&cls->drivers); cls->kset.subsys = &system_subsys; kset_set_kset_s(cls, system_subsys); + + /* I'm not going to claim to understand this; see + * fs/sysfs/file::check_perm for how sysfs_ops are selected + */ + cls->kset.kobj.ktype = &sysdev_class_ktype; +I think you need to understand this, and then submit a patch without such a comment :)
Quoted 4 lines
Quoted 4 lines
Quoted 1 line
And probably without such code, as I don't think you need to do that.
Sure, now I'm not sure how I convinced myself that bit was needed. Things work fine without it.
OK I'm an idiot, because things certainly do not work without somehow associating the new sysfs_ops with the sysdev_class being registered. Otherwise, sysfs winds up using sysdev_store/sysdev_show, since ktype_sysdev is the kobj_type for the "system" subsystem.
Since sysdev_register is explicitly associating ktype_sysdev with the sysdev being registered anyway, I think it should be fine to define system_subsys with sysdev_class_ktype for its kobj_type. What do you say?
Quoted 3 lines
Quoted 1 line
Before I repatch, does
sysdev_class_ktypeneed a release function?Why would it not?
I'm not sure what it would actually do... it seems that we would need it if sysdevs were dynamically allocated, but they're not. Not that they couldn't be, but that's existing practice afaict. In any case, it's a matter for a separate patch, I would say.
Updated patch below:
Add support for system device class attributes. I would like to have this for doing cpu add and remove on ppc64, and I think the memory hotplug people probably will want it, too.
o Add the necessary show and store methods and related data structures.
o Add sysdev_create_file and sysdev_remove_file.
o Make the "system" subsys' ktype ktype_sysdev_class instead of ktype_sysdev, which should be used only for sysdevs.
---
drivers/base/sys.c renamed from drivers/base/sys.c~sysdev_class-attr-support +49 -1
@@ -76,10 +76,45 @@ void sysdev_remove_file(struct sys_devicEXPORT_SYMBOL_GPL (sysdev_create_file);EXPORT_SYMBOL_GPL (sysdev_remove_file); +#define to_sysdev_class (k) container_of(to_kset(k), struct sysdev_class, kset) +#define to_sysdev_class_attr (a) container_of(a, struct sysdev_class_attribute, attr) + +static ssize_t +sysdev_class_show (struct kobject * kobj,struct attribute * attr,char * buffer) +{ +struct sysdev_class * sysdev_class =to_sysdev_class (kobj); +struct sysdev_class_attribute * sysdev_class_attr =to_sysdev_class_attr (attr); + +if (sysdev_class_attr->show) +return sysdev_class_attr->show (sysdev_class, buffer); +return 0 ; +} + +static ssize_t +sysdev_class_store (struct kobject * kobj,struct attribute * attr, +const char * buffer,size_t count) +{ +struct sysdev_class * sysdev_class =to_sysdev_class (kobj); +struct sysdev_class_attribute * sysdev_class_attr =to_sysdev_class_attr (attr); + +if (sysdev_class_attr->store) +return sysdev_class_attr->store (sysdev_class, buffer, count); +return 0 ; +} + +static struct sysfs_ops sysdev_class_sysfs_ops = { + .show = sysdev_class_show, + .store = sysdev_class_store, +}; + +static struct kobj_type sysdev_class_ktype = { + .sysfs_ops = &sysdev_class_sysfs_ops, +}; +/* * declare system_subsys */ -decl_subsys (system, &ktype_sysdev,NULL ); +decl_subsys (system, &sysdev_class_ktype,NULL );int sysdev_class_register (struct sysdev_class * cls) {
@@ -98,6 +133,19 @@ void sysdev_class_unregister(struct sysdkset_unregister (&cls->kset); } +int sysdev_class_create_file (struct sysdev_class *s,struct sysdev_class_attribute *a) +{ +return sysfs_create_file (&s->kset.kobj, &a->attr); +} + + +void sysdev_class_remove_file (struct sysdev_class *s,struct sysdev_class_attribute *a) +{ +sysfs_remove_file (&s->kset.kobj, &a->attr); +} + +EXPORT_SYMBOL_GPL (sysdev_class_create_file); +EXPORT_SYMBOL_GPL (sysdev_class_remove_file);EXPORT_SYMBOL_GPL (sysdev_class_register);EXPORT_SYMBOL_GPL (sysdev_class_unregister);
include/linux/sysdev.h renamed from include/linux/sysdev.h~sysdev_class-attr-support +15 -0
@@ -40,6 +40,21 @@ struct sysdev_class {extern int sysdev_class_register (struct sysdev_class *);extern void sysdev_class_unregister (struct sysdev_class *); +struct sysdev_class_attribute { +struct attribute attr; +ssize_t (*show)(struct sysdev_class *,char *); +ssize_t (*store)(struct sysdev_class *,const char *,size_t ); +}; + +#define SYSDEV_CLASS_ATTR (_name,_mode,_show,_store) \ +struct sysdev_class_attribute attr_##_name = { \ + .attr = {.name = __stringify(_name), .mode = _mode }, \ + .show = _show, \ + .store = _store, \ +}; + +extern int sysdev_class_create_file (struct sysdev_class *,struct sysdev_class_attribute *); +extern void sysdev_class_remove_file (struct sysdev_class *,struct sysdev_class_attribute *);/** * Auxillary system device drivers.
_