Skip to contentSkip to conversation

Fix num_online_nodes() warning on NUMA-Q

PATCH In review Matthew Dobson 1 participant 2 messages Jan 19, 2005

lore
Share & tools
lore

Matthew Dobson

author
#0 lore raw

PATCH 1/1 Fix num_online_nodes() warning on NUMA-Q

include/asm-i386/mach-numaq/mach_apic.h complains about an implicit declaration of num_online_nodes():

In file included from arch/i386/kernel/cpu/intel.c:19:
include/asm-i386/mach-numaq/mach_apic.h: In function `setup_portio_remap':
include/asm-i386/mach-numaq/mach_apic.h:115: warning: implicit declaration of function `num_online_nodes'

This patch gets rid of this warning. Please apply.

-Matt

include/asm-i386/mach-numaq/mach_apic.h +1 -0
diff -Nurp --exclude-from=/home/mcd/.dontdiff linux-2.6.11-rc1-mm1/include/asm-i386/mach-numaq/mach_apic.h linux-2.6.11-rc1-mm1+warn_fix/include/asm-i386/mach-numaq/mach_apic.h
@@ -3,6 +3,7 @@
 
 #include <asm/io.h>
 #include <linux/mmzone.h>
+#include <linux/nodemask.h>
 
 #define APIC_DFR_VALUE	(APIC_DFR_CLUSTER)
author
#1 lore raw
Quoted 10 lines · Matthew Dobson

include/asm-i386/mach-numaq/mach_apic.h complains about an implicit declaration of num_online_nodes():

In file included from arch/i386/kernel/cpu/intel.c:19:
include/asm-i386/mach-numaq/mach_apic.h: In function `setup_portio_remap':
include/asm-i386/mach-numaq/mach_apic.h:115: warning: implicit declaration of function `num_online_nodes'

This patch gets rid of this warning. Please apply.

-Matt

Another compilation warning/error related to the recent num_online_nodes() work was discovered. This rollup patch fixes both the above warning and the warnings/errors in arch/i386/pci/numa.c discovered by Pat Mansfield.

-Matt

arch/i386/pci/numa.c +1 -0
diff -Nurp --exclude-from=/home/mcd/.dontdiff linux-2.6.11-rc1-mm1/arch/i386/pci/numa.c linux-2.6.11-rc1-mm1+warn_fix/arch/i386/pci/numa.c
@@ -4,6 +4,7 @@
 
 #include <linux/pci.h>
 #include <linux/init.h>
+#include <linux/nodemask.h>
 #include "pci.h"
 
 #define BUS2QUAD(global) (mp_bus_id_to_node[global])
include/asm-i386/mach-numaq/mach_apic.h +1 -0
diff -Nurp --exclude-from=/home/mcd/.dontdiff linux-2.6.11-rc1-mm1/include/asm-i386/mach-numaq/mach_apic.h linux-2.6.11-rc1-mm1+warn_fix/include/asm-i386/mach-numaq/mach_apic.h
@@ -3,6 +3,7 @@
 
 #include <asm/io.h>
 #include <linux/mmzone.h>
+#include <linux/nodemask.h>
 
 #define APIC_DFR_VALUE	(APIC_DFR_CLUSTER)