fs/jfs_logmgr: replace schedule_timeout() with
Quoted 3 lines · Nishanth Aravamudan
Hi,
Please consider applying.
I will. It looks good.
Quoted 4 lines
Description: Use
msleep()instead ofschedule_timeout()to guarantee the task delays as expected. The current code usesTASK_INTERRUPTIBLE; however, it does not check for signals, so I do not think the change tomsleep()is necessarily bad.
Right, TASK_INTERRUPTIBLE doesn't make sense here, so msleep is a better fit.
Thanks,
Shaggy
Quoted 22 lines
Signed-off-by Nishanth Aravamudan <[email protected]>fs/jfs/jfs_logmgr.c +2
-2@@ -67,6 +67,7 @@#include <linux/buffer_head.h> /* for sync_blockdev() */ #include <linux/bio.h> #include <linux/suspend.h> +#include <linux/delay.h> #include "jfs_incore.h" #include "jfs_filsys.h" #include "jfs_metapage.h" @@ -1612,8 +1613,7 @@ void jfs_flush_journal(struct jfs_log *l*/ if ((!list_empty (&log->cqueue)) || !list_empty (&log->synclist)) {for (i =0 ; i <800 ; i++) {/* Too much? */ - current->state =TASK_INTERRUPTIBLE ; -schedule_timeout (HZ /4 ); +msleep (250 );if (list_empty (&log->cqueue) &&list_empty (&log->synclist))break ;
Signature · 2 lines
David Kleikamp IBM Linux Technology Center
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors