Skip to contentSkip to conversation

e100 locking up netconsole.

PATCH In review Steven Rostedt 2 participants 2 messages Jan 23, 2005 Networking

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 e100 locking up netconsole.

I'm currently working with Ingo's RT patched kernel, but I believe this affects the mainline too.

If the transmit buffer of the e100 overflowed, then the system would hang. This was caused because the e100 driver would stop the queue, and find_skb in netpoll.c would then loop forever. This is because the e100 net_poll would never start the queue again after the transmits have completed.

For those that use the e100 and netconsole, all you need to do is a sysreq 't' to lock up the system.

Here's the patch: (from Ingo's linux-2.6.11-rc2-V0.7.36-02, but should be OK with 2.6.11-rc2)

net/e100.c +1 -0
Index: drivers/net/e100.c
===================================================================
@@ -1630,6 +1630,7 @@
 	struct nic *nic = netdev_priv(netdev);
 	e100_disable_irq(nic);
 	e100_intr(nic->pdev->irq, netdev, NULL);
+	e100_tx_clean(nic);
 	e100_enable_irq(nic);
 }
 #endif

-- Steve

#1 lore raw
Quoted 6 lines · Steven Rostedt

I'm currently working with Ingo's RT patched kernel, but I believe this affects the mainline too.

If the transmit buffer of the e100 overflowed, then the system would hang. This was caused because the e100 driver would stop the queue, and find_skb in netpoll.c would then loop forever. This is because the e100

^^^^^^^^^

Should be netpoll_send_pkt. That's what I get when I search for "repeat" to remember which function I saw the problem in.

Quoted 33 lines

net_poll would never start the queue again after the transmits have completed.

For those that use the e100 and netconsole, all you need to do is a sysreq 't' to lock up the system.

Here's the patch: (from Ingo's linux-2.6.11-rc2-V0.7.36-02, but should be OK with 2.6.11-rc2)

Index: drivers/net/e100.c
===================================================================

net/e100.c +1 -2
@@ -1630,6 +1630,7 @@
 	struct nic *nic = netdev_priv(netdev);
 	e100_disable_irq(nic);
 	e100_intr(nic->pdev->irq, netdev, NULL);
+	e100_tx_clean(nic);
 	e100_enable_irq(nic);
 }
 #endif
 
 
 
-- Steve
 
 
-

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Signature · 3 lines
Steven Rostedt
Senior Engineer
Kihon Technologies