Skip to contentSkip to conversation

fix broken cross compiles

PATCH New James Bottomley 1 participant 1 message Jan 26, 2005 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fix broken cross compiles

This patch:

kbuild: Use -isystem gcc -print-file-name=include

broke our parisc crosscompile (and presumably everyone else's).

The reason is that you have a := in the NOSTDINC_FLAGS rule, which is evaluated in situ (i.e. before we've had a chance to set CROSSCOMPILE on CC) so the gcc include path is actually the native one not the crosscompiler one. On parisc this causes us to be unable to handle _builtin_va functions, but I bet there are a heap of other problems.

The fix is below

James

===== Makefile 1.561 vs edited =====

Makefile +1 -1
@@ -331,7 +331,7 @@
 PERL		= perl
 CHECK		= sparse
 
-NOSTDINC_FLAGS := -nostdinc -isystem $(shell $(CC) -print-file-name=include)
+NOSTDINC_FLAGS  = -nostdinc -isystem $(shell $(CC) -print-file-name=include)
 CHECKFLAGS     := -D__linux__ -Dlinux -D__STDC__ -Dunix -D__unix__
 CHECKFLAGS     += $(NOSTDINC_FLAGS)
 MODFLAGS	= -DMODULE