Skip to contentSkip to conversation

cpufreq resume fix?

PATCH New Andres Salomon 1 participant 1 message Jan 31, 2005 CPU frequency scaling framework

lore
Share & tools
lore

Andres Salomon

author
#0 lore raw

PATCH 1/1 cpufreq resume fix?

Hi,

I noticed in the following changeset, the cpufreq_driver->resume call semantics looked a little odd:
http://linux.bkbits.net:8080/linux-2.6/gnupatch@41d25ff3DyITFVz4Jm34PpluFPlt-g

Since acpi_cpufreq_resume and speedstep_resume appear to return 0 upon success, it seems like the attached patch is what the desired behavior would be. Otherwise, cpufreq_resume() always prints an error and exits early if using a cpufreq_driver that supports resume.

Signature · 1 line
Andres Salomon <[email protected]>
drivers/cpufreq/cpufreq.c +5 -3
@@ -900,9 +900,11 @@
 
 	if (cpufreq_driver->resume) {
 		ret = cpufreq_driver->resume(cpu_policy);
-		printk(KERN_ERR "cpufreq: resume failed in ->resume step on CPU %u\n", cpu_policy->cpu);
-		cpufreq_cpu_put(cpu_policy);
-		return (ret);
+		if (ret) {
+			printk(KERN_ERR "cpufreq: resume failed in ->resume step on CPU %u\n", cpu_policy->cpu);
+			cpufreq_cpu_put(cpu_policy);
+			return (ret);
+		}
 	}
 
 	if (!(cpufreq_driver->flags & CPUFREQ_CONST_LOOPS)) {