Skip to contentSkip to conversation

About ARECA RAID driver for Linux i386/x86-64

DISCUSSION erich 4 participants 4 messages Feb 3, 2005 – Feb 6, 2005 SCSI

lore
Share & tools
lore

erich

author
#0 lore raw

Hi,Andrew Morton

Thanks for your doing.
ARECA Linux RAID driver need to support old linux kerenel version. There are a lot of NAS RAID STORAGE SYSTEM development worker still use it at old linux kernel.
Maybe I need to released one package that as cleanly as look like a Linux driver :) modern times :( .

Best Regards
Erich Chen

----- Original Message -----
From: "Andrew Morton" <[email protected]>
To: "erich" <[email protected]>
Cc: <[email protected]>
Sent: Thursday, February 03, 2005 10:08 AM
Subject: Re: About ARECA RAID driver for Linux i386/x86-64

Quoted 3 lines
Quoted 2 lines · erich

I have contact with Andrew Morton about ARECA RAID Linux scsi driver

release

Quoted 7 lines
Quoted 2 lines

issue.
I hope this package is as look like a Linux driver.

No, it doesn't look anything like a Linux driver :(

I fed the patch through scripts/Lindent. There's a copy at

http://www.zip.com.au/~akpm/linux/patches/stuff/areca-raid-linux-scsi-driver.patch.

Quoted 21 lines

I'll include it -mm kernels.

From a very quick look, I'd say that the driver needs quite a bit of work:

- Remove Documentation/scsi/arcmsr.txt - none of it is relevant

- Use named structure initialisers:

struct foo bar = {
.name1 = value1,
.name2 = value2,
};

- Remove all the LINUX_VERSION_CODE tests

- The kernel thread stopping/starting stuff is old fashioned. Use the kthread API.

- I suspect it is using old-fashioned SCSI APIs too.

#1 lore raw
Quoted 5 lines · erich

Thanks for your doing.
ARECA Linux RAID driver need to support old linux kerenel version. There are a lot of NAS RAID STORAGE SYSTEM development worker still use it at old linux kernel.

Well that's a decision which the scsi maintainers will need to make. Lots of current drivers use LINUX_VERSION_CODE, even though we'd prefer they not do so. I don't know what the scsi policy is for new submissions.

#2 lore raw
Quoted 3 lines · Andrew Morton

Well that's a decision which the scsi maintainers will need to make. Lots of current drivers use LINUX_VERSION_CODE, even though we'd prefer they not do so. I don't know what the scsi policy is for new submissions.

Hey ... I have to have a policy now?

The policy generally is that new submissions need to use the latest versions of the API. If the driver needs to work on 2.4, it should use the 2.4 compat layer for 2.6 drivers (and if there's a problem or something missing, we can update 2.4).

James

#3 lore raw
In reply to erich
Quoted 8 lines · erich

Hi,Andrew Morton

Thanks for your doing.
ARECA Linux RAID driver need to support old linux kerenel version. There are a lot of NAS RAID STORAGE SYSTEM development worker still use it at old linux kernel.
Maybe I need to released one package that as cleanly as look like a Linux driver :) modern times :( .

If you write two proper drivers for 2.4.x and 2.6.x they're probably less size than your current driver.