Skip to contentSkip to conversation

PNPACPI: don't complain about vendor-defined resources

PATCH Applied Bjorn Helgaas 3 participants 6 messages Feb 11, 2005 – Mar 12, 2005 2 messages not in the archive

Subsystems (2)
ACPI Pnp support
lore
Share & tools
lore

Bjorn Helgaas

author
#0 lore raw

PATCH 1/1 PNPACPI: don't complain about vendor-defined resources

Don't complain about vendor-defined resources, just ignore them. And make warning messages a little more consistent.

Signed-off-by Bjorn Helgaas <[email protected]>

===== drivers/pnp/pnpacpi/rsparser.c 1.2 vs edited =====

drivers/pnp/pnpacpi/rsparser.c +5 -4
@@ -219,9 +219,10 @@
 		res->data.address64.min_address_range, 
 		res->data.address64.address_length);
 		break;
+	case ACPI_RSTYPE_VENDOR:
+		break;
 	default:
-		pnp_warn("PnPACPI: Alloc type : %d not handle", 
-				res->id);
+		pnp_warn("PnPACPI: unknown resource type %d", res->id);
 		return AE_ERROR;
 	}
 			

@@ -508,7 +509,7 @@
 		case ACPI_RSTYPE_END_DPF:
 			return AE_CTRL_TERMINATE;
 		default:
-			pnp_warn("PnPACPI:Option type: %d not handle", res->id);
+			pnp_warn("PnPACPI: unknown resource type %d", res->id);
 			return AE_ERROR;
 	}
 			

@@ -810,7 +811,7 @@
 			mem ++;
 			break;
 		default: /* other type */
-			pnp_warn("Invalid type");
+			pnp_warn("unknown resource type %d", resource->id);
 			return -EINVAL;
 		}
 		resource ++;

-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click

Applied
#1 lore raw

Applied.

thanks,
-Len

Quoted 43 lines · Bjorn Helgaas

Don't complain about vendor-defined resources, just ignore them. And make warning messages a little more consistent.

Signed-off-by Bjorn Helgaas <[email protected]>

===== drivers/pnp/pnpacpi/rsparser.c 1.2 vs edited =====

drivers/pnp/pnpacpi/rsparser.c 2005-02-11 12:43:12 renamed from drivers/pnp/pnpacpi/rsparser.c 2004-10-31 18:21:10 -07:00 +4 -4
-07:00

@@ -219,9 +219,10 @@
                res->data.address64.min_address_range,
                res->data.address64.address_length);
                break;
+       case ACPI_RSTYPE_VENDOR:
+               break;
        default:
-               pnp_warn("PnPACPI: Alloc type : %d not handle",
-                               res->id);
+               pnp_warn("PnPACPI: unknown resource type %d",
 res->id);
                return AE_ERROR;
        }

@@ -508,7 +509,7 @@
                case ACPI_RSTYPE_END_DPF:
                        return AE_CTRL_TERMINATE;
                default:
-                       pnp_warn("PnPACPI:Option type: %d not handle",
 res->id);
+                       pnp_warn("PnPACPI: unknown resource type %d",
 res->id);
                        return AE_ERROR;

        }
drivers/pnp/pnpacpi/rsparser.c 2005-02-11 12:43:12 renamed from drivers/pnp/pnpacpi/rsparser.c 2004-10-31 18:21:10 -07:00 +1 -1
@@ -810,7 +811,7 @@
                        mem ++;
                        break;
                default: /* other type */
-                       pnp_warn("Invalid type");
+                       pnp_warn("unknown resource type %d",
 resource->id);
                        return -EINVAL;
                }
Quoted 5 lines
                resource ++;

-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click

#2 lore raw
Quoted 4 lines · Len Brown

Applied.

thanks,
-Len

Just out of curiosity, are we seeing many vendor-defined resources from ACPI?

Thanks,
Adam

-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click

A message that is not in the archive (sent off-list or not yet received): 1110586059.12485.225.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/[email protected]

author
#4 lore raw
Quoted 8 lines · Adam Belay
Quoted 4 lines · Len Brown

Applied.

thanks,
-Len

Just out of curiosity, are we seeing many vendor-defined resources from ACPI?

HP boxes have some. Our host-to-AGP bridge, IOMMU, etc have them to tell you where the device's MMIO CSR space is.

-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click

#5 lore raw
Quoted 4 lines · Bjorn Helgaas
Quoted 3 lines · Adam Belay
Quoted 2 lines · Len Brown

Applied.

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

thanks,
-Len

Just out of curiosity, are we seeing many vendor-defined resources from ACPI?

HP boxes have some. Our host-to-AGP bridge, IOMMU, etc have them to tell you where the device's MMIO CSR space is.

Hmm, interesting. I'm asking because I was considering how necessary it would be to pass this information down to actual drivers.

Thanks,
Adam

-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click

A message that is not in the archive (sent off-list or not yet received): 1110587127.12485.236.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/[email protected]

author
#7 lore raw
Quoted 10 lines · Adam Belay
Quoted 6 lines · Bjorn Helgaas
Quoted 2 lines · Adam Belay

Just out of curiosity, are we seeing many vendor-defined resources from ACPI?

HP boxes have some. Our host-to-AGP bridge, IOMMU, etc have them to tell you where the device's MMIO CSR space is.

Hmm, interesting. I'm asking because I was considering how necessary it would be to pass this information down to actual drivers.

See hp_acpi_csr_space(), used by the sba_iommu and hp-agp drivers.

Which reminds me, I think the idea of using a UUID to label these vendor-defined resources made it into ACPI 3.0 (section 6.4.3.2). My plan was to move the infrastructure behind this (everything in arch/ia64/kernel/acpi-ext.c except the hp_ccsr_descriptor and hp_acpi_csr_space()) out of arch/ia64 and into drivers/acpi. Something else for my to-do list, I guess ;-)

-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click