typo in drivers/i2c/busses/i2c-ixp4xx.c
PATCH 1/1 typo in drivers/i2c/busses/i2c-ixp4xx.c
Hi Deepak,
I was looking at your ixp4xx gpio i2c driver for inspiration (for a similar pxa2xx one) and I just happened to notice a tiny typo.
Index: 2.6/drivers/i2c/busses/i2c-ixp4xx.c
=================================--- 2.6.orig/drivers/i2c/busses/i2c-ixp4xx.c 2004-10-18 22:54:31.000000000 +0100
+++ 2.6/drivers/i2c/busses/i2c-ixp4xx.c 2005-02-17 12:13:01.777210214 +0000
@@ -133,8 +133,8 @@
drv_data->algo_data.mdelay = 10;
drv_data->algo_data.timeout = 100;
- drv_data->adapter.id = I2C_HW_B_IXP4XX,
- drv_data->adapter.algo_data = &drv_data->algo_data,
+ drv_data->adapter.id = I2C_HW_B_IXP4XX;
+ drv_data->adapter.algo_data = &drv_data->algo_data;
drv_data->adapter.dev.parent = &plat_dev->dev;
Signature · 4 lines
Ian Campbell, Senior Design Engineer
Web: http://www.arcom.com
Arcom, Clifton Road, Direct: +44 (0)1223 403 465
Cambridge CB1 7EA, United Kingdom Phone: +44 (0)1223 411 200PATCH 1/1 typo in drivers/i2c/busses/i2c-ixp4xx.c
Quoted 8 lines · Ben Dooks
Quoted 4 lines · Ian Campbell
Hi Deepak,
I was looking at your ixp4xx gpio i2c driver for inspiration (for a similar pxa2xx one) and I just happened to notice a tiny typo.
I didn't think the pxa2xx series allow their i2c pins to be anything other than special function?
I beleive that is correct. What I am doing is turning a couple of the GPIO lines into a second (and in fact a third) i2c bus.
(please don't ask why three buses are required -- historical accident :-( ).
Ian.
Signature · 10 lines
Ian Campbell, Senior Design Engineer
Web: http://www.arcom.com
Arcom, Clifton Road, Direct: +44 (0)1223 403 465
Cambridge CB1 7EA, United Kingdom Phone: +44 (0)1223 411 200
_____________________________________________________________________
The message in this transmission is sent in confidence for the attention of the addressee only and should not be disclosed to any other party. Unauthorised recipients are requested to preserve this confidentiality. Please advise the sender if the addressee is not resident at the receiving end. Email to and from Arcom is automatically monitored for operational and lawful business reasons.
This message has been virus scanned by MessageLabs.PATCH 1/1 typo in drivers/i2c/busses/i2c-ixp4xx.c
In reply to Ian CampbellQuoted 4 lines · Ian Campbell
Hi Deepak,
I was looking at your ixp4xx gpio i2c driver for inspiration (for a similar pxa2xx one) and I just happened to notice a tiny typo.
I didn't think the pxa2xx series allow their i2c pins to be anything other than special function?
Signature · 3 lines
Ben ([email protected], http://www.fluff.org/) 'a smiley only costs 4 bytes'
Greg KH
AppliedPATCH 1/1 typo in drivers/i2c/busses/i2c-ixp4xx.c
In reply to Ian CampbellQuoted 6 lines · Ian Campbell
Hi Deepak,
I was looking at your ixp4xx gpio i2c driver for inspiration (for a similar pxa2xx one) and I just happened to notice a tiny typo.
Signed-off-by Ian Campbell <[email protected]>
Applied, thanks.
greg k-h
PATCH 1/1 typo in drivers/i2c/busses/i2c-ixp4xx.c
In reply to Ian CampbellQuoted 7 lines · Ian Campbell
Quoted 6 lines · Ben Dooks
Quoted 4 lines · Ian Campbell
Hi Deepak,
I was looking at your ixp4xx gpio i2c driver for inspiration (for a similar pxa2xx one) and I just happened to notice a tiny typo.
Quoted 8 lines
Quoted 2 lines
I didn't think the pxa2xx series allow their i2c pins to be anything other than special function?
I beleive that is correct. What I am doing is turning a couple of the GPIO lines into a second (and in fact a third) i2c bus.
(please don't ask why three buses are required -- historical accident :-( ).
Ok, sorry, jumped to wrong conclusion.
Signature · 3 lines
Ben ([email protected], http://www.fluff.org/) 'a smiley only costs 4 bytes'