Skip to contentSkip to conversation

drivers/chat/vt.c: remove unnecessary code

PATCH [email protected] 1 participant 1 message Feb 28, 2005

lore
Share & tools
lore
#0 lore raw
Quoted 14 lines · On Mon, Feb 28, 2005 at 01:55:28PM +0100, colbuse@xxxxxxxxxxxxxxx wrote:
Quoted 2 lines

Avoid changing the state of the console two times in some cases.

A bad change for several reasons.

(i) more object code is generated
(ii) the code is slower
(iii) you change something

Straight line code is cheap, jumps are expensive. Replacing an assignment by a jump is not an improvement.

I didn't thought to that point...

You're right, this patch was a bad idea :(.

Sorry about this error...

--
Emmanuel Colbus
Club GNU/Linux
ENSIMAG - Departement telecoms

-------------------------------------------------
envoyé via Webmail/IMAG !