Skip to contentSkip to conversation

W1: fix printk format warning

PATCH New Randy.Dunlap 2 participants 2 messages May 19, 2005 W1 dallas's 1-wire bus

lore
Share & tools
lore

Randy.Dunlap

author
#0 lore raw

PATCH 1/1 W1: fix printk format warning

Use 'unsigned long long' for __u64 printk:

drivers/w1/w1.c:415: warning: long long unsigned int format, __u64 arg (arg 6)

Signed-off-by Randy Dunlap <[email protected]>

diffstat: drivers/w1/w1.c | 3 ++-

 1 files changed, 2 insertions(+), 1 deletion(-)
drivers/w1/w1.c renamed from drivers/w1/w1.c~w1_printk +2 -1
diff -Naurp ./drivers/w1/w1.c~w1_printk ./drivers/w1/w1.c
@@ -413,7 +413,8 @@ static int w1_attach_slave_device(struct
 	if (!f) {
 		spin_unlock(&w1_flock);
 		dev_info(&dev->dev, "Family %x for %02x.%012llx.%02x is not registered.\n",
-			  rn->family, rn->family, rn->id, rn->crc);
+			  rn->family, rn->family,
+			  (unsigned long long)rn->id, rn->crc);
 		kfree(sl);
 		return -ENODEV;
 	}

---

#1 lore raw

PATCH 1/1 W1: fix printk format warning

Quoted 3 lines · Randy.Dunlap

Use 'unsigned long long' for __u64 printk:

drivers/w1/w1.c:415: warning: long long unsigned int format, __u64 arg (arg 6)

Thank you, I've applied it to me tree.
Andrew, please, push it upstrem.

Quoted 1 line
Signed-off-by Randy Dunlap <[email protected]>
Signed-off-by Evgeniy Polyakov <[email protected]>
Quoted 19 lines

diffstat:> drivers/w1/w1.c | 3 ++-

 1 files changed, 2 insertions(+), 1 deletion(-)

diff -Naurp ./drivers/w1/w1.c~w1_printk ./drivers/w1/w1.c

drivers/w1/w1.c renamed from drivers/w1/w1.c~w1_printk +2 -2
@@ -413,7 +413,8 @@ static int w1_attach_slave_device(struct
 	if (!f) {
 		spin_unlock(&w1_flock);
 		dev_info(&dev->dev, "Family %x for %02x.%012llx.%02x is not registered.\n",
-			  rn->family, rn->family, rn->id, rn->crc);
+			  rn->family, rn->family,
+			  (unsigned long long)rn->id, rn->crc);
 		kfree(sl);
 		return -ENODEV;
 	}
 
 
---
Signature · 10 lines
        Evgeniy Polyakov

Crash is better than data corruption -- Arthur Grabowski
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20050303/340cee0d/attachment.bin