Skip to contentSkip to conversation

cpu_to_node_map on UP systems

DISCUSSION dann frazier 5 participants 9 messages Mar 9, 2005 – Mar 10, 2005

lore
Share & tools
lore
#0 lore raw

In 2.6.11, cpu_to_node_map has moved from numa.c to smpboot.c. Since smpboot.c isn't built on non-SMP systems, this causes non-smp builds to fail to link in various places.

I don't know what the right answer is here - resurrect numa.c maybe?

Signature · 1 line
dann frazier <[email protected]>
#1 lore raw

Hi dann

Quoted 5 lines · dann frazier

In 2.6.11, cpu_to_node_map has moved from numa.c to smpboot.c. Since smpboot.c isn't built on non-SMP systems, this causes non-smp builds to fail to link in various places.

I don't know what the right answer is here - resurrect numa.c maybe?

We do not seem to have a problem on our Autobuild with CONFIG_SMP=n
http://www.gelato.unsw.edu.au/kerncomp/

Just tested latest bk [email protected], 2005-03-08 16:26:54-08:00, [email protected] tiger_defconfig
CONFIG_SMP=n

plus removal of some unwanted drivers builds OK

Quoted 8 lines
Signature · 7 lines
-- 
dann frazier <[email protected]>

-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

--------------------------------------------------
Darren Williams <dsw AT gelato.unsw.edu.au>
Gelato@UNSW <www.gelato.unsw.edu.au>
--------------------------------------------------

#2 lore raw
In reply to dann frazier
Quoted 9 lines
Quoted 2 lines

In 2.6.11, cpu_to_node_map has moved from numa.c to smpboot.c. Since smpboot.c isn't built on non-SMP systems, this causes

non-smp builds to

Quoted 3 lines

fail to link in various places.

I don't know what the right answer is here - resurrect numa.c maybe?

We do not seem to have a problem on our Autobuild with CONFIG_SMP=n
http://www.gelato.unsw.edu.au/kerncomp/

Quoted 6 lines

Just tested latest bk [email protected], 2005-03-08 16:26:54-08:00, [email protected] tiger_defconfig
CONFIG_SMP=n

plus removal of some unwanted drivers builds OK

Yes, tiger builds ok with SMP=n (if you pull from the linux-ia64-test-2.6.12 you'll also gets Bjorn's fix to iosapic so the the resulting kernel will boot, rather than hang).

There are still problems with building the generic kernel with SMP=n

-Tony

#3 lore raw
In reply to dann frazier
Quoted 9 lines · Darren Williams

Hi dann

Quoted 5 lines · dann frazier

In 2.6.11, cpu_to_node_map has moved from numa.c to smpboot.c. Since smpboot.c isn't built on non-SMP systems, this causes non-smp builds to fail to link in various places.

I don't know what the right answer is here - resurrect numa.c maybe?

Quoted 8 lines

We do not seem to have a problem on our Autobuild with CONFIG_SMP=n
http://www.gelato.unsw.edu.au/kerncomp/

Just tested latest bk [email protected], 2005-03-08 16:26:54-08:00, [email protected] tiger_defconfig
CONFIG_SMP=n

plus removal of some unwanted drivers builds OK

Is that an IA64_GENERIC build?

#4 lore raw
In reply to dann frazier
Quoted 5 lines · Tony

Yes, tiger builds ok with SMP=n (if you pull from the linux-ia64-test-2.6.12 you'll also gets Bjorn's fix to iosapic so the the resulting kernel will boot, rather than hang).

There are still problems with building the generic kernel with SMP=n

I thought we had worked all these out awhile ago? I assume you're merging all this stuff as fast as you can now that 2.6.12 is open? Or do you need me to resend? If so, let me know when you've got the bulk of your queue merged and I can fix things up, rediff and resend.

Thanks,
Jesse

#5 lore raw
In reply to dann frazier
Quoted 12 lines · Tony
Quoted 2 lines

Yes, tiger builds ok with SMP=n (if you pull from the linux-ia64-test-2.6.12 you'll also gets Bjorn's fix to

iosapic so the the

Quoted 3 lines

resulting kernel will boot, rather than hang).

There are still problems with building the generic kernel with SMP=n

I thought we had worked all these out awhile ago? I assume you're merging all this stuff as fast as you can now that 2.6.12 is open? Or do
you need me to resend? If so, let me know when you've got the bulk of your queue merged and I can fix things up, rediff and resend.

I'm trying to not go "as fast as I can" this time around ... I'm aiming for better review and test of stuff as I put it in (to avoid at least some of the messes that I made before).

At the moment I'm skimming backwards and forwards through the backlog picking stuff and loading it into linux-ia64-test-2.6.12 tree. I'm going to try to be more systematic about routing patches through the test tree before moving them into the release tree.

I have little hope that the SMP=n,GENERIC patches will still apply by the time I get back to them ... so a re-diffed fix would be appreciated (in a couple of weeks when the backlog has drained).

-Tony

#6 lore raw
In reply to dann frazier

Hi Luck,

Quoted 23 lines · Tony
Quoted 12 lines · Tony
Quoted 2 lines

Yes, tiger builds ok with SMP=n (if you pull from the linux-ia64-test-2.6.12 you'll also gets Bjorn's fix to

iosapic so the the

Quoted 3 lines

resulting kernel will boot, rather than hang).

There are still problems with building the generic kernel with SMP=n

I thought we had worked all these out awhile ago? I assume you're merging all this stuff as fast as you can now that 2.6.12 is open? Or do
you need me to resend? If so, let me know when you've got the bulk of your queue merged and I can fix things up, rediff and resend.

I'm trying to not go "as fast as I can" this time around ... I'm aiming for better review and test of stuff as I put it in (to avoid at least some of the messes that I made before).

At the moment I'm skimming backwards and forwards through the backlog picking stuff and loading it into linux-ia64-test-2.6.12 tree. I'm going to try to be more systematic about routing patches through the test tree before moving them into the release tree.

Quoted 4 lines

I have little hope that the SMP=n,GENERIC patches will still apply by the time I get back to them ... so a re-diffed fix would be appreciated (in a couple of weeks when the backlog has drained).

Let me know when the SMP=n,GENERIC patches have been push into mainline and I will add a build run for it on the ia64 autobuild:
http://www.gelato.unsw.edu.au/kerncomp/

Darren

Quoted 1 line

-Tony

--------------------------------------------------
Darren Williams <dsw AT gelato.unsw.edu.au>
Gelato@UNSW <www.gelato.unsw.edu.au>
--------------------------------------------------

#7 lore raw
In reply to dann frazier
Quoted 14 lines · Tony
Quoted 14 lines
Quoted 2 lines

In 2.6.11, cpu_to_node_map has moved from numa.c to smpboot.c. Since smpboot.c isn't built on non-SMP systems, this causes

non-smp builds to

Quoted 3 lines

fail to link in various places.

I don't know what the right answer is here - resurrect numa.c maybe?

We do not seem to have a problem on our Autobuild with CONFIG_SMP=n
http://www.gelato.unsw.edu.au/kerncomp/

Just tested latest bk [email protected], 2005-03-08 16:26:54-08:00, [email protected] tiger_defconfig
CONFIG_SMP=n

Quoted 7 lines
Quoted 1 line

plus removal of some unwanted drivers builds OK

Yes, tiger builds ok with SMP=n (if you pull from the linux-ia64-test-2.6.12 you'll also gets Bjorn's fix to iosapic so the the resulting kernel will boot, rather than hang).

There are still problems with building the generic kernel with SMP=n

fyi, I tried a UP build of linux-ia64-test-2.6.12 (assuming I checked out the right stuff - I don't use bk much), and I get the following compile error:

AS arch/ia64/kernel/head.o
arch/ia64/kernel/head.S:267:54: macro "SAL_TO_OS_BOOT_HANDOFF_STATE_SAVE" passed 3 arguments, but takes just 2 make[1]: *** [arch/ia64/kernel/head.o] Error 1

This is because the macro is defined as the following w/ CONFIG_HOTPLUG_CPU:

#define SAL_TO_OS_BOOT_HANDOFF_STATE_SAVE(_reg1,_reg2,_pred)

But, if CONFIG_HOTPLUG_CPU is disabled (it requires CONFIG_SMP), the following is defined:

#define SAL_TO_OS_BOOT_HANDOFF_STATE_SAVE(a1,a2)

I posted my .config here:
http://free.linux.hp.com/~dannf/linux-ia64-test-2.6.12-20050310.config

#8 lore raw
In reply to dann frazier
Quoted 9 lines

fyi, I tried a UP build of linux-ia64-test-2.6.12 (assuming I checked out the right stuff - I don't use bk much), and I get the following compile error:

AS arch/ia64/kernel/head.o
arch/ia64/kernel/head.S:267:54: macro "SAL_TO_OS_BOOT_HANDOFF_STATE_SAVE" passed 3 arguments, but takes just 2
make[1]: *** [arch/ia64/kernel/head.o] Error 1

I'd just found the same thing ... Ashok gave me a patch, and I just pushed it up to bkbits. So do a "bk pull" and try again.

-Tony