Skip to contentSkip to conversation

PATCH: atp870u DMA mask

PATCH Alan Cox 2 participants 3 messages Mar 11, 2005 SCSI

lore
Share & tools
lore

Alan Cox

author
#0 lore raw

Noted by James Bottomley

Signed-off-by Alan Cox <[email protected]>
scsi/atp870u.c renamed from scsi/atp870u.c.old +1 -1
@@ -2634,7 +2634,7 @@
 	if (pci_enable_device(pdev))
 		return -EIO;
 
-        if (!pci_set_dma_mask(pdev, 0xFFFFFFUL)) {
+        if (!pci_set_dma_mask(pdev, 0xFFFFFFFFUL)) {
                 printk(KERN_INFO "atp870u: use 32bit DMA mask.\n");
         } else {
                 printk(KERN_ERR "atp870u: DMA mask required but not available.\n");
#1 lore raw

scsi/atp870u.c line 2637

Quoted 12 lines · Alan Cox

Noted by James Bottomley

Signed-off-by Alan Cox <[email protected]>
scsi/atp870u.c renamed from scsi/atp870u.c.old +1 -1
@@ -2634,7 +2634,7 @@
 	if (pci_enable_device(pdev))
 		return -EIO;
 
-        if (!pci_set_dma_mask(pdev, 0xFFFFFFUL)) {
+        if (!pci_set_dma_mask(pdev, 0xFFFFFFFFUL)) {

isn't it still an F short?
And... why not use the DMA_32_BIT or whatever define.. it's there for exactly this reason :)

author
#2 lore raw
Quoted 5 lines · Arjan van de Ven

scsi/atp870u.c line 2637

Quoted 2 lines
scsi/atp870u.c renamed from scsi/atp870u.c.old +1 -1
-        if (!pci_set_dma_mask(pdev, 0xFFFFFFUL)) {
+        if (!pci_set_dma_mask(pdev, 0xFFFFFFFFUL)) {

isn't it still an F short?
And... why not use the DMA_32_BIT or whatever define.. it's there for exactly this reason :)

No its 32bit not 36bit DMA capable. As to DMA_32_BIT - I didn't know about it, I'll go take a look for some examples.