Skip to contentSkip to conversation

tool xfrd x86-64 compilation fix.

PATCH In review Jerone Young 2 participants 2 messages Mar 22, 2005

lore
Share & tools
lore

Jerone Young

author
#0 lore raw

PATCH 1/1 tool xfrd x86-64 compilation fix.

Fix curldebug function in xendomain.c of xfrd. Function takes argument "size_t buf_num" and uses it as the field width to print, that has to be an int. While size_t on 32 bit systems is 4bytes (or size of an int) it is 8bytes on 64bit systems (not size of an int). So this function should just use "int buf_num". This function is not used in the code anywhere. This will fix compilation on x86-64.

Signed-off-by Jerone Young <[email protected]>
xfrd/xen_domain.c renamed from xfrd/xen_domain.c.orig +0 -1
@@ -176,7 +176,7 @@ static CURL *curlinit(void){
 
 /** Curl debug function.
  */
-int curldebug(CURL *curl, curl_infotype ty, char *buf, size_t buf_n,

void *data){
+int curldebug(CURL *curl, curl_infotype ty, char *buf, int buf_n, void

*data){
     printf("%*s\n", buf_n, buf);
     return 0;

}

Signature · 12 lines
Jerone Young
IBM Linux Technology Center
[email protected]
512-838-1157 (T/L: 678-1157)



-------------------------------------------------------
This SF.net email is sponsored by: 2005 Windows Mobile Application Contest
Submit applications for Windows Mobile(tm)-based Pocket PCs or Smartphones
for the chance to win $25,000 and application distribution. Enter today at
http://ads.osdn.com/?ad_id=6882&alloc_id=15148&op=click
#1 lore raw

size_t seems like the right type here. Probably should be:

fwrite(data, buf_n, 1, stdout);
printf("\n");

Regards,
Anthony Liguori

Quoted 20 lines · Jerone Young

Fix curldebug function in xendomain.c of xfrd. Function takes argument "size_t buf_num" and uses it as the field width to print, that has to be an int. While size_t on 32 bit systems is 4bytes (or size of an int) it is 8bytes on 64bit systems (not size of an int). So this function should just use "int buf_num". This function is not used in the code anywhere. This will fix compilation on x86-64.

Signed-off-by Jerone Young <[email protected]>
xfrd/xen_domain.c renamed from xfrd/xen_domain.c.orig +1 -1
@@ -176,7 +176,7 @@ static CURL *curlinit(void){
 
 /** Curl debug function.
 */
-int curldebug(CURL *curl, curl_infotype ty, char *buf, size_t buf_n,
 void *data){
+int curldebug(CURL *curl, curl_infotype ty, char *buf, int buf_n, void
 *data){
    printf("%*s\n", buf_n, buf);
Quoted 6 lines
    return 0;
}

-------------------------------------------------------
This SF.net email is sponsored by: 2005 Windows Mobile Application Contest Submit applications for Windows Mobile(tm)-based Pocket PCs or Smartphones for the chance to win $25,000 and application distribution. Enter today at
http://ads.osdn.com/?ad_id=6882&alloc_id=15148&op=click