Skip to contentSkip to conversation

drivers/media/video/bt819.c: bt819_init: wrong array indexing

DISCUSSION Adrian Bunk 2 participants 2 messages Mar 23, 2005

lore
Share & tools
lore
#0 lore raw

The Coverity checker found the following bug in array indexing in the function bt819_init in drivers/media/video/bt819.c:

        init[0x19*2-1] = decoder->norm == 0 ? 115 : 93;

I don't know whether the other array indexes in this function are correct, but this is definitely wrong:
It indexes element 49 wile only the elements 0-43 are available.

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#1 lore raw
Quoted 8 lines · Adrian Bunk

The Coverity checker found the following bug in array indexing in the function bt819_init in drivers/media/video/bt819.c:

        init[0x19*2-1] = decoder->norm == 0 ? 115 : 93;

I don't know whether the other array indexes in this function are correct, but this is definitely wrong:
It indexes element 49 wile only the elements 0-43 are available.

Auch, that is kinda embarrassing... Attached patch fixes it. Andrew, can you please put this patch in the kernel?

Ronald

Signature · 1 line
Ronald S. Bultje <[email protected]>

Index: bt819.c
===================================================================
RCS file: /cvsroot/mjpeg/driver-zoran/bt819.c,v
retrieving revision 1.6

bt819.c +2 -1
diff -u -r1.6 bt819.c
@@ -239,7 +239,8 @@
 	init[0x07 * 2 - 1] = timing->hactive & 0xff;
 	init[0x08 * 2 - 1] = timing->hscale >> 8;
 	init[0x09 * 2 - 1] = timing->hscale & 0xff;
-	init[0x19*2-1] = decoder->norm == 0 ? 115 : 93;	/* Chroma burst delay */
+	/* 0x15 in array is address 0x19 */
+	init[0x15 * 2 - 1] = (decoder->norm == 0) ? 115 : 93;	/* Chroma burst delay */
 	/* reset */
 	bt819_write(client, 0x1f, 0x00);
 	mdelay(1);