common/rc: add filter in _test_inode_flag
PATCH v3 1/1 common/rc: add filter in _test_inode_flag
From: Xiaoli Feng <[email protected]>
Add _filter_testdir_and_scratch to avoid _test_inode_flag failed when mount point contains flag string.
--- common/rc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
common/rc +1 -1
@@ -3112,7 +3112,7 @@ _test_inode_flag() local flag=$1 local file=$2 - if $XFS_IO_PROG -r -c 'lsattr -v' "$file" | grep -q "$flag" ; then + if $XFS_IO_PROG -r -c 'lsattr -v' "$file" | _filter_testdir_and_scratch | grep -q "$flag" ; then return 0 fi return 1
Signature · 1 line
2.18.1
Quoted 15 lines · XiaoLi Feng
From: Xiaoli Feng <[email protected]>
Add
_filter_testdir_and_scratchto avoid_test_inode_flagfailed when mount point contains flag string.Signed-off-by Xiaoli Feng <[email protected]>--- common/rc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)common/rc +0
-0
common/rc _test_inode_flag() · line 3115
Quoted 5 lines
common/rc +1
-1@@ -3112,7 +3112,7 @@ _test_inode_flag() local flag=$1 local file=$2 - if $XFS_IO_PROG -r -c 'lsattr -v' "$file" | grep -q "$flag" ; then + if $XFS_IO_PROG -r -c 'lsattr -v' "$file" | _filter_testdir_and_scratch | grep -q "$flag" ; then
I can't understand that. Could you give us an example about why we need this filter before "quiet grep"? I think this line doesn't have any output (except xfs_io fails), so why a filter is needed?
Thanks,
Zorro
Quoted 6 lines
common/rc +0
-0return 0 fi return 1Signature · 1 line
2.18.1
----- 原始邮件 -----
Quoted 25 lines
发件人: "Zorro Lang" <[email protected]>
收件人: "XiaoLi Feng" <[email protected]>
抄送: [email protected]
发送时间: 星期四, 2021年 2 月 18日 下午 9:41:34
主题: Re: [PATCH v3] common/rc: add filter in_test_inode_flagQuoted 18 lines · XiaoLi Feng
From: Xiaoli Feng <[email protected]>
Add
_filter_testdir_and_scratchto avoid_test_inode_flagfailed when mount point contains flag string.Signed-off-by Xiaoli Feng <[email protected]>--- common/rc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)common/rc +0
-0@@ -3112,7 +3112,7 @@ _test_inode_flag() local flag=$1 local file=$2
Quoted 7 lines
Quoted 3 lines
common/rc +1
-1- if $XFS_IO_PROG -r -c 'lsattr -v' "$file" | grep -q "$flag" ; then + if $XFS_IO_PROG -r -c 'lsattr -v' "$file" | _filter_testdir_and_scratch |grep -q "$flag" ; then
I can't understand that. Could you give us an example about why we need this filter before "quiet grep"? I think this line doesn't have any output (except
xfs_iofails), so why a filter is needed?
Oh, I just saw your reply for V1 patch review:
"When test generic/608 for dax on xfs, "_check_xflag $t_file 0" is always failed if the $f_file has dax string. Yes, here should also include filter for TEST_DIR."
The _check_xflag() function as below:
_check_xflag()
{
local target=$1
local exp_xflag=$2
if [ $exp_xflag -eq 0 ]; then
_test_inode_flag dax $target && echo "$target has unexpected FS_XFLAG_DAX flag"
else
_test_inode_flag dax $target || echo "$target doesn't have expected FS_XFLAG_DAX flag"
fi
}Sure, if the $1 is something likes "/mnt/scratch/file", later echo "$target ...." will print "/mnt/scratch". If you're trying to fix this issue, I think you should filter the "$target" in or behind _check_xflag(), not in _test_inode_flag() which has no output.
Thanks,
Zorro
Quoted 11 lines
Thanks,
ZorroQuoted 6 lines
common/rc +0
-1return 0 fi return 1 --2.18.1
Hi,
----- Original Message -----
Quoted 25 lines
From: "Zorro Lang" <[email protected]>
To: "XiaoLi Feng" <[email protected]>
Cc: [email protected]
Sent: Thursday, February 18, 2021 9:41:35 PM
Subject: Re: [PATCH v3] common/rc: add filter in_test_inode_flagQuoted 18 lines · XiaoLi Feng
From: Xiaoli Feng <[email protected]>
Add
_filter_testdir_and_scratchto avoid_test_inode_flagfailed when mount point contains flag string.Signed-off-by Xiaoli Feng <[email protected]>--- common/rc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)common/rc +0
-0@@ -3112,7 +3112,7 @@ _test_inode_flag() local flag=$1 local file=$2
Quoted 7 lines
Quoted 3 lines
common/rc +1
-1- if $XFS_IO_PROG -r -c 'lsattr -v' "$file" | grep -q "$flag" ; then + if $XFS_IO_PROG -r -c 'lsattr -v' "$file" | _filter_testdir_and_scratch |grep -q "$flag" ; then
I can't understand that. Could you give us an example about why we need this filter before "quiet grep"? I think this line doesn't have any output (except
xfs_iofails), so why a filter is needed?
Yes. this line doesn't have any output. But the return value is different. I send this patch to fix the issue: If testdir or scratch_dir has "$flag". Then it will always return 0. Even if this file doesn't have this "$flag".
Example:
xfs_io -r -c 'lsattr -v' /daxmnt/fileB
[] /daxmnt/fileB
# xfs_io -r -c 'lsattr -v' /daxmnt/fileB | grep -q "dax" # echo $? 0
fileB doesn't have dax flag. But _test_inode_flag will always return 0(expect 1).
Thanks.
Quoted 12 lines
Thanks,
ZorroQuoted 6 lines
common/rc +0
-1return 0 fi return 1 --2.18.1
Quoted 40 lines · Xiaoli Feng
Hi,
----- Original Message -----
Quoted 25 lines
From: "Zorro Lang" <[email protected]>
To: "XiaoLi Feng" <[email protected]>
Cc: [email protected]
Sent: Thursday, February 18, 2021 9:41:35 PM
Subject: Re: [PATCH v3] common/rc: add filter in_test_inode_flagQuoted 18 lines · XiaoLi Feng
From: Xiaoli Feng <[email protected]>
Add
_filter_testdir_and_scratchto avoid_test_inode_flagfailed when mount point contains flag string.Signed-off-by Xiaoli Feng <[email protected]>--- common/rc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)common/rc +0
-0@@ -3112,7 +3112,7 @@ _test_inode_flag() local flag=$1 local file=$2Quoted 7 lines
Quoted 3 lines
common/rc +1
-1- if $XFS_IO_PROG -r -c 'lsattr -v' "$file" | grep -q "$flag" ; then + if $XFS_IO_PROG -r -c 'lsattr -v' "$file" | _filter_testdir_and_scratch |grep -q "$flag" ; then
I can't understand that. Could you give us an example about why we need this filter before "quiet grep"? I think this line doesn't have any output (except
xfs_iofails), so why a filter is needed?Yes. this line doesn't have any output. But the return value is different. I send this patch to fix the issue: If testdir or
scratch_dirhas "$flag". Then it will always return 0. Even if this file doesn't have this "$flag".
Quoted 8 lines
Example:
xfs_io-r -c 'lsattr -v' /daxmnt/fileB
[] /daxmnt/fileB# xfs_io -r -c 'lsattr -v' /daxmnt/fileB | grep -q "dax" # echo $? 0fileB doesn't have dax flag. But
_test_inode_flagwill always return 0(expect 1).
Oh, got it. So the 'grep -q "dax"' is a litte inaccurate. If the mountpoint or file name, or any sub-string in the $file contains "dax", this function will return 0.
If that's the issue you're fixing, I think only filter SCRATCH_MNT and TEST_MNT isn't enough. If we only care about the "attr" part output, how about filter out junk (path name), only keep the [attr]?
Due to looks like the output format of 'lsattr -v' is: "[$attr] $filename" (correct me if I'm wrong). So if we only keep the attr part, that can avoid the 'grep' find "dax" from $filename.
Thanks,
Zorro
Quoted 15 lines
Thanks.
Quoted 12 lines
Thanks,
ZorroQuoted 6 lines
common/rc +0
-1return 0 fi return 1 --2.18.1