Skip to contentSkip to conversation

fix race in __block_prepare_write (again)

PATCH In review Nick Piggin 4 participants 10 messages Apr 21, 2005 – Apr 25, 2005

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fix race in __block_prepare_write (again)

... I somehow didn't send it to Andrew last time.

Signature · 1 line
SUSE Labs, Novell Inc.

Fix a race where __block_prepare_write can leak out an in-flight read against a bh if get_block returns an error. This can lead to the page becoming unlocked while the buffer is locked and the read still in flight. __mpage_writepage BUGs on this condition.

BUG sighted on a 2-way Itanium2 system with 16K PAGE_SIZE running

	fsstress -v -d $DIR/tmp -n 1000 -p 1000 -l 2

where $DIR is a new ext2 filesystem with 4K blocks that is quite small (causing get_block to fail often with -ENOSPC).

fs/buffer.c +4 -2
Index: linux-2.6/fs/buffer.c
===================================================================
@@ -1988,6 +1988,7 @@
 			*wait_bh++=bh;
 		}
 	}
+out:
 	/*
 	 * If we issued read requests - let them complete.
 	 */
@@ -1996,8 +1997,9 @@
 		if (!buffer_uptodate(*wait_bh))
 			return -EIO;
 	}
-	return 0;
-out:
+	if (!err)
+		return err;
+
 	/*
 	 * Zero out any newly allocated blocks to avoid exposing stale
 	 * data.  If BH_New is set, we know that the block was newly
#1 lore raw

Hi,

Quoted 6 lines · Nick Piggin

... I somehow didn't send it to Andrew last time.

Fix a race where __block_prepare_write can leak out an in-flight read against a bh if get_block returns an error. This can lead to the page becoming unlocked while the buffer is locked and the read still in flight. __mpage_writepage BUGs on this condition.

[snip]

Quoted 1 line

--- linux-2.6.orig/fs/buffer.c 2005-04-21 11:55:17.549614278

+1000

Quoted 11 lines

+++ linux-2.6/fs/buffer.c 2005-04-21 15:55:41.483826075 +1000

fs/buffer.c +1 -0
@@ -1988,6 +1988,7 @@
 			*wait_bh++=bh;
 		}
 	}
+out:
 	/*
 	 * If we issued read requests - let them complete.
 	 */
@@ -1996,8 +1997,9 @@
 		if (!buffer_uptodate(*wait_bh))

fs/buffer.c line 2005

Quoted 10 lines
fs/buffer.c +3 -2
 			return -EIO;
 	}
-	return 0;
-out:
+	if (!err)
+		return err;
+
 	/*
 	 * Zero out any newly allocated blocks to avoid exposing stale
 	 * data.  If BH_New is set, we know that the block was newly

Any reason why you left the goto out? It would be IMO much cleaner to remove the label "out" altogether and replace the single "goto out" with a "break" (which is fine since the goto happens inside the for loop immediately after which you place the label.)

Best regards,

Anton

Signature · 4 lines
Anton Altaparmakov <aia21 at cam.ac.uk> (replace at with @)
Unix Support, Computing Service, University of Cambridge, CB2 3QH, UK
Linux NTFS maintainer / IRC: #ntfs on irc.freenode.net
WWW: http://linux-ntfs.sf.net/ & http://www-stu.christs.cam.ac.uk/~aia21/
#2 lore raw

And one more thing...

Quoted 10 lines · Anton Altaparmakov
Quoted 6 lines · Nick Piggin

... I somehow didn't send it to Andrew last time.

Fix a race where __block_prepare_write can leak out an in-flight read against a bh if get_block returns an error. This can lead to the page becoming unlocked while the buffer is locked and the read still in flight. __mpage_writepage BUGs on this condition.

[snip]

Quoted 1 line

--- linux-2.6.orig/fs/buffer.c 2005-04-21 11:55:17.549614278

+1000

Quoted 12 lines

fs/buffer.c line 1998

Quoted 12 lines

+++ linux-2.6/fs/buffer.c 2005-04-21 15:55:41.483826075 +1000

fs/buffer.c +1 -0
@@ -1988,6 +1988,7 @@
 			*wait_bh++=bh;
 		}
 	}
+out:
 	/*
 	 * If we issued read requests - let them complete.
 	 */
@@ -1996,8 +1997,9 @@
 		if (!buffer_uptodate(*wait_bh))
 			return -EIO;

This return is now wrong after your patch. It should be "err = -EIO;" otherwise you do not zero newly allocated blocks and thus risk exposing stale data on buffer i/o errors.

Quoted 6 lines
Quoted 6 lines
fs/buffer.c +3 -2
 	}
-	return 0;
-out:
+	if (!err)
+		return err;
+
Quoted 8 lines

fs/buffer.c line 2005

Quoted 3 lines
fs/buffer.c +0 -0
 	/*
 	 * Zero out any newly allocated blocks to avoid exposing stale
 	 * data.  If BH_New is set, we know that the block was newly

Any reason why you left the goto out? It would be IMO much cleaner to remove the label "out" altogether and replace the single "goto out" with a "break" (which is fine since the goto happens inside the for loop immediately after which you place the label.)

Best regards,

Anton

Signature · 4 lines
Anton Altaparmakov <aia21 at cam.ac.uk> (replace at with @)
Unix Support, Computing Service, University of Cambridge, CB2 3QH, UK
Linux NTFS maintainer / IRC: #ntfs on irc.freenode.net
WWW: http://linux-ntfs.sf.net/ & http://www-stu.christs.cam.ac.uk/~aia21/
#3 lore raw
Quoted 13 lines · Anton Altaparmakov

And one more thing...

Quoted 10 lines · Anton Altaparmakov
Quoted 6 lines · Nick Piggin

... I somehow didn't send it to Andrew last time.

Fix a race where __block_prepare_write can leak out an in-flight read against a bh if get_block returns an error. This can lead to the page becoming unlocked while the buffer is locked and the read still in flight. __mpage_writepage BUGs on this condition.

[snip]

Quoted 1 line

--- linux-2.6.orig/fs/buffer.c 2005-04-21 11:55:17.549614278

+1000

Quoted 17 lines
Quoted 4 lines
Quoted 4 lines

+++ linux-2.6/fs/buffer.c 2005-04-21 15:55:41.483826075 +1000

(quoted diff) +0 -0
@@ -1988,6 +1988,7 @@
 			*wait_bh++=bh;
 		}
Quoted 8 lines

Review line 1998

Quoted 8 lines
(quoted diff) +1 -0
 	}
+out:
 	/*
 	 * If we issued read requests - let them complete.
 	 */
@@ -1996,8 +1997,9 @@
 		if (!buffer_uptodate(*wait_bh))
 			return -EIO;

This return is now wrong after your patch. It should be "err = -EIO;" otherwise you do not zero newly allocated blocks and thus risk exposing stale data on buffer i/o errors.

Hmm yeah I should have been more careful. But isn't that another bug? I mean, wasn't that wrong *before* my patch as well?

It was, right? Because not only might it return without having waited for all in-flight buffers, but it also didn't zero the blocks on errors?

Fix a race where __block_prepare_write can leak out an in-flight read against a bh if get_block returns an error. This can lead to the page becoming unlocked while the buffer is locked and the read still in flight. __mpage_writepage BUGs on this condition.

BUG sighted on a 2-way Itanium2 system with 16K PAGE_SIZE running

	fsstress -v -d $DIR/tmp -n 1000 -p 1000 -l 2

where $DIR is a new ext2 filesystem with 4K blocks that is quite small (causing get_block to fail often with -ENOSPC).

fs/buffer.c +6 -4
Index: linux-2.6/fs/buffer.c
===================================================================
@@ -1952,7 +1952,7 @@
 		if (!buffer_mapped(bh)) {
 			err = get_block(inode, block, bh, 1);
 			if (err)
-				goto out;
+				break;
 			if (buffer_new(bh)) {
 				clear_buffer_new(bh);
 				unmap_underlying_metadata(bh->b_bdev,
@@ -1994,10 +1994,12 @@
 	while(wait_bh > wait) {
 		wait_on_buffer(*--wait_bh);
 		if (!buffer_uptodate(*wait_bh))
-			return -EIO;
+			err = -EIO;
 	}
-	return 0;
-out:
+	if (!err)
+		return err;
+
+	/* Error case: */
 	/*
 	 * Zero out any newly allocated blocks to avoid exposing stale
 	 * data.  If BH_New is set, we know that the block was newly
#4 lore raw
Quoted 32 lines · Nick Piggin
Quoted 13 lines · Anton Altaparmakov

And one more thing...

Quoted 10 lines · Anton Altaparmakov
Quoted 6 lines · Nick Piggin

... I somehow didn't send it to Andrew last time.

Fix a race where __block_prepare_write can leak out an in-flight read against a bh if get_block returns an error. This can lead to the page becoming unlocked while the buffer is locked and the read still in flight. __mpage_writepage BUGs on this condition.

[snip]

Quoted 1 line

--- linux-2.6.orig/fs/buffer.c 2005-04-21 11:55:17.549614278

+1000

Quoted 17 lines
Quoted 4 lines
Quoted 4 lines

+++ linux-2.6/fs/buffer.c 2005-04-21 15:55:41.483826075 +1000

(quoted diff) +0 -0
@@ -1988,6 +1988,7 @@
 			*wait_bh++=bh;
 		}
Quoted 8 lines

Review line 1998

Quoted 8 lines
(quoted diff) +1 -0
 	}
+out:
 	/*
 	 * If we issued read requests - let them complete.
 	 */
@@ -1996,8 +1997,9 @@
 		if (!buffer_uptodate(*wait_bh))
 			return -EIO;

This return is now wrong after your patch. It should be "err = -EIO;" otherwise you do not zero newly allocated blocks and thus risk exposing stale data on buffer i/o errors.

Quoted 5 lines

Hmm yeah I should have been more careful. But isn't that another bug? I mean, wasn't that wrong *before* my patch as well?

It was, right? Because not only might it return without having waited for all in-flight buffers, but it also didn't zero the blocks on errors?

I agree with you. It was a bug. There are a lot more bugs in the generic write code paths. I have been analysing the code quite thoroughly because I am reimplementing it in NTFS and am shocked that a number of bugs in the generic file write code paths have gone unnoticed for ages (I guess since they only affect seldom traversed code paths). When I have the time I will be cooking up patches but it might be a while. And perhaps someone else will fix them before I get to them so here are a couple of examples off the top of my head...

mm/filemap.c::file_buffered_write():

- It calls fault_in_pages_readable() which is completely bogus if @nr_segs > 1. It needs to be replaced by a to be written "fault_in_pages_readable_iovec()".

- It increments @buf even in the iovec case thus @buf can point to random memory really quickly (in the iovec case) and then it calls fault_in_pages_readable() on this random memory. Ouch...

Best regards,

Anton

Signature · 4 lines
Anton Altaparmakov <aia21 at cam.ac.uk> (replace at with @)
Unix Support, Computing Service, University of Cambridge, CB2 3QH, UK
Linux NTFS maintainer / IRC: #ntfs on irc.freenode.net
WWW: http://linux-ntfs.sf.net/ & http://www-stu.christs.cam.ac.uk/~aia21/
#5 lore raw

Anton Altaparmakov writes:

[...]

Quoted 6 lines

mm/filemap.c::file_buffered_write():

- It calls fault_in_pages_readable() which is completely bogus if @nr_segs > 1. It needs to be replaced by a to be written "fault_in_pages_readable_iovec()".

Which will be only marginally less bogus, because page(s) can be evicted from the memory between fault_in_pages_readable*() and __grab_cache_page() anyway.

[...]

Quoted 3 lines

Best regards,

Anton

Nikita.

#6 lore raw
Quoted 10 lines · Nikita Danilov
Quoted 5 lines · Anton Altaparmakov

mm/filemap.c::file_buffered_write():

- It calls fault_in_pages_readable() which is completely bogus if @nr_segs > 1. It needs to be replaced by a to be written "fault_in_pages_readable_iovec()".

Which will be only marginally less bogus, because page(s) can be evicted from the memory between fault_in_pages_readable*() and __grab_cache_page() anyway.

That is true. But it does make the race condition smaller.

A better approach would be to lock the pages into memory via set page reserved or something. Of course they will need unmarking straight after and we would need to be careful to not unmark pages that were marked reserved to start with.

Comments?

Best regards,

Anton

Signature · 4 lines
Anton Altaparmakov <aia21 at cam.ac.uk> (replace at with @)
Unix Support, Computing Service, University of Cambridge, CB2 3QH, UK
Linux NTFS maintainer / IRC: #ntfs on irc.freenode.net
WWW: http://linux-ntfs.sf.net/ & http://www-stu.christs.cam.ac.uk/~aia21/
#7 lore raw
In reply to Anton Altaparmakov
Quoted 10 lines · Anton Altaparmakov

mm/filemap.c::file_buffered_write():

- It calls fault_in_pages_readable() which is completely bogus if @nr_segs > 1. It needs to be replaced by a to be written "fault_in_pages_readable_iovec()".

- It increments @buf even in the iovec case thus @buf can point to random memory really quickly (in the iovec case) and then it calls fault_in_pages_readable() on this random memory. Ouch...

hmm, yes. Like this?

mm/filemap.c renamed from mm/filemap.c~generic_file_buffered_write-fixes +4 -2
diff -puN mm/filemap.c~generic_file_buffered_write-fixes mm/filemap.c
@@ -1944,7 +1944,7 @@ generic_file_buffered_write(struct kiocb
 		buf = iov->iov_base + written;
 	else {
 		filemap_set_next_iovec(&cur_iov, &iov_base, written);
-		buf = iov->iov_base + iov_base;
+		buf = cur_iov->iov_base + iov_base;
 	}
 
 	do {
@@ -2002,9 +2002,11 @@ generic_file_buffered_write(struct kiocb
 				count -= status;
 				pos += status;
 				buf += status;
-				if (unlikely(nr_segs > 1))
+				if (unlikely(nr_segs > 1)) {
 					filemap_set_next_iovec(&cur_iov,
 							&iov_base, status);
+					buf = cur_iov->iov_base + iov_base;
+				}
 			}
 		}
 		if (unlikely(copied != bytes))

_

#8 lore raw
Quoted 8 lines · Andrew Morton
Quoted 7 lines · Anton Altaparmakov

mm/filemap.c::file_buffered_write():

- It calls fault_in_pages_readable() which is completely bogus if @nr_segs > 1. It needs to be replaced by a to be written "fault_in_pages_readable_iovec()".

Quoted 5 lines
Quoted 3 lines

- It increments @buf even in the iovec case thus @buf can point to random memory really quickly (in the iovec case) and then it calls fault_in_pages_readable() on this random memory. Ouch...

hmm, yes. Like this?

Yes, certainly a big improvement over what is there at the moment.

Quoted 15 lines

diff -puN mm/filemap.c~generic_file_buffered_write-fixes mm/filemap.c

mm/filemap.c renamed from mm/filemap.c~generic_file_buffered_write-fixes +1 -1
@@ -1944,7 +1944,7 @@ generic_file_buffered_write(struct kiocb
 		buf = iov->iov_base + written;
 	else {
 		filemap_set_next_iovec(&cur_iov, &iov_base, written);
-		buf = iov->iov_base + iov_base;
+		buf = cur_iov->iov_base + iov_base;
 	}
 
 	do {
@@ -2002,9 +2002,11 @@ generic_file_buffered_write(struct kiocb
 				count -= status;
 				pos += status;

mm/filemap.c generic_file_buffered_write(struct kiocb · line 2012

Quoted 10 lines
mm/filemap.c renamed from mm/filemap.c~generic_file_buffered_write-fixes +3 -1
 				buf += status;
-				if (unlikely(nr_segs > 1))
+				if (unlikely(nr_segs > 1)) {
 					filemap_set_next_iovec(&cur_iov,
 							&iov_base, status);
+					buf = cur_iov->iov_base + iov_base;
+				}
 			}
 		}
 		if (unlikely(copied != bytes))

Best regards,

Anton

Signature · 4 lines
Anton Altaparmakov <aia21 at cam.ac.uk> (replace at with @)
Unix Support, Computing Service, University of Cambridge, CB2 3QH, UK
Linux NTFS maintainer / IRC: #ntfs on irc.freenode.net
WWW: http://linux-ntfs.sf.net/ & http://www-stu.christs.cam.ac.uk/~aia21/
#9 lore raw
In reply to Anton Altaparmakov
Quoted 5 lines · Anton Altaparmakov

Any reason why you left the goto out? It would be IMO much cleaner to remove the label "out" altogether and replace the single "goto out" with a "break" (which is fine since the goto happens inside the for loop immediately after which you place the label.)

No reason at all ;)

Signature · 1 line
SUSE Labs, Novell Inc.