Skip to contentSkip to conversation

ACPI based I/O APIC hot-plug

PATCH In review Kenji Kaneshige 5 participants 5 messages Apr 21, 2005 – Apr 22, 2005 1 message not in the archive ACPI

lore
Share & tools
lore
#0 lore raw

PATCH 1/3 ACPI based I/O APIC hot-plug

This patch adds the following new interfaces for I/O xAPIC hotplug. The implementation of these interfaces depends on each architecture.

o int acpi_register_ioapic(acpi_handle handle, u64 phys_addr, u32 gsi_base);

This new interface is to add a new I/O xAPIC specified by phys_addr and gsi_base pair. phys_addr is the physical address to which the I/O xAPIC is mapped and gsi_base is global system interrupt base of the I/O xAPIC. acpi_register_ioapic returns 0 on success, or negative value on error.

o int acpi_unregister_ioapic(acpi_handle handle, u32 gsi_base);

This new interface is to remove a I/O xAPIC specified by gsi_base. acpi_unregister_ioapic returns 0 on success, or negative value on error.

---

 linux-2.6.12-rc2-mm3-kanesige/arch/i386/kernel/acpi/boot.c |   16 ++++++++++++
 linux-2.6.12-rc2-mm3-kanesige/arch/ia64/kernel/acpi.c      |   17 +++++++++++++
 linux-2.6.12-rc2-mm3-kanesige/include/linux/acpi.h         |    3 ++
 3 files changed, 36 insertions(+)
arch/i386/kernel/acpi/boot.c renamed from arch/i386/kernel/acpi/boot.c~ioapic_hotplug_acpi +16 -0
diff -puN arch/i386/kernel/acpi/boot.c~ioapic_hotplug_acpi arch/i386/kernel/acpi/boot.c
@@ -506,6 +506,22 @@ acpi_unmap_lsapic(int cpu)
 EXPORT_SYMBOL(acpi_unmap_lsapic);
 #endif /* CONFIG_ACPI_HOTPLUG_CPU */
 
+int
+acpi_register_ioapic(acpi_handle handle, u64 phys_addr, u32 gsi_base)
+{
+	/* TBD */
+	return -EINVAL;
+}
+EXPORT_SYMBOL(acpi_register_ioapic);
+
+int
+acpi_unregister_ioapic(acpi_handle handle, u32 gsi_base)
+{
+	/* TBD */
+	return -EINVAL;
+}
+EXPORT_SYMBOL(acpi_unregister_ioapic);
+
 static unsigned long __init
 acpi_scan_rsdp (
 	unsigned long		start,
arch/ia64/kernel/acpi.c renamed from arch/ia64/kernel/acpi.c~ioapic_hotplug_acpi +17 -0
diff -puN arch/ia64/kernel/acpi.c~ioapic_hotplug_acpi arch/ia64/kernel/acpi.c
@@ -892,4 +892,21 @@ acpi_map_iosapic (acpi_handle handle, u3
 	return AE_OK;
 }
 #endif /* CONFIG_NUMA */
+
+int
+acpi_register_ioapic(acpi_handle handle, u64 phys_addr, u32 gsi_base)
+{
+	/* TBD */
+	return -EINVAL;
+}
+EXPORT_SYMBOL(acpi_register_ioapic);
+
+int
+acpi_unregister_ioapic(acpi_handle handle, u32 gsi_base)
+{
+	/* TBD */
+	return -EINVAL;
+}
+EXPORT_SYMBOL(acpi_unregister_ioapic);
+
 #endif /* CONFIG_ACPI_BOOT */
include/linux/acpi.h renamed from include/linux/acpi.h~ioapic_hotplug_acpi +3 -0
diff -puN include/linux/acpi.h~ioapic_hotplug_acpi include/linux/acpi.h
@@ -408,6 +408,9 @@ int acpi_map_lsapic(acpi_handle handle, 
 int acpi_unmap_lsapic(int cpu);
 #endif /* CONFIG_ACPI_HOTPLUG_CPU */
 
+int acpi_register_ioapic(acpi_handle handle, u64 phys_addr, u32 gsi_base);
+int acpi_unregister_ioapic(acpi_handle handle, u32 gsi_base);
+
 extern int acpi_mp_config;
 
 extern u32 pci_mmcfg_base_addr;

_

-------------------------------------------------------
This SF.Net email is sponsored by: New Crystal Reports XI. Version 11 adds new functionality designed to reduce time involved in creating, integrating, and deploying reporting solutions. Free runtime info, new features, or free trial, at: http://www.businessobjects.com/devxi/728

#1 lore raw
Quoted 6 lines

+++ linux-2.6.12-rc2-mm3-kanesige/arch/ia64/kernel/acpi.c 2005-04-20 10:51:30.136299152 +0900

arch/ia64/kernel/acpi.c renamed from arch/ia64/kernel/acpi.c~ioapic_hotplug_acpi +1 -0
@@ -892,4 +892,21 @@ acpi_map_iosapic (acpi_handle handle, u3
 	return AE_OK;
 }
 #endif /* CONFIG_NUMA */
+

arch/ia64/kernel/acpi.c acpi_map_iosapic (acpi_handle handle, u3 · line 905

Quoted 10 lines
arch/ia64/kernel/acpi.c renamed from arch/ia64/kernel/acpi.c~ioapic_hotplug_acpi +10 -0
+int
+acpi_register_ioapic(acpi_handle handle, u64 phys_addr, u32 gsi_base)
+{
+	/* TBD */
+	return -EINVAL;
+}
+EXPORT_SYMBOL(acpi_register_ioapic);
+
+int
+acpi_unregister_ioapic(acpi_handle handle, u32 gsi_base)

Nitpick: these declarations should follow the style of the rest of the file, i.e., add a space between the function name and the opening parenthesis.

#2 lore raw

Hi Bjorn,

Thank you very much for comments.
I'll update my patches based on your comments.

Regards,
Kenji Kaneshige

Quoted 23 lines · Bjorn Helgaas
Quoted 6 lines

+++ linux-2.6.12-rc2-mm3-kanesige/arch/ia64/kernel/acpi.c 2005-04-20 10:51:30.136299152 +0900

arch/ia64/kernel/acpi.c renamed from arch/ia64/kernel/acpi.c~ioapic_hotplug_acpi +1 -0
@@ -892,4 +892,21 @@ acpi_map_iosapic (acpi_handle handle, u3
 	return AE_OK;
 }
 #endif /* CONFIG_NUMA */
+

arch/ia64/kernel/acpi.c acpi_map_iosapic (acpi_handle handle, u3 · line 905

Quoted 10 lines
arch/ia64/kernel/acpi.c renamed from arch/ia64/kernel/acpi.c~ioapic_hotplug_acpi +10 -0
+int
+acpi_register_ioapic(acpi_handle handle, u64 phys_addr, u32 gsi_base)
+{
+	/* TBD */
+	return -EINVAL;
+}
+EXPORT_SYMBOL(acpi_register_ioapic);
+
+int
+acpi_unregister_ioapic(acpi_handle handle, u32 gsi_base)

Nitpick: these declarations should follow the style of the rest of the file, i.e., add a space between the function name and the opening parenthesis.

#3 lore raw

Am Freitag, 22. April 2005 08:38 schrieb Kenji Kaneshige:

Quoted 8 lines

Hi Bjorn,

Quoted 3 lines

Nitpick: these declarations should follow the style of the rest of the file, i.e., add a space between the function name and the opening parenthesis.

Thank you very much for comments.
I'll update my patches based on your comments.

No, please don't do this. It just causes me to send another patch to kill them alltogether.

Eike

A message that is not in the archive (sent off-list or not yet received): 200504220953.20831-rMKJyNB0tZ8LKYO4ye7UPbyZi+5vbtHrhC4ANOJQIlc@public.gmane.org

#5 lore raw
Quoted 7 lines · Rolf Eike Beer

Am Freitag, 22. April 2005 08:38 schrieb Kenji Kaneshige:

Quoted 6 lines

Hi Bjorn,

Quoted 3 lines

Nitpick: these declarations should follow the style of the rest of the file, i.e., add a space between the function name and the opening parenthesis.

Quoted 5 lines
Quoted 2 lines

Thank you very much for comments.
I'll update my patches based on your comments.

No, please don't do this. It just causes me to send another patch to kill them alltogether.

Don't be silly. If you want to change the whole file to conform to one style, fine. I even agree with the sentiment that arch/ia64 would be better off if it were more consistent with the rest of the kernel.

But isolated changes to a file should follow the style of the rest of the file.

-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click