drivers/serial/8250_acpi.c: fix a warning

PATCH In review Adrian Bunk 6 participants 8 messages Apr 15, 2005 – Apr 26, 2005 1 message not in the archive

Subsystems (3)

ACPI TTY layer and serial drivers ACPI component architecture (acpica)

lore

Share & tools

lore

Adrian Bunk

author

2005-04-15 15:10 UTC #0 lore raw

PATCH 1/1 drivers/serial/8250_acpi.c: fix a warning

This patch fixes the following warning:

<-- snip -->

...
CC drivers/serial/8250_acpi.o
drivers/serial/8250_acpi.c: In function `acpi_serial_ext_irq':
drivers/serial/8250_acpi.c:51: warning: implicit declaration of function `acpi_register_gsi'
...

<-- snip -->

This patch was already ACK'ed by Bjorn Helgaas.

Signed-off-by Adrian Bunk <[email protected]>

---

This patch was already sent on:
- 5 Apr 2005

drivers/serial/8250_acpi.c renamed from drivers/serial/8250_acpi.c.old +1 -0

@@ -9,6 +9,7 @@
  * (at your option) any later version.
  */
 
+#include <linux/config.h>
 #include <linux/acpi.h>
 #include <linux/init.h>
 #include <linux/module.h>

Alexey Dobriyan

2005-04-15 16:10 UTC #1 lore raw

drivers/serial/8250_acpi.c line 12

Quoted 10 lines · Adrian Bunk

This patch fixes the following warning:
CC drivers/serial/8250_acpi.o
drivers/serial/8250_acpi.c: In function `acpi_serial_ext_irq':
drivers/serial/8250_acpi.c:51: warning: implicit declaration of function `acpi_register_gsi'
drivers/serial/8250_acpi.c renamed from drivers/serial/8250_acpi.c.old +1 -0
 
+#include <linux/config.h>

drivers/serial/8250_acpi.c doesn't use CONFIG_ symbols.

A message that is not in the archive (sent off-list or not yet received): E1DMTPC-000ASo-00.adobriyan-mail-ru-NYYus2/[email protected]

Adrian Bunk

2005-04-16 02:38 UTC #3 lore raw

Quoted 8 lines · Alexey Dobriyan

Quoted 5 lines · Adrian Bunk
This patch fixes the following warning:
CC drivers/serial/8250_acpi.o
drivers/serial/8250_acpi.c: In function `acpi_serial_ext_irq':
drivers/serial/8250_acpi.c:51: warning: implicit declaration of function `acpi_register_gsi'

Quoted 6 lines

drivers/serial/8250_acpi.c line 12
Quoted 4 lines
drivers/serial/8250_acpi.c renamed from drivers/serial/8250_acpi.c.old +1 -0
 
+#include <linux/config.h>
drivers/serial/8250_acpi.c doesn't use CONFIG_ symbols.

8250_acpi.c #include's <acpi/acpi_bus.h> which requires config.h .

In the Linux kernel, it's more common to put such header dependencies for header files into the C files, but if the ACPI people agree a patch to add the #include <linux/config.h> to acpi_bus.h is the other possble correct solution for this issue.

cu
Adrian

Signature · 12 lines

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed



-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click

Adrian Bunk

author

2005-04-16 02:38 UTC #4 lore raw

In reply to Alexey Dobriyan

Quoted 8 lines · Alexey Dobriyan

Quoted 5 lines · Adrian Bunk
This patch fixes the following warning:
CC drivers/serial/8250_acpi.o
drivers/serial/8250_acpi.c: In function `acpi_serial_ext_irq':
drivers/serial/8250_acpi.c:51: warning: implicit declaration of function `acpi_register_gsi'

Quoted 6 lines

drivers/serial/8250_acpi.c line 12
Quoted 4 lines
drivers/serial/8250_acpi.c renamed from drivers/serial/8250_acpi.c.old +1 -0
 
+#include <linux/config.h>
drivers/serial/8250_acpi.c doesn't use CONFIG_ symbols.

8250_acpi.c #include's <acpi/acpi_bus.h> which requires config.h .

cu
Adrian

Signature · 4 lines

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Herbert Xu

2005-04-16 03:18 UTC #5 lore raw

Quoted 7 lines · Adrian Bunk

Quoted 2 lines
drivers/serial/8250_acpi.c doesn't use CONFIG_ symbols.
8250_acpi.c #include's <acpi/acpi_bus.h> which requires config.h .
In the Linux kernel, it's more common to put such header dependencies for header files into the C files, but if the ACPI people agree a patch

I disagree with this assertion. Try

grep -l linux/config.h include/linux/*.h | wc -l

Cheers,

Signature · 4 lines

Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Russell King

2005-04-16 07:59 UTC #6 lore raw

In reply to Adrian Bunk

Quoted 4 lines · Adrian Bunk

In the Linux kernel, it's more common to put such header dependencies for header files into the C files, but if the ACPI people agree a patch to add the #include <linux/config.h> to acpi_bus.h is the other possble correct solution for this issue.

With the exception of linux/config.h.

Do a 'make configcheck' and it'll tell you where linux/config.h is missing and where it shouldn't be.

Signature · 3 lines

Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core

Adrian Bunk

author

2005-04-17 18:19 UTC #7 lore raw

PATCH 1/1 ACPI: add two missing config.h #include's

Quoted 10 lines · Russell King

Quoted 4 lines · Adrian Bunk
In the Linux kernel, it's more common to put such header dependencies for header files into the C files, but if the ACPI people agree a patch to add the #include <linux/config.h> to acpi_bus.h is the other possble correct solution for this issue.
With the exception of linux/config.h.
Do a 'make configcheck' and it'll tell you where linux/config.h is missing and where it shouldn't be.

OK, then the patch below is the correct solution.

cu
Adrian

<-- snip -->

This patch fixes the following warning by adding two missing config.h #include's:

<-- snip -->

...
CC drivers/serial/8250_acpi.o
drivers/serial/8250_acpi.c: In function `acpi_serial_ext_irq':
drivers/serial/8250_acpi.c:51: warning: implicit declaration of function `acpi_register_gsi'
...

<-- snip -->

Signed-off-by Adrian Bunk <[email protected]>

include/acpi/acpi_bus.h renamed from include/acpi/acpi_bus.h.old +1 -0

@@ -26,6 +26,7 @@
 #ifndef __ACPI_BUS_H__
 #define __ACPI_BUS_H__
 
+#include <linux/config.h>
 #include <linux/kobject.h>
 
 #include <acpi/acpi.h>

include/linux/acpi.h renamed from include/linux/acpi.h.old +2 -0

@@ -25,6 +25,8 @@
 #ifndef _LINUX_ACPI_H
 #define _LINUX_ACPI_H
 
+#include <linux/config.h>
+
 #ifdef CONFIG_ACPI
 
 #ifndef _LINUX

Len Brown

Applied

2005-04-26 05:43 UTC #8 lore raw

Re: [2.6 patch] ACPI: add two missing config.h #include's

Applied.

thanks,
-Len

Quoted 69 lines · Adrian Bunk

Quoted 2 lines · Russell King
Quoted 1 line · Adrian Bunk
In the Linux kernel, it's more common to put such header
dependencies
Quoted 1 line
Quoted 1 line
for header files into the C files, but if the ACPI people agree a
patch
Quoted 1 line
Quoted 1 line
to add the #include <linux/config.h> to acpi_bus.h is the other
possble
Quoted 5 lines
Quoted 1 line
correct solution for this issue.
With the exception of linux/config.h.
Do a 'make configcheck' and it'll tell you where linux/config.h is
missing
Quoted 1 line
and where it shouldn't be.
OK, then the patch below is the correct solution.
cu
Adrian
<-- snip -->
This patch fixes the following warning by adding two missing config.h #include's:
<-- snip -->
...
CC drivers/serial/8250_acpi.o
drivers/serial/8250_acpi.c: In function `acpi_serial_ext_irq':
drivers/serial/8250_acpi.c:51: warning: implicit declaration of function
`acpi_register_gsi'
...
<-- snip -->
Signed-off-by Adrian Bunk <[email protected]>
--- linux-2.6.12-rc2-mm3-full/include/acpi/acpi_bus.h.old
2005-04-17 19:05:23.000000000 +0200
+++ linux-2.6.12-rc2-mm3-full/include/acpi/acpi_bus.h 2005-04-17
19:05:37.000000000 +0200
include/acpi/acpi_bus.h renamed from include/acpi/acpi_bus.h.old +1 -1
@@ -26,6 +26,7 @@
 #ifndef __ACPI_BUS_H__
 #define __ACPI_BUS_H__
 
+#include <linux/config.h>
 #include <linux/kobject.h>
 
 #include <acpi/acpi.h>
--- linux-2.6.12-rc2-mm3-full/include/linux/acpi.h.old  2005-04-17
19:25:51.000000000 +0200
+++ linux-2.6.12-rc2-mm3-full/include/linux/acpi.h 2005-04-17
19:24:54.000000000 +0200
include/linux/acpi.h renamed from include/linux/acpi.h.old +2 -0
@@ -25,6 +25,8 @@
 #ifndef _LINUX_ACPI_H
 #define _LINUX_ACPI_H
 
+#include <linux/config.h>
+
 #ifdef CONFIG_ACPI
 
 #ifndef _LINUX