Skip to contentSkip to conversation

more xenstore makefile fixes

PATCH In review Jerone Young 2 participants 2 messages Jun 9, 2005 – Jun 16, 2005 Kbuild

lore
Share & tools
lore

Jerone Young

author
#0 lore raw

PATCH 1/1 more xenstore makefile fixes

This allows tools in the python directory to properly link to libxenstore.a on x86-64.
--- tools/xenstore/Makefile.orig 2005-06-09 12:56:34.000000000
-0500
+++ tools/xenstore/Makefile 2005-06-09 13:48:06.000000000 -0500
@@ -20,6 +20,9 @@
BASECFLAGS+= -I.

CFLAGS+=$(BASECFLAGS)
+ifeq ($(XEN_TARGET_ARCH),x86_64)
+CFLAGS += -fPIC
+endif
LDFLAGS=$(PROFILE) -L$(XEN_LIBXC)
TESTDIR=pwd/testsuite/tmp
TESTFLAGS=-DTESTING

Signature · 4 lines
Jerone Young
IBM Linux Technology Center
[email protected]
512-838-1157 (T/L: 678-1157)
#1 lore raw
Quoted 6 lines · Jerone Young

This allows tools in the python directory to properly link to libxenstore.a on x86-64.
--- tools/xenstore/Makefile.orig 2005-06-09 12:56:34.000000000
-0500
+++ tools/xenstore/Makefile 2005-06-09 13:48:06.000000000 -0500

Review line 28

Quoted 9 lines
(quoted diff) +3 -0
@@ -20,6 +20,9 @@
 BASECFLAGS+= -I.
 
 CFLAGS+=$(BASECFLAGS)
+ifeq ($(XEN_TARGET_ARCH),x86_64)
+CFLAGS += -fPIC
+endif
 LDFLAGS=$(PROFILE) -L$(XEN_LIBXC)
 TESTDIR=`pwd`/testsuite/tmp
 TESTFLAGS=-DTESTING

Position Independent Code (PIC) is needed for shared libraries on all architectures. This has come up before, on this list even:
http://lists.xensource.com/archives/html/xen-devel/2005-02/msg00241.html

I don't expect xenstore would be very performance-critical...

Makefile 2005-06-16 10:00:53 -05:00 renamed from tools/xenstore/Makefile 2005-06-10 03:42:25 -05:00 +0 -2
@@ -20,9 +20,7 @@
 BASECFLAGS+= -I.
 
 CFLAGS += $(BASECFLAGS)
-ifeq ($(XEN_TARGET_ARCH),x86_64)
 CFLAGS += -fPIC
-endif
 LDFLAGS=$(PROFILE) -L$(XEN_LIBXC)
 TESTDIR=`pwd`/testsuite/tmp
 TESTFLAGS=-DTESTING
Signed-off-by Hollis Blanchard
Signature · 2 lines
Hollis Blanchard
IBM Linux Technology Center