Skip to contentSkip to conversation

SNMPv2 "ipv6IfStatsInAddrErrors" counter error

PATCH Lv Liangying 2 participants 2 messages Aug 21, 2006 – Aug 29, 2006

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

Hi, All

When I tested Linux kernel 2.6.17.7 about statistics
"ipv6IfStatsInAddrErrors", found that this counter couldn't increase correctly. The criteria is RFC2465:
ipv6IfStatsInAddrErrors OBJECT-TYPE

      SYNTAX      Counter32
      MAX-ACCESS  read-only
      STATUS      current

DESCRIPTION
"The number of input datagrams discarded because the IPv6 address in their IPv6 header's destination field was not a valid address to be received at this entity. This count includes invalid addresses (e.g., ::0) and unsupported addresses (e.g., addresses with unallocated prefixes). For entities which are not IPv6 routers and therefore do not forward datagrams, this counter includes datagrams discarded because the destination address was not a local address."
::= { ipv6IfStatsEntry 5 }

When I send packet to host with destination that is ether invalid address(::0) or unsupported addresses(1::1), the Linux kernel just discard the packet, and the counter doesn't increase(in the function ip6_pkt_discard).

signed-off by Lv Liangying <[email protected]>

net/ipv6/route.c +4 -0
@@ -1526,6 +1526,10 @@
 
 static int ip6_pkt_discard(struct sk_buff *skb)
 {
+	int type = ipv6_addr_type(&skb->nh.ipv6h->daddr);
+	if (type == IPV6_ADDR_ANY || type == IPV6_ADDR_RESERVED)
+		IP6_INC_STATS(IPSTATS_MIB_INADDRERRORS);
+
 	IP6_INC_STATS(IPSTATS_MIB_OUTNOROUTES);
 	icmpv6_send(skb, ICMPV6_DEST_UNREACH, ICMPV6_NOROUTE, 0, skb->dev);
 	kfree_skb(skb);
maintainer
#1 lore raw

From: Lv Liangying <[email protected]>
Date: Sun, 19 Jun 2005 16:45:04 -0400

Quoted 22 lines

Hi, All

When I tested Linux kernel 2.6.17.7 about statistics
"ipv6IfStatsInAddrErrors", found that this counter couldn't increase correctly. The criteria is RFC2465:
ipv6IfStatsInAddrErrors OBJECT-TYPE

      SYNTAX      Counter32
      MAX-ACCESS  read-only
      STATUS      current

DESCRIPTION
"The number of input datagrams discarded because the IPv6 address in their IPv6 header's destination field was not a valid address to be received at this entity. This count includes invalid addresses (e.g., ::0) and unsupported addresses (e.g., addresses with unallocated prefixes). For entities which are not IPv6 routers and therefore do not forward datagrams, this counter includes datagrams discarded because the destination address was not a local address."
::= { ipv6IfStatsEntry 5 }

Quoted 6 lines

When I send packet to host with destination that is ether invalid address(::0) or unsupported addresses(1::1), the Linux kernel just discard the packet, and the counter doesn't increase(in the function ip6_pkt_discard).

signed-off by Lv Liangying <[email protected]>

Looks good, patch applied. Thanks a lot.

BTW, the correct form of a sign off is:

Please keep the capitalization, colon character, etc. consistent with that. Thanks again.