Skip to contentSkip to conversation

Block device bringup using Xenstore

PATCH In review Rusty Russell 3 participants 5 messages Jul 7, 2005 – Jul 12, 2005

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Block device bringup using Xenstore

This megapatch updates the xenstore daemon, updates the xenbus code, and hacks the block devices to use the store rather than control messages for initialization.

We just got this to bring a block device up; tomorrow we'll be cleaning it up, getting destroy, suspend and resume working.

You'll need Anthony's experimental store-enabled vm-tools: he's sending email about it now.

Rusty.

Signature · 1 line
A bad analogy is like a leaky screwdriver -- Richard Braakman

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

#1 lore raw
Quoted 11 lines · Rusty Russell

This megapatch updates the xenstore daemon, updates the xenbus code, and hacks the block devices to use the store rather than control messages for initialization.

We just got this to bring a block device up; tomorrow we'll be cleaning it up, getting destroy, suspend and resume working.

You'll need Anthony's experimental store-enabled vm-tools: he's sending email about it now.

Rusty.

Block device and network interface setup has been working in the control tools CVS for several days, and is fully integrated with the xend tools. It would be more helpful if you would integrate with that code instead of going off on your own.

Mike

#2 lore raw
Quoted 9 lines · Mike Wray
Quoted 3 lines · Rusty Russell

This megapatch updates the xenstore daemon, updates the xenbus code, and hacks the block devices to use the store rather than control messages for initialization.

Block device and network interface setup has been working in the control tools CVS for several days, and is fully integrated with the xend tools. It would be more helpful if you would integrate with that code instead of going off on your own.

No. I completely disagree with what you've done. I disagree with how you use the store, both here and in most other places. Your changes made the xenbus code more complicated to suit a usage model which is a retrograde step.

Rather than criticise in the abstract, I believe that the way to solve these kind of disputes is to present a concrete implementation of one's idea, so people can compare. I don't expect you to implement my vision of how things should be, but it's completely incompatible with your work, and I've finally had the opportunity to implement it.

I will continue to develop this as my conscience dictates. You should do the same. As always, I aim to create code which is convincing in itself.

Rusty.

Signature · 1 line
A bad analogy is like a leaky screwdriver -- Richard Braakman
#3 lore raw
Quoted 15 lines · Rusty Russell
Quoted 11 lines · Mike Wray
Quoted 3 lines · Rusty Russell

This megapatch updates the xenstore daemon, updates the xenbus code, and hacks the block devices to use the store rather than control messages for initialization.

Block device and network interface setup has been working in the control tools CVS for several days, and is fully integrated with the xend tools. It would be more helpful if you would integrate with that code instead of going off on your own.

Quoted 4 lines

No. I completely disagree with what you've done. I disagree with how you use the store, both here and in most other places. Your changes made the xenbus code more complicated to suit a usage model which is a retrograde step.

What can I say? I was under the impression we were all working together on modifying xend and the drivers to use xenstore. Going off and doing your own thing hardly helps. If you had issues with the current code perhaps it might have been better to have raised them? Up to now you have not voiced any concerns. It's disappointing you seem to be choosing confrontation rather than collaboration.

Quoted 11 lines

Rather than criticise in the abstract, I believe that the way to solve these kind of disputes is to present a concrete implementation of one's idea, so people can compare. I don't expect you to implement my vision of how things should be, but it's completely incompatible with your work, and I've finally had the opportunity to implement it.

I will continue to develop this as my conscience dictates. You should do the same. As always, I aim to create code which is convincing in itself.

Rusty.

Regards,

Mike

#4 lore raw
In reply to Rusty Russell
Quoted 3 lines · Rusty Russell

This megapatch updates the xenstore daemon, updates the xenbus code, and hacks the block devices to use the store rather than control messages for initialization.

I've applied the xenstore daemon and xenbus driver changes. Unfortunately, the blkback/xenbus.c file is missing from the block device changes.

christian