Skip to contentSkip to conversation

NTFS: Set ictx->ir in ntfs_index_lookup

PATCH In review Yura Pakhuchiy 2 participants 2 messages Jul 22, 2005 – Jul 23, 2005

Subsystems (2)
VFS NTFS filesystem
lore
Share & tools
lore

Yura Pakhuchiy

author
#0 lore raw

PATCH 1/1 NTFS: Set ictx->ir in ntfs_index_lookup

Hi Anton,

I found bug in libntfs and after look at kernel driver it's seems that it's present in it too. ictx->ir is not set in ntfs_index_lookup if entry is placed in INDEX_ROOT, but it should point to INDEX_ROOT in which this entry placed.

Signed-off-by Yura Pakhuchiy <[email protected]>
Signature · 2 lines
Best regards,
        Yura
fs/ntfs/index.c +1 -0
diff -ruNp -X kernel.ignore ntfs-2.6-devel/fs/ntfs/index.c ntfs-2.6-yura/fs/ntfs/index.c
@@ -209,6 +209,7 @@ ir_done:
 			ictx->base_ni = base_ni;
 			ictx->ia = NULL;
 			ictx->page = NULL;
+			ictx->ir = ir;
 done:
 			ictx->entry = ie;
 			ictx->data = (u8*)ie +
#1 lore raw

Hi Yura,

Quoted 4 lines · Yura Pakhuchiy

I found bug in libntfs and after look at kernel driver it's seems that it's present in it too. ictx->ir is not set in ntfs_index_lookup if entry is placed in INDEX_ROOT, but it should point to INDEX_ROOT in which this entry placed.

Well spotted, thanks. Fix will be in next ntfs release.

Best regards,

Anton

Signature · 4 lines
Anton Altaparmakov <aia21 at cam.ac.uk> (replace at with @)
Unix Support, Computing Service, University of Cambridge, CB2 3QH, UK
Linux NTFS maintainer / IRC: #ntfs on irc.freenode.net
WWW: http://linux-ntfs.sf.net/ & http://www-stu.christs.cam.ac.uk/~aia21/