Skip to contentSkip to conversation

'config EVENT_PROFILE' - how does it ever work?

DISCUSSION [email protected] 3 participants 4 messages Jul 7, 2009

lore
Share & tools
lore
#0 lore raw

Peter - where do you prefer your e-mail? MAINTAINERS for 'perf' gives this chello.nl address, but [email protected] for other stuff? Sending to both just in case...

Found this while trying to figure out why there was a one-entry menu for performance counters.

Commit e077df4f adds to init/Kconfig this code:

config EVENT_PROFILE
bool "Tracepoint profile sources"
depends on PERF_COUNTERS && EVENT_TRACER
default y

But there's no other usage of EVENT_TRACER I can find other than a lot of 'EVENT_TRACER is not set' entries in defconfigs. Is this an actual bug, or did I lose the plot someplace?

#1 lore raw
Quoted 3 lines · On Tue, 2009-07-07 at 09:33 -0400, [email protected] wrote:

Peter - where do you prefer your e-mail? MAINTAINERS for 'perf' gives this chello.nl address, but [email protected] for other stuff? Sending to both just in case...

either work, they end up in the same inbox ;-)

Quoted 5 lines

Found this while trying to figure out why there was a one-entry menu for performance counters.

Commit e077df4f adds to init/Kconfig this code:

Quoted 8 lines

config EVENT_PROFILE
bool "Tracepoint profile sources"
depends on PERF_COUNTERS && EVENT_TRACER
default y

But there's no other usage of EVENT_TRACER I can find other than a lot of 'EVENT_TRACER is not set' entries in defconfigs. Is this an actual bug, or did I lose the plot someplace?

It used to work at some point in the past, but then I think it bitrotted a bit with the tracer changes. I think Jason Baron posted a few patches yesterday that fixed it all up and made it work nicely again.

http://lkml.org/lkml/2009/7/6/313

#2 lore raw
Quoted 6 lines · Peter Zijlstra
Quoted 3 lines · On Tue, 2009-07-07 at 09:33 -0400, [email protected] wrote:

Peter - where do you prefer your e-mail? MAINTAINERS for 'perf' gives this chello.nl address, but [email protected] for other stuff? Sending to both just in case...

either work, they end up in the same inbox ;-)

That said, infradead has proven to be more reliable than chello.nl since my ISP at times does weird things, and some headers seem to confuse its filters.

I should probably send a patch to make all the email addies the same.

#3 lore raw
In reply to Peter Zijlstra
Quoted 5 lines · Peter Zijlstra

It used to work at some point in the past, but then I think it bitrotted a bit with the tracer changes. I think Jason Baron posted a few patches yesterday that fixed it all up and made it work nicely again.

http://lkml.org/lkml/2009/7/6/313

I stuck Jason's patches on my tree, and EVENT_PROFILE is again visible in 'make menuconfig'. So I'm going to assume that the appropriate maintainer is going to shepherd these into mainline - looks small enough, and it's mostly a bitrot-fix, that Linus may accept it for .31. If not, .32 isn't *that* far off.. ;)