Skip to contentSkip to conversation

Make xend start launch XenStore

PATCH In review Anthony Liguori 3 participants 3 messages Aug 4, 2005 – Aug 5, 2005

lore
Share & tools
lore

Anthony Liguori

author
#0 lore raw

PATCH 3/3 Make xend start launch XenStore

The following patch makes tools/misc/xend start up the XenStore. It would be nicer to use init.d scripts to do this sort of stuff but this works for now.

Signed-off-by Anthony Liguori <[email protected]>

Regards,

Anthony Liguori

tools/misc/xend +14 -2
diff -r 1d240086de52 tools/misc/xend
@@ -114,6 +114,14 @@
         xcs_pidfile.close()
     except:
 	return    
+
+def start_xenstored():
+    if os.fork() == 0:
+        os.execvp('/usr/sbin/xenstored', ['/usr/sbin/xenstored']);
+
+def start_consoled():
+    if os.fork() == 0:
+        os.execvp('/usr/sbin/consoled', ['/usr/sbin/consoled']);
             
 def main():
     try:

@@ -130,11 +138,13 @@
         return status >> 8
     elif sys.argv[1] == 'start':
         start_xcs()
-        if os.fork() == 0:
-            os.execvp('/usr/sbin/consoled', ['/usr/sbin/consoled']);
+        start_xenstored()
+        start_consoled()
         return daemon.start()
     elif sys.argv[1] == 'trace_start':
         start_xcs()
+        start_xenstored()
+        start_consoled()
         return daemon.start(trace=1)
     elif sys.argv[1] == 'stop':
         stop_xcs()

@@ -142,6 +152,8 @@
     elif sys.argv[1] == 'restart':
         stop_xcs()
         start_xcs()
+        start_xenstored()
+        start_consoled()
         return daemon.stop() or daemon.start()
     elif sys.argv[1] == 'status':
         return daemon.status()

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

#1 lore raw
Quoted 3 lines · Anthony Liguori

The following patch makes tools/misc/xend start up the XenStore. It would be nicer to use init.d scripts to do this sort of stuff but this works for now.

Perhaps a xend debugging switch we can turn on now and turn off closer to release?

It'd be nice to have xenstored run with --trace-file=...

Rusty.

Signature · 1 line
A bad analogy is like a leaky screwdriver -- Richard Braakman
#2 lore raw
Quoted 9 lines · Rusty Russell
Quoted 1 line · Anthony Liguori

The following patch makes tools/misc/xend start up the XenStore. It would be nicer to use init.d scripts to do this sort of stuff but this works for now.

Perhaps a xend debugging switch we can turn on now and turn off closer to release?

It'd be nice to have xenstored run with --trace-file=...

I think this is a good idea.

And I'd even recommend turning xen debug on by default for the next month or so (I seriously doubt anyone is running current xen-unstable in a production environment - ??).

Here are the current defaults, as seen in xen/Rules.mk:

verbose     ?= n
debug       ?= n
perfc       ?= n
perfc_arrays?= n
trace       ?= n
optimize    ?= y
domu_debug  ?= n

crash_debug ?= n

Would anyone else agree to:

verbose     ?= n
debug       ?= y
perfc       ?= n
perfc_arrays?= n
trace       ?= y
optimize    ?= y
domu_debug  ?= y

crash_debug ?= y

thanks,
Nivedita