Skip to contentSkip to conversation

fix transport class corner case after rework

PATCH New James Bottomley 1 participant 1 message Aug 15, 2005

Subsystems (2)
SCSI Driver core
lore
Share & tools
lore

James Bottomley

author
#0 lore raw

PATCH 1/1 fix transport class corner case after rework

If your transport class sets the ATTRIBUTE_CONTAINER_NO_CLASSDEVS flag, then its configure method never gets called. This patch fixes that so that the configure method is called with a NULL classdev.

Also remove a spurious inverted comma in the transport_class comments.

James

drivers/base/attribute_container.c +5 -0
@@ -237,6 +237,11 @@ attribute_container_device_trigger(struc
 		if (!cont->match(cont, dev))
 			continue;
 
+		if (attribute_container_no_classdevs(cont)) {
+			fn(cont, dev, NULL);
+			continue;
+		}
+
 		spin_lock(&cont->containers_lock);
 		list_for_each_entry_safe(ic, tmp, &cont->containers, node) {
 			if (dev == ic->classdev.dev)
drivers/base/transport_class.c +1 -1
@@ -7,7 +7,7 @@
  * This file is licensed under GPLv2
  *
  * The basic idea here is to allow any "device controller" (which
- * would most often be a Host Bus Adapter" to use the services of one
+ * would most often be a Host Bus Adapter to use the services of one
  * or more tranport classes for performing transport specific
  * services.  Transport specific services are things that the generic
  * command layer doesn't want to know about (speed settings, line