Skip to contentSkip to conversation

AMD/Spansion write buffer support, splitted

PATCH New Alex BASTOS 2 participants 6 messages Aug 30, 2005 – Feb 28, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 AMD/Spansion write buffer support, splitted

Well,

This patch:
- Adds flash_write_cfibuffer support for AMD/Spansion Flashes.

This was splitted from previous patch.

Bests regards,

Alex BASTOS
-----

CHANGELOG:
* Add support for AMD/Spansion Flashes in flash_write_cfibuffer
Patch by Alex Bastos and Thomas Schaefer, 2005-08-29
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 20050830_cfi_flash_A.diff
Type: text/x-patch
Size: 5521 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20050830/540369cd/attachment.bin

#1 lore raw

PATCH 1/1 AMD/Spansion write buffer support, splitted

Dear Alex,

Quoted 5 lines · in message <[email protected]:443> you wrote:

This patch:
- Adds flash_write_cfibuffer support for AMD/Spansion Flashes.

This was splitted from previous patch.

I am confused. I have two messages from you (sent from different addresses, but both on Tue, 30 Aug 2005, with two different patches:

Quoted 6 lines

CHANGELOG:
* Add support for AMD/Spansion Flashes in flash_write_cfibuffer Patch by Alex Bastos and Thomas Schaefer, 2005-08-29

...

Quoted 1 line

Content-Type: text/x-patch; name="20050830_cfi_flash_A.diff"

and

[no CHANGELOG entry]
...

Quoted 4 lines

It may be enough shifting the address each time it is needed (in fact, only two times).

Suggestions?

...

Quoted 1 line

Content-Type: text/x-patch; name="20050830_cfi_flash_B.diff"

Are these two patches in alternative? Or additional? Or just for disussion? Or what?

Best regards,

Wolfgang Denk

Signature · 3 lines
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I paid too much for it, but its worth it.
#2 lore raw

PATCH 1/1 AMD/Spansion write buffer support, splitted

Wolfgang,

Quoted 9 lines
Quoted 5 lines

This patch:
- Adds flash_write_cfibuffer support for AMD/Spansion Flashes.

This was splitted from previous patch.

I am confused. I have two messages from you (sent from different addresses, but both on Tue, 30 Aug 2005, with two different patches:

Yeah, this is quite confusing. First one was submitted which my proposed changes. But after sending it I read some comments from Yuli Barcohen, so I send the second one with the changes for those comments (mainly, not using different command defines, but shifting the actual command).

Quoted 6 lines
Quoted 6 lines

CHANGELOG:
* Add support for AMD/Spansion Flashes in flash_write_cfibuffer Patch by Alex Bastos and Thomas Schaefer, 2005-08-29

Quoted 7 lines

...

Quoted 1 line

Content-Type: text/x-patch; name="20050830_cfi_flash_A.diff"

and

[no CHANGELOG entry]

The CHANGELOG should be the same than in thefirst patch

Quoted 11 lines
Quoted 4 lines

It may be enough shifting the address each time it is needed (in fact, only two times).

Suggestions?

...

Quoted 1 line

Content-Type: text/x-patch; name="20050830_cfi_flash_B.diff"

Are these two patches in alternative? Or additional? Or just for disussion? Or what?

So, Should I say alternative?. Maybe the second is most a RFC. Sorry about the confusing stuff.
Working with mixed environments (OS, email clients, hours, etc)

Best regards,

Alex BASTOS

#3 lore raw

PATCH 1/1 AMD/Spansion write buffer support, splitted

Dear Alex,

Quoted 5 lines · in message <[email protected]:443> you wrote:
Quoted 3 lines

Are these two patches in alternative? Or additional? Or just for disussion? Or what?

So, Should I say alternative?. Maybe the second is most a RFC.

I understand that I should dump the first and apply the second one?

Best regards,

Wolfgang Denk

Signature · 4 lines
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"If you want to eat hippopatomus, you've got to pay the  freight."  -
attributed to an IBM guy, about why IBM software uses so much memory
#4 lore raw

PATCH 1/1 AMD/Spansion write buffer support, splitted

Wolfgang,

Quoted 11 lines

Dear Alex,

Quoted 5 lines · in message <[email protected]:443> you wrote:
Quoted 3 lines

Are these two patches in alternative? Or additional? Or just for disussion? Or what?

So, Should I say alternative?. Maybe the second is most a RFC.

I understand that I should dump the first and apply the second one?

Yes, If you consider second one as good enough.

Best regards,

Alex

#5 lore raw

PATCH 1/1 AMD/Spansion write buffer support, splitted

In reply to Alex BASTOS
Quoted 5 lines · In message <[email protected]:443> you wrote:

This patch:
- Adds flash_write_cfibuffer support for AMD/Spansion Flashes.

This was splitted from previous patch.

...

Quoted 1 line

Content-Type: text/x-patch; name="20050830_cfi_flash_A.diff"

Ignored, used 20050830_cfi_flash_B.diff instead.
See following message.

Closed, thanks.

Best regards,

Wolfgang Denk

Signature · 4 lines
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Always try to do things in chronological order; it's  less  confusing
that way.