Skip to contentSkip to conversation

broken installkernel.sh with CROSS_COMPILE

RFC In review Dave Hansen 3 participants 6 messages Sep 2, 2005 – Sep 7, 2005

lore
Share & tools
lore
#0 lore raw

RFC 1/1 broken installkernel.sh with CROSS_COMPILE

I noticed that my cross-compilation 'make install' broke with 2.6.13 (I don't use it horribly often). It's from this commit:

http://www.kernel.org/git/gitweb.cgi?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=0f8e2d62fa04441cd12c08ce521e84e5bd3f8a46

Which added CROSS_COMPILE to each arch's install.sh:

if [ -x ~/bin/${CROSS_COMPILE}installkernel ]; then exec ~/bin/${CROSS_COMPILE}installkernel "$@"; fi

However, I don't just have a simple arch name as my CROSS_COMPILE, I have a whole path, so that line expands like this for me:

+ '[' -x /home/dave/bin//home/services/cross_compile/ppc64/bin/ppc64-linux-gnu-installkernel ']'

Needless to say, that doesn't work :)

Could we do something that's guaranteed to not have lots of extra path elements in it, like ARCH? Something like this?

That way, people like me who have a single installkernel script that does all of the fancy arch-detection can just do this:

	for i in `ls linux-2.6.git/arch/`; do 
		ln -s ~/bin/installkernel ~/bin/$i-installkernel
	fi

And be done with it forever.

arch/ppc64/boot/install.sh renamed from arch/ppc64/boot/install.sh.orig +1 -0
@@ -22,6 +22,7 @@
 
 # User may have a custom install script
 
+if [ -x ~/bin/${ARCH}-installkernel ]; then exec ~/bin/${ARCH}-installkernel "$@"; fi
 if [ -x ~/bin/${CROSS_COMPILE}installkernel ]; then exec ~/bin/${CROSS_COMPILE}installkernel "$@"; fi
 if [ -x /sbin/${CROSS_COMPILE}installkernel ]; then exec /sbin/${CROSS_COMPILE}installkernel "$@"; fi
 

-- Dave

#1 lore raw
Quoted 11 lines · Dave Hansen

I noticed that my cross-compilation 'make install' broke with 2.6.13 (I don't use it horribly often). It's from this commit:

http://www.kernel.org/git/gitweb.cgi?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=0f8e2d62fa04441cd12c08ce521e84e5bd3f8a46

Which added CROSS_COMPILE to each arch's install.sh:

if [ -x ~/bin/${CROSS_COMPILE}installkernel ]; then exec ~/bin/${CROSS_COMPILE}installkernel "$@"; fi

However, I don't just have a simple arch name as my CROSS_COMPILE, I have a whole path

Ah, I didn't consider that case, sorry.

Quoted 8 lines

, so that line expands like this for me:

+ '[' -x /home/dave/bin//home/services/cross_compile/ppc64/bin/ppc64-linux-gnu-installkernel ']'

Needless to say, that doesn't work :)

Could we do something that's guaranteed to not have lots of extra path elements in it, like ARCH?

Or perhaps basename ${CROSSCOMPILE}?

Ian.

Signature · 4 lines
Ian Campbell

Campbell's Law:
	Nature abhors a vacuous experimenter.
#2 lore raw
Quoted 5 lines · Ian Campbell
Quoted 1 line

Could we do something that's guaranteed to not have lots of extra

path

Quoted 1 line

elements in it, like ARCH?

Or perhaps basename ${CROSSCOMPILE}?

The only problem with that is that some people do really have a cross compiler named /usr/ppc64/bin/gcc. So, basename will just give you something useless like "bin".

-- Dave

#3 lore raw
Quoted 10 lines · Dave Hansen
Quoted 5 lines · Ian Campbell
Quoted 1 line

Could we do something that's guaranteed to not have lots of extra

path

Quoted 1 line

elements in it, like ARCH?

Or perhaps basename ${CROSSCOMPILE}?

The only problem with that is that some people do really have a cross compiler named /usr/ppc64/bin/gcc. So, basename will just give you something useless like "bin".

Of course, that makes perfect sense.

Ian.

Signature · 3 lines
Ian Campbell

It seems to make an auto driver mad if he misses you.
#4 lore raw
In reply to Dave Hansen

On Fri, Sep 02, 2005 at 01:39:13PM -0700, Dave Hansen was heard to remark:

Quoted 9 lines

I noticed that my cross-compilation 'make install' broke with 2.6.13 (I don't use it horribly often). It's from this commit:

Which added CROSS_COMPILE to each arch's install.sh:

if [ -x ~/bin/${CROSS_COMPILE}installkernel ]; then exec ~/bin/${CROSS_COMPILE}installkernel "$@"; fi

However, I don't just have a simple arch name as my CROSS_COMPILE, I have a whole path, so that line expands like this for me:

Try this:

# path to compilers and binutils, user may override by setting
# CROSS_PATH in environment
CROSS_PATH=${CROSS_PATH:-/opt/cross-3.3.2/bin}

CROSS_COMPILE=powerpc64-linux-

export PATH=$CROSS_PATH:$PATH

echo "using toolchain from $CROSS_PATH"

--linas

#5 lore raw
Quoted 17 lines · linas

On Fri, Sep 02, 2005 at 01:39:13PM -0700, Dave Hansen was heard to remark:

Quoted 9 lines

I noticed that my cross-compilation 'make install' broke with 2.6.13 (I don't use it horribly often). It's from this commit:

Which added CROSS_COMPILE to each arch's install.sh:

if [ -x ~/bin/${CROSS_COMPILE}installkernel ]; then exec ~/bin/${CROSS_COMPILE}installkernel "$@"; fi

However, I don't just have a simple arch name as my CROSS_COMPILE, I have a whole path, so that line expands like this for me:

Try this:

# path to compilers and binutils, user may override by setting
# CROSS_PATH in environment
CROSS_PATH=${CROSS_PATH:-/opt/cross-3.3.2/bin}
Quoted 5 lines

CROSS_COMPILE=powerpc64-linux-

export PATH=$CROSS_PATH:$PATH

echo "using toolchain from $CROSS_PATH"

I'm not sure I understand. Where should that be done?

-- Dave