package/at: updated version from 3.1.13 to 3.1.16
PATCH v2 1/1 package/at: updated version from 3.1.13 to 3.1.16
In order to acheive this, several adjustments were made (as follows):
* removed old patches from v3.1.13
* added reworked "Makefile.in-replace-IROOT-by-DESTDIR" patch
* added reworked "Makefile.in: fix make install for non-root, don't strip" patch
* added previous patches from v3.1.13 and left out obsolete patches
---
...001-Makefile.in-replace-IROOT-by-DESTDIR.patch} | 48 +++++++++++-------
...c-remove-manual-compiler-check-with-AC_TR.patch | 33 ------------
...fix-make-install-for-non-root-don-t-stri.patch} | 42 ++++++++++-----
...c-convert-AC_TRY_COMPILE-AC_COMPILE_IFELS.patch | 34 -------------
...-Makefile.in-add-LDFLAGS-to-linking-stage.patch | 38 --------------
...avg.c-fix.patch => 0003-getloadavg.c-fix.patch} | 0
...tch => 0004-parsetime.l-include-config-h.patch} | 0
.../at/0008-remove-glibc-__isleap-assumption.patch | 59
----------------------
package/at/at.hash | 9 ++--
package/at/at.mk | 2 +-
10 files changed, 66 insertions(+), 199 deletions(-)
rename package/at/{0004-Makefile.in-replace-IROOT-by-DESTDIR.patch => 0001-
Makefile.in-replace-IROOT-by-DESTDIR.patch} (76%)
delete mode 100644 package/at/0001-configure.ac-remove-manual-compiler-check-
with-AC_TR.patch
rename package/at/{0005-Makefile.in-make-install-fix.patch => 0002-Makefile.in-
fix-make-install-for-non-root-don-t-stri.patch} (71%)
delete mode 100644 package/at/0002-configure.ac-convert-AC_TRY_COMPILE-
AC_COMPILE_IFELS.patch
delete mode 100644 package/at/0003-Makefile.in-add-LDFLAGS-to-linking-
stage.patch
rename package/at/{0006-getloadavg.c-fix.patch => 0003-getloadavg.c-fix.patch}
(100%)
rename package/at/{0007-parsetime.l-include-config-h.patch => 0004-
parsetime.l-include-config-h.patch} (100%)
delete mode 100644 package/at/0008-remove-glibc-__isleap-assumption.patch(quoted diff) +0 -0
b/package/at/0001-Makefile.in-replace-IROOT-by-DESTDIR.patch similarity index 76%
rename from package/at/0004-Makefile.in-replace-IROOT-by-DESTDIR.patch rename to package/at/0001-Makefile.in-replace-IROOT-by-DESTDIR.patch index 0d1d5f6..90c0f17 100644
package/at/0001-Makefile.in-replace-IROOT-by-DESTDIR.patch renamed from package/at/0004-Makefile.in-replace-IROOT-by-DESTDIR.patch +12 -8
@@ -1,23 +1,27 @@ -From 195d30e2e01fe2f91ed3bdaeec3982aa66b309dd Mon Sep 17 00:00:00 2001 -From: Marc Kleine-Budde <[email protected]> -Date: Tue, 1 Dec 2009 20:57:45 +0100 -Subject: [PATCH 5/5] Makefile.in: replace IROOT by DESTDIR +From de18666063c1c7dbd9795078375f54fe5238b2ff Mon Sep 17 00:00:00 2001 +From: Francesco Nwokeka <[email protected]> +Date: Fri, 4 Sep 2015 19:15:19 +0200 +Subject: [PATCH 1/1] Makefile.in: replace IROOT by DESTDIR This patch replaces IROOT by DESTDIR, which is the autotools standard variable. For backwards compatibilty IROOT overwrites the DESTDIR. Signed-off-by: Marc Kleine-Budde <[email protected]> + +Adjusted patch to v3.1.16 + +Signed-off-by: Francesco Nwokeka <[email protected]> --- - Makefile.in | 64 +++++++++++++++++++++++++++++++----------------------------- - 1 file changed, 34 insertions(+), 30 deletions(-) + Makefile.in | 68 ++++++++++++++++++++++++++++++++----------------------------- + 1 file changed, 36 insertions(+), 32 deletions(-) -Index: at-3.1.13/Makefile.in -
===================================================================
---- at-3.1.13.orig/Makefile.in
-+++ at-3.1.13/Makefile.in
-@@ -16,6 +16,10 @@ docdir = $(prefix)/doc
- atdocdir = $(docdir)/at
+diff --git a/Makefile.in b/Makefile.in
+index 5dd2767..4297f87 100644
+--- a/Makefile.in
++++ b/Makefile.in
+@@ -17,6 +17,10 @@ atdocdir = $(docdir)/at
etcdir = @ETCDIR@
+ systemdsystemunitdir = @systemdsystemunitdir@
+ifdef IROOT
+DESTDIR = $(IROOT)
@@ -26,7 +30,7 @@ Index: at-3.1.13/Makefile.in
DAEMON_USERNAME = @DAEMON_USERNAME@
DAEMON_GROUPNAME= @DAEMON_GROUPNAME@
LOADAVG_MX = @LOADAVG_MX@
-@@ -86,38 +90,38 @@ atrun: atrun.in
+@@ -91,41 +95,41 @@ atrun: atrun.in
$(CC) -c $(CFLAGS) $(DEFS) $*.c
install: all
@@ -58,20 +62,20 @@ Index: at-3.1.13/Makefile.in
+ $(INSTALL) -g root -o root -m 755 -d $(DESTDIR)$(sbindir)
+ $(INSTALL) -g root -o root -m 755 -d $(DESTDIR)$(docdir)
+ $(INSTALL) -g root -o root -m 755 -d $(DESTDIR)$(atdocdir)
-+ $(INSTALL) -g $(DAEMON_GROUPNAME) -o $(DAEMON_USERNAME) -m 755 -d
$(DESTDIR)$(ATSPOOL_DIR) $(DESTDIR)$(ATJOB_DIR)
++ $(INSTALL) -g root -o root -m 755 -d $(DESTDIR)$(ATSPOOL_DIR)
$(DESTDIR)$(ATJOB_DIR)
+ chmod 1770 $(DESTDIR)$(ATSPOOL_DIR) $(DESTDIR)$(ATJOB_DIR)
+ touch $(DESTDIR)$(LFILE)
+ chmod 600 $(DESTDIR)$(LFILE)
+ chown $(DAEMON_USERNAME):$(DAEMON_GROUPNAME) $(DESTDIR)$(LFILE)
-+ test -f $(DESTDIR)$(etcdir)/at.allow || test -f
$(DESTDIR)$(etcdir)/at.deny || $(INSTALL) -o root -g $(DAEMON_GROUPNAME) -m 640 at.deny $(DESTDIR$
-+ $(INSTALL) -g $(DAEMON_GROUPNAME) -o $(DAEMON_USERNAME) -m 6755 -s at
$(DESTDIR)$(bindir)
++ test -f $(DESTDIR)$(etcdir)/at.allow || test -f
$(DESTDIR)$(etcdir)/at.deny || $(INSTALL) -o root -g $(DAEMON_GROUPNAME) -m 640 at.deny $(DESTDIR)$(etcdir)/
++ $(INSTALL) -g $(DAEMON_GROUPNAME) -o $(DAEMON_USERNAME) -m 6755 at
$(DESTDIR)$(bindir)
+ $(LN_S) -f at $(DESTDIR)$(bindir)/atq
+ $(LN_S) -f at $(DESTDIR)$(bindir)/atrm
+ $(INSTALL) -g root -o root -m 755 batch $(DESTDIR)$(bindir)
+ $(INSTALL) -d -o root -g root -m 755 $(DESTDIR)$(man1dir)
+ $(INSTALL) -d -o root -g root -m 755 $(DESTDIR)$(man5dir)
+ $(INSTALL) -d -o root -g root -m 755 $(DESTDIR)$(man8dir)
-+ $(INSTALL) -g root -o root -m 755 -s atd $(DESTDIR)$(sbindir)
++ $(INSTALL) -g root -o root -m 755 atd $(DESTDIR)$(sbindir)
+ $(INSTALL) -g root -o root -m 755 atrun $(DESTDIR)$(sbindir)
+ $(INSTALL) -g root -o root -m 644 at.1 $(DESTDIR)$(man1dir)/
+ cd $(DESTDIR)$(man1dir) && $(LN_S) -f at.1 atq.1 && $(LN_S) -f at.1
batch.1 && $(LN_S) -f at.1 atrm.1
@@ -92,6 +96,14 @@ Index: at-3.1.13/Makefile.in
+ rm -f $(DESTDIR)$(mandir)/cat1/at.1* $(DESTDIR)$(mandir)/cat1/batch.1* \
+ $(DESTDIR)$(mandir)/cat1/atq.1*
+ rm -f $(DESTDIR)$(mandir)/cat1/atd.8*
+ if test x"$(systemdsystemunitdir)" != xno; then \
+- $(INSTALL) -o root -g root -m 755 -d
$(IROOT)$(systemdsystemunitdir); \
+- $(INSTALL) -o root -g root -m 644 atd.service
$(IROOT)$(systemdsystemunitdir); \
++ $(INSTALL) -o root -g root -m 755 -d
$(DESTDIR)$(systemdsystemunitdir); \
++ $(INSTALL) -o root -g root -m 644 atd.service
$(DESTDIR)$(systemdsystemunitdir); \
+ fi
dist: checkin $(DIST) $(LIST) Filelist.asc
- (cd ..; tar cf - `for a in $(DIST) $(LIST); do echo at-$(VERSION)/$$a;
done` |\
+--
+2.5.1
+
(quoted diff) +0 -0
AC_TR.patch b/package/at/0001-configure.ac-remove-manual-compiler-check-with- AC_TR.patch
deleted file mode 100644
index 9e69922..0000000
--- a/package/at/0001-configure.ac-remove-manual-compiler-check-with- AC_TR.patch
+++ /dev/null
@@ -1,33 +0,0 @@
-From a182f18fa3b9fb3dd817b601b51c758f9a77f407 Mon Sep 17 00:00:00 2001 -From: Marc Kleine-Budde <[email protected]>
-Date: Tue, 1 Dec 2009 17:08:14 +0100
-Subject: [PATCH 1/5] configure.ac: remove manual compiler check with AC_TRY_RUN
-
-AC_TRY_RUN breaks cross compilation, so remove it. autotools will take -care about a working (cross-) compiler.
-
-Signed-off-by: Marc Kleine-Budde <[email protected]>
----
- configure.ac | 6 ------
- 1 files changed, 0 insertions(+), 6 deletions(-)
-
-diff --git a/configure.ac b/configure.ac
-index a8c2a14..997a37f 100644
---- a/configure.ac
-+++ b/configure.ac
-@@ -38,12 +38,6 @@ case "$host" in
- AC_MSG_RESULT(no)
- ;;
- esac
--AC_MSG_CHECKING(Trying to compile a trivial ANSI C program) --AC_TRY_RUN([ main(int ac, char **av) { return 0; } ],
-- AC_MSG_RESULT(yes), -- AC_MSG_RESULT(no) -- AC_MSG_ERROR(Could not compile and run even a trivial ANSI C program -
check CC.),
-- AC_MSG_ERROR(Could not compile and run even a trivial ANSI C program -
check CC.))
-
- AC_MSG_CHECKING(__attribute__((noreturn)))
- AC_TRY_COMPILE([], [void __attribute__((noreturn)) panic(void);],
---
-1.6.5.3
-
(quoted diff) +0 -0
b/package/at/0002-Makefile.in-fix-make-install-for-non-root-don-t-stri.patch similarity index 71%
rename from package/at/0005-Makefile.in-make-install-fix.patch rename to package/at/0002-Makefile.in-fix-make-install-for-non-root-don-t- stri.patch
index ad84344..1ba68be 100644
package/at/0002-Makefile.in-fix-make-install-for-non-root-don-t-stri.patch renamed from package/at/0005-Makefile.in-make-install-fix.patch +10 -5
@@ -1,18 +1,25 @@ -[PATCH]: Makefile.in: fix make install for non-root, don't strip +From 4d23d04285ac3e9152746fb6f6589de17be7057a Mon Sep 17 00:00:00 2001 +From: Francesco Nwokeka <[email protected]> +Date: Fri, 4 Sep 2015 19:23:15 +0200 +Subject: [PATCH 2/2] Makefile.in: fix make install for non-root, don't strip Buildroot will ensure all files are owned by root and stripped anyway (if needed) before the rootfs is created. Signed-off-by: Peter Korsgaard <[email protected]> + +Adjusted patch to v3.1.16 + +Signed-off-by: Francesco Nwokeka <[email protected]> --- - Makefile.in | 39 +++++++++++++++++++-------------------- - 1 file changed, 19 insertions(+), 20 deletions(-) + Makefile.in | 43 +++++++++++++++++++++---------------------- + 1 file changed, 21 insertions(+), 22 deletions(-) -Index: at-3.1.13/Makefile.in -
===================================================================
---- at-3.1.13.orig/Makefile.in
-+++ at-3.1.13/Makefile.in
-@@ -90,35 +90,34 @@ atrun: atrun.in
+diff --git a/Makefile.in b/Makefile.in
+index 4297f87..5d82f18 100644
+--- a/Makefile.in
++++ b/Makefile.in
+@@ -95,41 +95,40 @@ atrun: atrun.in
$(CC) -c $(CFLAGS) $(DEFS) $*.c
install: all
@@ -21,7 +28,7 @@ Index: at-3.1.13/Makefile.in
- $(INSTALL) -g root -o root -m 755 -d $(DESTDIR)$(sbindir)
- $(INSTALL) -g root -o root -m 755 -d $(DESTDIR)$(docdir)
- $(INSTALL) -g root -o root -m 755 -d $(DESTDIR)$(atdocdir)
-- $(INSTALL) -g $(DAEMON_GROUPNAME) -o $(DAEMON_USERNAME) -m 755 -d
$(DESTDIR)$(ATSPOOL_DIR) $(DESTDIR)$(ATJOB_DIR)
+- $(INSTALL) -g root -o root -m 755 -d $(DESTDIR)$(ATSPOOL_DIR)
$(DESTDIR)$(ATJOB_DIR)
+ $(INSTALL) -m 755 -d $(DESTDIR)$(etcdir)
+ $(INSTALL) -m 755 -d $(DESTDIR)$(bindir)
+ $(INSTALL) -m 755 -d $(DESTDIR)$(sbindir)
@@ -32,8 +39,8 @@ Index: at-3.1.13/Makefile.in
touch $(DESTDIR)$(LFILE)
chmod 600 $(DESTDIR)$(LFILE)
- chown $(DAEMON_USERNAME):$(DAEMON_GROUPNAME) $(DESTDIR)$(LFILE)
-- test -f $(DESTDIR)$(etcdir)/at.allow || test -f
$(DESTDIR)$(etcdir)/at.deny || $(INSTALL) -o root -g $(DAEMON_GROUPNAME) -m 640 at.deny $(DESTDIR$
-- $(INSTALL) -g $(DAEMON_GROUPNAME) -o $(DAEMON_USERNAME) -m 6755 -s at
$(DESTDIR)$(bindir)
+- test -f $(DESTDIR)$(etcdir)/at.allow || test -f $(DESTDIR)$(etcdir)/at.deny || $(INSTALL) -o root -g $(DAEMON_GROUPNAME) -m
640 at.deny $(DESTDIR)$(etcdir)/
+- $(INSTALL) -g $(DAEMON_GROUPNAME) -o $(DAEMON_USERNAME) -m 6755 at
$(DESTDIR)$(bindir)
+ test -f $(DESTDIR)$(etcdir)/at.allow || test -f
$(DESTDIR)$(etcdir)/at.deny || $(INSTALL) -m 640 at.deny $(DESTDIR)$(etcdir)/
+ $(INSTALL) -m 6755 at $(DESTDIR)$(bindir)
$(LN_S) -f at $(DESTDIR)$(bindir)/atq
@@ -42,7 +49,7 @@ Index: at-3.1.13/Makefile.in
- $(INSTALL) -d -o root -g root -m 755 $(DESTDIR)$(man1dir)
- $(INSTALL) -d -o root -g root -m 755 $(DESTDIR)$(man5dir)
- $(INSTALL) -d -o root -g root -m 755 $(DESTDIR)$(man8dir)
-- $(INSTALL) -g root -o root -m 755 -s atd $(DESTDIR)$(sbindir)
+- $(INSTALL) -g root -o root -m 755 atd $(DESTDIR)$(sbindir)
- $(INSTALL) -g root -o root -m 755 atrun $(DESTDIR)$(sbindir)
- $(INSTALL) -g root -o root -m 644 at.1 $(DESTDIR)$(man1dir)/
+ $(INSTALL) -m 755 batch $(DESTDIR)$(bindir)
@@ -67,3 +74,14 @@ Index: at-3.1.13/Makefile.in
rm -f $(DESTDIR)$(mandir)/cat1/at.1* $(DESTDIR)$(mandir)/cat1/batch.1* \
$(DESTDIR)$(mandir)/cat1/atq.1*
rm -f $(DESTDIR)$(mandir)/cat1/atd.8*
+ if test x"$(systemdsystemunitdir)" != xno; then \
+- $(INSTALL) -o root -g root -m 755 -d
$(DESTDIR)$(systemdsystemunitdir); \
+- $(INSTALL) -o root -g root -m 644 atd.service
$(DESTDIR)$(systemdsystemunitdir); \
++ $(INSTALL) -m 755 -d $(DESTDIR)$(systemdsystemunitdir); \
++ $(INSTALL) -m 644 atd.service $(DESTDIR)$(systemdsystemunitdir); \
+ fi
+
+ dist: checkin $(DIST) $(LIST) Filelist.asc
+--
+2.5.1
+
(quoted diff) +0 -0
AC_COMPILE_IFELS.patch b/package/at/0002-configure.ac-convert-AC_TRY_COMPILE- AC_COMPILE_IFELS.patch
deleted file mode 100644
index e4276ac..0000000
--- a/package/at/0002-configure.ac-convert-AC_TRY_COMPILE- AC_COMPILE_IFELS.patch
+++ /dev/null
@@ -1,34 +0,0 @@
-From e12c96cccab550eda31cf7bb1dedddd3670ffe69 Mon Sep 17 00:00:00 2001 -From: Marc Kleine-Budde <[email protected]>
-Date: Tue, 1 Dec 2009 17:22:22 +0100
-Subject: [PATCH 2/5] configure.ac: convert AC_TRY_COMPILE -> AC_COMPILE_IFELSE -
-Signed-off-by: Marc Kleine-Budde <[email protected]>
----
- configure.ac | 10 +++++-----
- 1 files changed, 5 insertions(+), 5 deletions(-)
-
-diff --git a/configure.ac b/configure.ac
-index 997a37f..cab80ed 100644
---- a/configure.ac
-+++ b/configure.ac
-@@ -40,11 +40,11 @@ case "$host" in
- esac
-
- AC_MSG_CHECKING(__attribute__((noreturn)))
--AC_TRY_COMPILE([], [void __attribute__((noreturn)) panic(void);],
-- AC_MSG_RESULT(yes)
-- AC_DEFINE(HAVE_ATTRIBUTE_NORETURN, 1,
-- [Define to 1 if compiler supports __attribute__((noreturn))]),
-- AC_MSG_RESULT(no)
-+AC_COMPILE_IFELSE(
-+ [AC_LANG_PROGRAM([[]], [[void __attribute__((noreturn))
panic(void);]])],
-+ [AC_MSG_RESULT(yes)
-+ AC_DEFINE(HAVE_ATTRIBUTE_NORETURN, 1, Define to 1 if compiler
supports __attribute__((noreturn)))],
-+ [AC_MSG_RESULT(no)]
- )
- dnl Checks for libraries.
-
---
-1.6.5.3
-
(quoted diff) +0 -0
b/package/at/0003-Makefile.in-add-LDFLAGS-to-linking-stage.patch deleted file mode 100644
index e1ab3d3..0000000
package/at/0003-Makefile.in-add-LDFLAGS-to-linking-stage.patch deleted +0 -38
@@ -1,38 +0,0 @@ -From 8720a71757f3626bf3bbc3a7aa2185e6387e5689 Mon Sep 17 00:00:00 2001 -From: Marc Kleine-Budde <[email protected]> -Date: Tue, 1 Dec 2009 20:37:31 +0100 -Subject: [PATCH 3/5] Makefile.in: add LDFLAGS to linking stage - -The linking stage ignores the LDFLAGS, this breaks if the flex library -lives in a non standard location. - -This patch add LDFLAGS to both "at" and "atd" linking stage. - -Signed-off-by: Marc Kleine-Budde <[email protected]> ---- - Makefile.in | 4 ++-- - 1 files changed, 2 insertions(+), 2 deletions(-) - -diff --git a/Makefile.in b/Makefile.in -index dae6b7d..b766bbb 100644 ---- a/Makefile.in -+++ b/Makefile.in -@@ -65,13 +65,13 @@ LIST = Filelist Filelist.asc - all: at atd atrun - - at: $(ATOBJECTS) -- $(CC) $(CFLAGS) -o at $(ATOBJECTS) $(LIBS) $(LEXLIB) -+ $(CC) $(CFLAGS) $(LDFLAGS) -o at $(ATOBJECTS) $(LIBS) $(LEXLIB) - rm -f $(CLONES) - $(LN_S) -f at atq - $(LN_S) -f at atrm - - atd: $(RUNOBJECTS) -- $(CC) $(CFLAGS) -o atd $(RUNOBJECTS) $(LIBS) $(PAMLIB) -+ $(CC) $(CFLAGS) $(LDFLAGS) -o atd $(RUNOBJECTS) $(LIBS) $(PAMLIB) - - y.tab.c y.tab.h: parsetime.y - $(YACC) -d parsetime.y --- -1.6.5.3 -
package/at/0003- renamed from package/at/0006-getloadavg.c-fix.patch +0 -0
getloadavg.c-fix.patch
similarity index 100%
rename from package/at/0006-getloadavg.c-fix.patch rename to package/at/0003-getloadavg.c-fix.patch
(quoted diff) +0 -0
b/package/at/0004-parsetime.l-include-config-h.patch similarity index 100%
rename from package/at/0007-parsetime.l-include-config-h.patch rename to package/at/0004-parsetime.l-include-config-h.patch
(quoted diff) +0 -0
b/package/at/0008-remove-glibc-__isleap-assumption.patch deleted file mode 100644
index 2152249..0000000
package/at/0008-remove-glibc-__isleap-assumption.patch deleted +0 -59
59 lines not on this page · raw message
package/at/at.hash +0 -1
@@ -1,4 +1,5 @@ -# From
http://snapshot.debian.org/archive/debian/20141023T043132Z/pool/main/a/at/at_3.1.13-2%2Bdeb7u1.dsc
-sha1 9873e0c38403ef58364912d0b505fd20798fd400 at_3.1.13.orig.tar.gz
-sha256 3a8b90868d615d21a92f4986ea9a823886329af8fae8dd7ab4eed9b273bca072
at_3.1.13.orig.tar.gz
-md5 1da61af6c29e323abaaf13ee1a8dad79 at_3.1.13.orig.tar.gz
+# From
http://snapshot.debian.org/archive/debian/20141023T043132Z/pool/main/a/at/at_3.1.16-1.dsc
+
+sha1 5ad64a471d0ed9985541e918e096f69dc2963cf0 123174 at_3.1.16.orig.tar.gz
+sha256 cb9af59c6a54edce9536ba629841055409d1f89d8ae26494727a97141fb4d5c1 at_3.1.16.orig.tar.gz
+md5 d05da75d9b75d93917ffb16ab48b1e19 at_3.1.16.orig.tar.gz
package/at/at.mk +1 -1
@@ -4,7 +4,7 @@ # ################################################################################ -AT_VERSION = 3.1.13 +AT_VERSION = 3.1.16 AT_SOURCE = at_$(AT_VERSION).orig.tar.gz AT_SITE =
http://snapshot.debian.org/archive/debian/20141023T043132Z/pool/main/a/at
# missing deps for parsetime.l
Signature · 1 line
2.5.1
A message that is not in the archive (sent off-list or not yet received): [email protected]
A message that is not in the archive (sent off-list or not yet received): 6141234.WAqyL1Ty6r@deathstar
PATCH v2 1/1 package/at: updated version from 3.1.13 to 3.1.16
Hi Francesco,
Please keep the list in CC.
[Note to list: I snipped away some of Francesco's feedback.]
Quoted 13 lines · Francesco Nwokeka
Hi Arnout,
Quoted 5 lines · On Monday 07 September 2015 21:19:04 Arnout Vandecappelle wrote:
Hi Francesco,
First of all, please use git send-email to send patches, like you did
previously. The patch below is whitespace-corrupted and doesn't apply. Much as I like KMail, it's not suitable for sending patches.The patch is too big to send via git-sendmail and i get an error like the following when trying to do so:
Quoted 8 lines
"
Net::SMTP::SSL:Net::Cmd::datasend(): unexpected EOF on command channel:
at/usr/lib/git-core/git-send-emailline 1320.
[Net::SMTP::SSL] Connection closed at/usr/lib/git-core/git-send-emailline 1320. "Here[1] they state that the patch is too big and apply a temporary fix by modifying the code @
/usr/lib/git-core/git-send-email(but I'd prefer to avoid doing that). I'm still searching for a possible fix.
Wow, so perl introduced a limit of 16KB on e-mail? Great move...
I believe you can configure kmail to not do any line splitting. If you do that, sending with kmail should be OK.
Alternatively, you can use python-smtp to send mail. But that will be a bit more work to set up...
Quoted 5 lines
[1]http://git.661346.n2.nabble.com/git-send-email-Connection-Closed-td7635648.html
Quoted 1 line · Francesco Nwokeka
[snip]
Quoted 8 lines
Quoted 1 line
Quoted 1 line
-+ $(INSTALL) -g $(DAEMON_GROUPNAME) -o $(DAEMON_USERNAME) -m 6755 -s
at
Quoted 4 lines
Quoted 1 line
$(DESTDIR)$(bindir)
This change is unrelated and actually belongs to patch 0005 (where it was
originally).Patch 0005 doesn't exist. It's all in one now.
No, you renamed patch 0005 to patch 0002, and according to its comment it still
does make install for non-root and avoid stripping.
Of course, if you remove patch 0004 (which became 0001) then all this becomes
irrelevant, because you _have_ to do those changes in patch 0005 (which will become 0001 then).
Quoted 2 lines
What's wrong with these parts
of the patch?
The patch is doing things that are not explained in its comment.
Regards,
Arnout
[snip]
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
PATCH v3 1/1 package/at: updated version from 3.1.13 to 3.1.16
In reply to Francesco NwokekaVersion 3 of the patch to update the "at" package.
The following changes were made:
* removed old patches from v3.1.13
* Merged previous Makefile.in patches into one.
* Leave only necessary patches and remove those already applied upstream
The following patches were removed because already applied upstream:
0001-configure.ac-remove-manual-compiler-check-with-AC_TR.patch 0002-configure.ac-convert-AC_TRY_COMPILE-AC_COMPILE_IFELS.patch 0003-Makefile.in-add-LDFLAGS-to-linking-stage.patch 0008-remove-glibc-__isleap-assumption.patch
Whilst the following were kept (and numbered accordingly):
0006-getloadavg.c-fix.patch
0007-parsetime.l-include-config-h.patch
---
...replace-IROOT-by-DESTDIR-and-fix-the-ins.patch} | 82 +++++++++++++---------
...c-remove-manual-compiler-check-with-AC_TR.patch | 33 ---------
...c-convert-AC_TRY_COMPILE-AC_COMPILE_IFELS.patch | 34 ---------
...avg.c-fix.patch => 0002-getloadavg.c-fix.patch} | 0
...-Makefile.in-add-LDFLAGS-to-linking-stage.patch | 38 ----------
...tch => 0003-parsetime.l-include-config-h.patch} | 0
package/at/0005-Makefile.in-make-install-fix.patch | 69 ------------------
.../at/0008-remove-glibc-__isleap-assumption.patch | 59 ----------------
package/at/at.hash | 9 +--
package/at/at.mk | 2 +-
10 files changed, 53 insertions(+), 273 deletions(-)
rename package/at/{0004-Makefile.in-replace-IROOT-by-DESTDIR.patch => 0001-Makefile.in-replace-IROOT-by-DESTDIR-and-fix-the-ins.patch} (56%)
delete mode 100644 package/at/0001-configure.ac-remove-manual-compiler-check-with-AC_TR.patch
delete mode 100644 package/at/0002-configure.ac-convert-AC_TRY_COMPILE-AC_COMPILE_IFELS.patch
rename package/at/{0006-getloadavg.c-fix.patch => 0002-getloadavg.c-fix.patch} (100%)
delete mode 100644 package/at/0003-Makefile.in-add-LDFLAGS-to-linking-stage.patch
rename package/at/{0007-parsetime.l-include-config-h.patch => 0003-parsetime.l-include-config-h.patch} (100%)
delete mode 100644 package/at/0005-Makefile.in-make-install-fix.patch
delete mode 100644 package/at/0008-remove-glibc-__isleap-assumption.patchpackage/at/0001-Makefile.in-replace-IROOT-by-DESTDIR-and-fix-the-ins.patch renamed from package/at/0004-Makefile.in-replace-IROOT-by-DESTDIR.patch +47 -35
@@ -1,23 +1,28 @@ -From 195d30e2e01fe2f91ed3bdaeec3982aa66b309dd Mon Sep 17 00:00:00 2001 -From: Marc Kleine-Budde <[email protected]> -Date: Tue, 1 Dec 2009 20:57:45 +0100 -Subject: [PATCH 5/5] Makefile.in: replace IROOT by DESTDIR +From da2895de020deaf836fb24c3af821608fe5fc29a Mon Sep 17 00:00:00 2001 +From: Francesco Nwokeka <[email protected]> +Date: Fri, 4 Sep 2015 19:15:19 +0200 +Subject: [PATCH 1/1] Makefile.in: replace IROOT by DESTDIR and fix the install + for non-root, don't strip -This patch replaces IROOT by DESTDIR, which is the autotools standard +This patch was adjusted from previous patches made by Marc Kleine-Budde in order to update to v3.1.16 + +The patch replaces IROOT by DESTDIR, which is the autotools standard variable. For backwards compatibilty IROOT overwrites the DESTDIR. +Plus the install is made for non-root giving 755 permissions to installed files Signed-off-by: Marc Kleine-Budde <[email protected]> +Signed-off-by: Francesco Nwokeka <[email protected]> --- - Makefile.in | 64 +++++++++++++++++++++++++++++++----------------------------- - 1 file changed, 34 insertions(+), 30 deletions(-) + Makefile.in | 67 ++++++++++++++++++++++++++++++++----------------------------- + 1 file changed, 35 insertions(+), 32 deletions(-) -Index: at-3.1.13/Makefile.in -=================================================================== ---- at-3.1.13.orig/Makefile.in -+++ at-3.1.13/Makefile.in -@@ -16,6 +16,10 @@ docdir = $(prefix)/doc - atdocdir = $(docdir)/at +diff --git a/Makefile.in b/Makefile.in +index 5dd2767..5d82f18 100644 +--- a/Makefile.in ++++ b/Makefile.in +@@ -17,6 +17,10 @@ atdocdir = $(docdir)/at etcdir = @ETCDIR@ + systemdsystemunitdir = @systemdsystemunitdir@ +ifdef IROOT +DESTDIR = $(IROOT)
@@ -26,7 +31,7 @@ Index: at-3.1.13/Makefile.in DAEMON_USERNAME = @DAEMON_USERNAME@ DAEMON_GROUPNAME= @DAEMON_GROUPNAME@ LOADAVG_MX = @LOADAVG_MX@ -@@ -86,38 +90,38 @@ atrun: atrun.in +@@ -91,41 +95,40 @@ atrun: atrun.in $(CC) -c $(CFLAGS) $(DEFS) $*.c install: all
@@ -53,32 +58,31 @@ Index: at-3.1.13/Makefile.in - $(INSTALL) -g root -o root -m 644 at.1 $(IROOT)$(man1dir)/ - cd $(IROOT)$(man1dir) && $(LN_S) -f at.1 atq.1 && $(LN_S) -f at.1 batch.1 && $(LN_S) -f at.1 atrm.1 - $(INSTALL) -g root -o root -m 644 atd.8 $(IROOT)$(man8dir)/ -+ $(INSTALL) -g root -o root -m 755 -d $(DESTDIR)$(etcdir) -+ $(INSTALL) -g root -o root -m 755 -d $(DESTDIR)$(bindir) -+ $(INSTALL) -g root -o root -m 755 -d $(DESTDIR)$(sbindir) -+ $(INSTALL) -g root -o root -m 755 -d $(DESTDIR)$(docdir) -+ $(INSTALL) -g root -o root -m 755 -d $(DESTDIR)$(atdocdir) -+ $(INSTALL) -g $(DAEMON_GROUPNAME) -o $(DAEMON_USERNAME) -m 755 -d $(DESTDIR)$(ATSPOOL_DIR) $(DESTDIR)$(ATJOB_DIR) ++ $(INSTALL) -m 755 -d $(DESTDIR)$(etcdir) ++ $(INSTALL) -m 755 -d $(DESTDIR)$(bindir) ++ $(INSTALL) -m 755 -d $(DESTDIR)$(sbindir) ++ $(INSTALL) -m 755 -d $(DESTDIR)$(docdir) ++ $(INSTALL) -m 755 -d $(DESTDIR)$(atdocdir) ++ $(INSTALL) -m 755 -d $(DESTDIR)$(ATSPOOL_DIR) $(DESTDIR)$(ATJOB_DIR) + chmod 1770 $(DESTDIR)$(ATSPOOL_DIR) $(DESTDIR)$(ATJOB_DIR) + touch $(DESTDIR)$(LFILE) + chmod 600 $(DESTDIR)$(LFILE) -+ chown $(DAEMON_USERNAME):$(DAEMON_GROUPNAME) $(DESTDIR)$(LFILE) -+ test -f $(DESTDIR)$(etcdir)/at.allow || test -f $(DESTDIR)$(etcdir)/at.deny || $(INSTALL) -o root -g $(DAEMON_GROUPNAME) -m 640 at.deny $(DESTDIR$ -+ $(INSTALL) -g $(DAEMON_GROUPNAME) -o $(DAEMON_USERNAME) -m 6755 -s at $(DESTDIR)$(bindir) ++ test -f $(DESTDIR)$(etcdir)/at.allow || test -f $(DESTDIR)$(etcdir)/at.deny || $(INSTALL) -m 640 at.deny $(DESTDIR)$(etcdir)/ ++ $(INSTALL) -m 6755 at $(DESTDIR)$(bindir) + $(LN_S) -f at $(DESTDIR)$(bindir)/atq + $(LN_S) -f at $(DESTDIR)$(bindir)/atrm -+ $(INSTALL) -g root -o root -m 755 batch $(DESTDIR)$(bindir) -+ $(INSTALL) -d -o root -g root -m 755 $(DESTDIR)$(man1dir) -+ $(INSTALL) -d -o root -g root -m 755 $(DESTDIR)$(man5dir) -+ $(INSTALL) -d -o root -g root -m 755 $(DESTDIR)$(man8dir) -+ $(INSTALL) -g root -o root -m 755 -s atd $(DESTDIR)$(sbindir) -+ $(INSTALL) -g root -o root -m 755 atrun $(DESTDIR)$(sbindir) -+ $(INSTALL) -g root -o root -m 644 at.1 $(DESTDIR)$(man1dir)/ ++ $(INSTALL) -m 755 batch $(DESTDIR)$(bindir) ++ $(INSTALL) -d -m 755 $(DESTDIR)$(man1dir) ++ $(INSTALL) -d -m 755 $(DESTDIR)$(man5dir) ++ $(INSTALL) -d -m 755 $(DESTDIR)$(man8dir) ++ $(INSTALL) -m 755 atd $(DESTDIR)$(sbindir) ++ $(INSTALL) -m 755 atrun $(DESTDIR)$(sbindir) ++ $(INSTALL) -m 644 at.1 $(DESTDIR)$(man1dir)/ + cd $(DESTDIR)$(man1dir) && $(LN_S) -f at.1 atq.1 && $(LN_S) -f at.1 batch.1 && $(LN_S) -f at.1 atrm.1 -+ $(INSTALL) -g root -o root -m 644 atd.8 $(DESTDIR)$(man8dir)/ ++ $(INSTALL) -m 644 atd.8 $(DESTDIR)$(man8dir)/ sed "s,\$${exec_prefix},$(exec_prefix),g" <atrun.8>tmpman - $(INSTALL) -g root -o root -m 644 tmpman $(IROOT)$(man8dir)/atrun.8 -+ $(INSTALL) -g root -o root -m 644 tmpman $(DESTDIR)$(man8dir)/atrun.8 ++ $(INSTALL) -m 644 tmpman $(DESTDIR)$(man8dir)/atrun.8 rm -f tmpman - $(INSTALL) -g root -o root -m 644 at.allow.5 $(IROOT)$(man5dir)/ - cd $(IROOT)$(man5dir) && $(LN_S) -f at.allow.5 at.deny.5
@@ -86,12 +90,20 @@ Index: at-3.1.13/Makefile.in - rm -f $(IROOT)$(mandir)/cat1/at.1* $(IROOT)$(mandir)/cat1/batch.1* \ - $(IROOT)$(mandir)/cat1/atq.1* - rm -f $(IROOT)$(mandir)/cat1/atd.8* -+ $(INSTALL) -g root -o root -m 644 at.allow.5 $(DESTDIR)$(man5dir)/ ++ $(INSTALL) -m 644 at.allow.5 $(DESTDIR)$(man5dir)/ + cd $(DESTDIR)$(man5dir) && $(LN_S) -f at.allow.5 at.deny.5 -+ $(INSTALL) -g root -o root -m 644 $(DOCS) $(DESTDIR)$(atdocdir) ++ $(INSTALL) -m 644 $(DOCS) $(DESTDIR)$(atdocdir) + rm -f $(DESTDIR)$(mandir)/cat1/at.1* $(DESTDIR)$(mandir)/cat1/batch.1* \ + $(DESTDIR)$(mandir)/cat1/atq.1* + rm -f $(DESTDIR)$(mandir)/cat1/atd.8* + if test x"$(systemdsystemunitdir)" != xno; then \ +- $(INSTALL) -o root -g root -m 755 -d $(IROOT)$(systemdsystemunitdir); \ +- $(INSTALL) -o root -g root -m 644 atd.service $(IROOT)$(systemdsystemunitdir); \ ++ $(INSTALL) -m 755 -d $(DESTDIR)$(systemdsystemunitdir); \ ++ $(INSTALL) -m 644 atd.service $(DESTDIR)$(systemdsystemunitdir); \ + fi dist: checkin $(DIST) $(LIST) Filelist.asc - (cd ..; tar cf - `for a in $(DIST) $(LIST); do echo at-$(VERSION)/$$a; done` |\ +-- +2.5.1 +
package/at/0001-configure.ac-remove-manual-compiler-check-with-AC_TR.patch deleted +0 -33
@@ -1,33 +0,0 @@ -From a182f18fa3b9fb3dd817b601b51c758f9a77f407 Mon Sep 17 00:00:00 2001 -From: Marc Kleine-Budde <[email protected]> -Date: Tue, 1 Dec 2009 17:08:14 +0100 -Subject: [PATCH 1/5] configure.ac: remove manual compiler check with AC_TRY_RUN - -AC_TRY_RUN breaks cross compilation, so remove it. autotools will take -care about a working (cross-) compiler. - -Signed-off-by: Marc Kleine-Budde <[email protected]> ---- - configure.ac | 6 ------ - 1 files changed, 0 insertions(+), 6 deletions(-) - -diff --git a/configure.ac b/configure.ac -index a8c2a14..997a37f 100644 ---- a/configure.ac -+++ b/configure.ac -@@ -38,12 +38,6 @@ case "$host" in - AC_MSG_RESULT(no) - ;; - esac --AC_MSG_CHECKING(Trying to compile a trivial ANSI C program) --AC_TRY_RUN([ main(int ac, char **av) { return 0; } ], -- AC_MSG_RESULT(yes), -- AC_MSG_RESULT(no) -- AC_MSG_ERROR(Could not compile and run even a trivial ANSI C program - check CC.), -- AC_MSG_ERROR(Could not compile and run even a trivial ANSI C program - check CC.)) - - AC_MSG_CHECKING(__attribute__((noreturn))) - AC_TRY_COMPILE([], [void __attribute__((noreturn)) panic(void);], --- -1.6.5.3 -
package/at/0002-configure.ac-convert-AC_TRY_COMPILE-AC_COMPILE_IFELS.patch deleted +0 -34
@@ -1,34 +0,0 @@ -From e12c96cccab550eda31cf7bb1dedddd3670ffe69 Mon Sep 17 00:00:00 2001 -From: Marc Kleine-Budde <[email protected]> -Date: Tue, 1 Dec 2009 17:22:22 +0100 -Subject: [PATCH 2/5] configure.ac: convert AC_TRY_COMPILE -> AC_COMPILE_IFELSE - -Signed-off-by: Marc Kleine-Budde <[email protected]> ---- - configure.ac | 10 +++++----- - 1 files changed, 5 insertions(+), 5 deletions(-) - -diff --git a/configure.ac b/configure.ac -index 997a37f..cab80ed 100644 ---- a/configure.ac -+++ b/configure.ac -@@ -40,11 +40,11 @@ case "$host" in - esac - - AC_MSG_CHECKING(__attribute__((noreturn))) --AC_TRY_COMPILE([], [void __attribute__((noreturn)) panic(void);], -- AC_MSG_RESULT(yes) -- AC_DEFINE(HAVE_ATTRIBUTE_NORETURN, 1, -- [Define to 1 if compiler supports __attribute__((noreturn))]), -- AC_MSG_RESULT(no) -+AC_COMPILE_IFELSE( -+ [AC_LANG_PROGRAM([[]], [[void __attribute__((noreturn)) panic(void);]])], -+ [AC_MSG_RESULT(yes) -+ AC_DEFINE(HAVE_ATTRIBUTE_NORETURN, 1, Define to 1 if compiler supports __attribute__((noreturn)))], -+ [AC_MSG_RESULT(no)] - ) - dnl Checks for libraries. - --- -1.6.5.3 -
package/at/0002-getloadavg.c-fix.patch renamed from package/at/0006-getloadavg.c-fix.patch +0 -0
package/at/0003-Makefile.in-add-LDFLAGS-to-linking-stage.patch deleted +0 -38
@@ -1,38 +0,0 @@ -From 8720a71757f3626bf3bbc3a7aa2185e6387e5689 Mon Sep 17 00:00:00 2001 -From: Marc Kleine-Budde <[email protected]> -Date: Tue, 1 Dec 2009 20:37:31 +0100 -Subject: [PATCH 3/5] Makefile.in: add LDFLAGS to linking stage - -The linking stage ignores the LDFLAGS, this breaks if the flex library -lives in a non standard location. - -This patch add LDFLAGS to both "at" and "atd" linking stage. - -Signed-off-by: Marc Kleine-Budde <[email protected]> ---- - Makefile.in | 4 ++-- - 1 files changed, 2 insertions(+), 2 deletions(-) - -diff --git a/Makefile.in b/Makefile.in -index dae6b7d..b766bbb 100644 ---- a/Makefile.in -+++ b/Makefile.in -@@ -65,13 +65,13 @@ LIST = Filelist Filelist.asc - all: at atd atrun - - at: $(ATOBJECTS) -- $(CC) $(CFLAGS) -o at $(ATOBJECTS) $(LIBS) $(LEXLIB) -+ $(CC) $(CFLAGS) $(LDFLAGS) -o at $(ATOBJECTS) $(LIBS) $(LEXLIB) - rm -f $(CLONES) - $(LN_S) -f at atq - $(LN_S) -f at atrm - - atd: $(RUNOBJECTS) -- $(CC) $(CFLAGS) -o atd $(RUNOBJECTS) $(LIBS) $(PAMLIB) -+ $(CC) $(CFLAGS) $(LDFLAGS) -o atd $(RUNOBJECTS) $(LIBS) $(PAMLIB) - - y.tab.c y.tab.h: parsetime.y - $(YACC) -d parsetime.y --- -1.6.5.3 -
package/at/0003-parsetime.l-include-config-h.patch renamed from package/at/0007-parsetime.l-include-config-h.patch +0 -0
package/at/0005-Makefile.in-make-install-fix.patch deleted +0 -69
69 lines not on this page · raw message
package/at/0008-remove-glibc-__isleap-assumption.patch deleted +0 -59
59 lines not on this page · raw message
package/at/at.hash +5 -4
@@ -1,4 +1,5 @@ -# From http://snapshot.debian.org/archive/debian/20141023T043132Z/pool/main/a/at/at_3.1.13-2%2Bdeb7u1.dsc -sha1 9873e0c38403ef58364912d0b505fd20798fd400 at_3.1.13.orig.tar.gz -sha256 3a8b90868d615d21a92f4986ea9a823886329af8fae8dd7ab4eed9b273bca072 at_3.1.13.orig.tar.gz -md5 1da61af6c29e323abaaf13ee1a8dad79 at_3.1.13.orig.tar.gz +# From http://snapshot.debian.org/archive/debian/20141023T043132Z/pool/main/a/at/at_3.1.16-1.dsc + +sha1 5ad64a471d0ed9985541e918e096f69dc2963cf0 at_3.1.16.orig.tar.gz +sha256 cb9af59c6a54edce9536ba629841055409d1f89d8ae26494727a97141fb4d5c1 at_3.1.16.orig.tar.gz +md5 d05da75d9b75d93917ffb16ab48b1e19 at_3.1.16.orig.tar.gz
package/at/at.mk +1 -1
@@ -4,7 +4,7 @@ # ################################################################################ -AT_VERSION = 3.1.13 +AT_VERSION = 3.1.16 AT_SOURCE = at_$(AT_VERSION).orig.tar.gz AT_SITE = http://snapshot.debian.org/archive/debian/20141023T043132Z/pool/main/a/at # missing deps for parsetime.l
Signature · 1 line
2.5.1
PATCH v3 1/1 package/at: updated version from 3.1.13 to 3.1.16
Quoted 1 line · Francesco Nwokeka
Version 3 of the patch to update the "at" package.
This part should be in the patch changelog, not as part of the commit message
(cfr. below).
Quoted 4 lines
The following changes were made:
* removed old patches from v3.1.13
This duplicates the "The following patches were removed" statement.
Quoted 1 line
* Merged previous Makefile.in patches into one.
Ick, that's not what I intended! We want a separate patch file for each
separate change. The two patches that you squashed into one do two distinct changes:
- change IROOT into DESTDIR
- don't try to install as root
So it's good to keep them separate.
My proposal was to drop the first patch and just use IROOT. In buildroot, we
can easily use IROOT instead of DESTDIR by setting
AT_INSTALL_TARGET_OPTS = IROOT=$(TARGET_DIR) install
Quoted 1 line
* Leave only necessary patches and remove those already applied upstream
Again, this commit message is a duplicate of the ones below.
So basically you should just mention here that patch 0005 is refreshed and
renumbered.
Quoted 8 lines
The following patches were removed because already applied upstream:
0001-configure.ac-remove-manual-compiler-check-with-AC_TR.patch 0002-configure.ac-convert-AC_TRY_COMPILE-AC_COMPILE_IFELS.patch 0003-Makefile.in-add-LDFLAGS-to-linking-stage.patch 0008-remove-glibc-__isleap-assumption.patch
Quoted 7 lines
Whilst the following were kept (and numbered accordingly):
0006-getloadavg.c-fix.patch
0007-parsetime.l-include-config-h.patch
Too many empty lines.
Quoted 1 line
Signed-off-by Francesco Nwokeka <[email protected]>
There should be a patch changelog here (after the Signed-off-by), like so:
---
v2 -> v3: squash patch 0004 and 0005 into a single patch v1 -> v2: do everything in a single commit instead of 5 commits
Regards,
Arnout
[snip]
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
PATCH v3 1/1 package/at: updated version from 3.1.13 to 3.1.16
In reply to Francesco NwokekaDear Francesco Nwokeka,
Quoted 1 line · Francesco Nwokeka
Version 3 of the patch to update the "at" package.
You received some comments from Arnout Vandecappelle on September 8th on this patch. Could you take them into account and send an updated version of the patch?
I was going to apply by fixing the problems pointed by Arnout, but one requires a bit more work:
"""
Quoted 1 line
* Merged previous Makefile.in patches into one.
Ick, that's not what I intended! We want a separate patch file for each
separate change. The two patches that you squashed into one do two
distinct changes:
- change IROOT into DESTDIR
- don't try to install as root
So it's good to keep them separate.
My proposal was to drop the first patch and just use IROOT. In buildroot, we can easily use IROOT instead of DESTDIR by setting
AT_INSTALL_TARGET_OPTS = IROOT=$(TARGET_DIR) install """
Could you fix that and send a new version?
Thanks,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH v3 1/1 package/at: updated version from 3.1.13 to 3.1.16
Quoted 24 lines · On Sunday 20 September 2015 15:08:38 Thomas Petazzoni wrote:
Dear Francesco Nwokeka,
Quoted 1 line · Francesco Nwokeka
Version 3 of the patch to update the "at" package.
You received some comments from Arnout Vandecappelle on September 8th on this patch. Could you take them into account and send an updated version of the patch?
I was going to apply by fixing the problems pointed by Arnout, but one requires a bit more work:
"""
Quoted 1 line
* Merged previous Makefile.in patches into one.
Ick, that's not what I intended! We want a separate patch file for each
separate change. The two patches that you squashed into one do two
distinct changes:- change IROOT into DESTDIR
- don't try to install as rootSo it's good to keep them separate.
Quoted 7 lines
My proposal was to drop the first patch and just use IROOT. In buildroot, we can easily use IROOT instead of DESTDIR by setting
AT_INSTALL_TARGET_OPTS= IROOT=$(TARGET_DIR) install """Could you fix that and send a new version?
Hi Thomas!
Sorry for the late reply but I've been 100% busy during this period. I'll get the patch back up and running ASAP. Sorry for the delay
Thanks,
Francesco
Quoted 4 lines
Thanks,
Thomas