Skip to contentSkip to conversation

Patch Question.

DISCUSSION Alejandro Bonilla Beeche 3 participants 3 messages Sep 22, 2005

lore
Share & tools
lore
#0 lore raw

Hi,

I have a couple of questions about sending patches. I did read the
SubmittingPatches Doc but don't recall this.

Can anyone send a patch to LKML to be applied?
How long does it normally take for a patch to be merged? If a patch is not merged and I get no Replys, what should one do?

.Alejandro

#1 lore raw
Quoted 6 lines · On Wed, 21 Sep 2005 21:01:31 -0600 Alejandro Bonilla Beeche wrote:

Hi,

I have a couple of questions about sending patches. I did read the
SubmittingPatches Doc but don't recall this.

Can anyone send a patch to LKML to be applied?

Anyone can send a patch. Whether it gets applied depends on several factors.

Quoted 1 line

How long does it normally take for a patch to be merged?

Depends on who you ask to merge it. Andrew put patches into the -mm patchset within minutes sometimes, depending on how busy he is, what else he is doing, etc.

But it varies quite a bit by driver or subsystem maintainer.

Quoted 1 line

If a patch is not merged and I get no Replys, what should one do?

Send it to the correct maintainer (driver or subsystem usually). If you can't find a correct maintainer, then send it to Andrew ([email protected]). Maybe put "[RFC]" in the Subject: line to get (more) comments on it.

---
~Randy
You can't do anything without having to do something else first. -- Belefant's Law

#2 lore raw
Quoted 12 lines · Randy.Dunlap
Quoted 6 lines · On Wed, 21 Sep 2005 21:01:31 -0600 Alejandro Bonilla Beeche wrote:

Hi,

I have a couple of questions about sending patches. I did read the
SubmittingPatches Doc but don't recall this.

Can anyone send a patch to LKML to be applied?

Anyone can send a patch. Whether it gets applied depends on several factors.

Quoted 8 lines
Quoted 1 line

How long does it normally take for a patch to be merged?

Depends on who you ask to merge it. Andrew put patches into the -mm patchset within minutes sometimes, depending on how busy he is, what else he is doing, etc.

But it varies quite a bit by driver or subsystem maintainer.

Also depends on the content of the patch. If it is tricky to read/non obvious etc it will usually draw some comments before being merged. Some patches get missed/overlooked completely - in that case it's up to you to make sure it gets resend after a while (if it draws no comments and doesn't get merged, then resending it after the next majoe, -rc or -mm release, updated to apply to that release, is usually good).
I've personally sent patches that got merged by someone within a few minutes, but I've also seen patches suddenly get merged that I had completely forgotten about that some maintainer just picked up from the list weeks after I had sent it.

Quoted 7 lines
Quoted 1 line

If a patch is not merged and I get no Replys, what should one do?

Send it to the correct maintainer (driver or subsystem usually). If you can't find a correct maintainer, then send it to Andrew ([email protected]). Maybe put "[RFC]" in the Subject: line to get (more) comments on it.

Resend the patch and check your To: and Cc: lists. Read the MAINTAINERS file to find out who to send it to, as well as comments in the top of the source file. Adding [email protected] to Cc:
in any case, in addition to other recipients, is usually a good thing as well.

--
Jesper Juhl <[email protected]>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html