modules: fix sparse warning for every MODULE_PARM

PATCH New Pavel Roskin 1 participant 1 message Oct 13, 2005 Module support

Share & tools

Pavel Roskin

author

2005-10-13 21:38 UTC #0 lore raw

PATCH 1/1 modules: fix sparse warning for every MODULE_PARM

sparse complains about every MODULE_PARM used in a module:
warning: symbol '__parm_foo' was not declared. Should it be static?

The fix is to split declaration and initialization. While MODULE_PARM is obsolete, it's not something sparse should report.

Signed-off-by Pavel Roskin <[email protected]>

include/linux/module.h +3 -1

index f05372b..84d75f3 100644
@@ -554,7 +554,9 @@ static inline void MODULE_PARM_(void) { 
 #ifdef MODULE
 /* DEPRECATED: Do not use. */
 #define MODULE_PARM(var,type)						    \
-struct obsolete_modparm __parm_##var __attribute__((section("__obsparm"))) = \
+extern struct obsolete_modparm __parm_##var \
+__attribute__((section("__obsparm"))); \
+struct obsolete_modparm __parm_##var = \
 { __stringify(var), type, &MODULE_PARM_ }; \
 __MODULE_PARM_TYPE(var, type);
 #else

Signature · 2 lines

Regards,
Pavel Roskin