Skip to contentSkip to conversation

: mv643xx_eth_showsram: Added information message when using the SRAM

PATCH In review Nicolas DET 2 participants 3 messages Oct 25, 2005 Network drivers

lore
Share & tools
lore

Nicolas DET

author
#0 lore raw

PATCH 1/1 : mv643xx_eth_showsram: Added information message when using the SRAM

Added information message when using the SRAM in mv643xx_eth_probe()

Signed-off-by Nicolas DET <[email protected]>
Signed-off-by Sven Luther <[email protected]>
drivers/net/mv643xx_eth.c +3 -0
diff -Naur a/drivers/net/mv643xx_eth.c b/drivers/net/mv643xx_eth.c
@@ -1533,6 +1533,9 @@
 	printk(KERN_NOTICE "%s: RX NAPI Enabled \n", dev->name);
 #endif
 
+	if (mp->tx_sram_size > 0)
+		printk(KERN_NOTICE "%s: Using SRAM\n", dev->name);
+
 	return 0;
 
 out:
author
#1 lore raw
Quoted 2 lines · Nicolas DET

Added information message when using the SRAM in mv643xx_eth_probe()

This is a tiny path. Nevertheless, I think it is useful to get this information.

-
Regards
Nicolas DET

#2 lore raw
In reply to Nicolas DET
Quoted 10 lines · Nicolas DET

Added information message when using the SRAM in mv643xx_eth_probe()

Signed-off-by Nicolas DET <[email protected]>
Signed-off-by Sven Luther <[email protected]>

diff -Naur a/drivers/net/mv643xx_eth.c b/drivers/net/mv643xx_eth.c

drivers/net/mv643xx_eth.c line 1541

Quoted 9 lines
drivers/net/mv643xx_eth.c +3 -0
@@ -1533,6 +1533,9 @@
 	printk(KERN_NOTICE "%s: RX NAPI Enabled \n", dev->name);
 #endif
 
+	if (mp->tx_sram_size > 0)
+		printk(KERN_NOTICE "%s: Using SRAM\n", dev->name);
+
 	return 0;
 
 out:

Do you really think this is necessary? I think this driver is already too verbose and we should be remove messages, not add them. :)

-Dale