Skip to contentSkip to conversation

pci: store PCI_INTERRUPT_PIN in pci_dev

PATCH In review Kristen Accardi 3 participants 3 messages Oct 27, 2005 ACPI

lore
Share & tools
lore
#0 lore raw

cover pci: store PCI_INTERRUPT_PIN in pci_dev

Store the value of PCI_INTERRUPT_PIN in the pci_dev structure for use later. This is useful for pci hotplug. When a device is "surprise" removed, the pci config space is no longer available. However, the pin value is needed to correctly disable the irq for the device.

--

#1 lore raw
Quoted 4 lines · Kristen Accardi

Store the value of PCI_INTERRUPT_PIN in the pci_dev structure for use later. This is useful for pci hotplug. When a device is "surprise" removed, the pci config space is no longer available. However, the pin value is needed to correctly disable the irq for the device.

Hmmm maybe it's just me..... but... isn't that both advisory and entirely unrelated to any kind of real interrupt thing? Eg dev->irq is there already and works even in the sight of IO-APICs etc etc...

#2 lore raw
Quoted 9 lines · Arjan van de Ven
Quoted 4 lines · Kristen Accardi

Store the value of PCI_INTERRUPT_PIN in the pci_dev structure for use later. This is useful for pci hotplug. When a device is "surprise" removed, the pci config space is no longer available. However, the pin value is needed to correctly disable the irq for the device.

Hmmm maybe it's just me..... but... isn't that both advisory and entirely unrelated to any kind of real interrupt thing? Eg dev->irq is there already and works even in the sight of IO-APICs etc etc...

With surprise hotplug, we can't read the pin from the card any more...